Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/ioat/ioat_test.c
Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines | |||||
{ | { | ||||
struct test_transaction *tx; | struct test_transaction *tx; | ||||
struct ioat_test *test; | struct ioat_test *test; | ||||
tx = arg; | tx = arg; | ||||
test = tx->test; | test = tx->test; | ||||
if (memcmp(tx->buf[0], tx->buf[1], tx->length) != 0) { | if (memcmp(tx->buf[0], tx->buf[1], tx->length) != 0) { | ||||
ioat_log_message(0, "miscompare found\n"); | ioat_log_message(0, "mismatch found\n"); | ||||
jimharris: I still think "miscompare" is the better term here. It is a very commonly understood and often… | |||||
cemAuthorUnsubmitted Not Done Inline ActionsI hadn't heard of it. I'm ok leaving it as-is if it's a common term in the context. cem: I hadn't heard of it. I'm ok leaving it as-is if it's a common term in the context. | |||||
test->status = IOAT_TEST_MISCOMPARE; | test->status = IOAT_TEST_MISCOMPARE; | ||||
} | } | ||||
atomic_add_32(&test->num_completions, 1); | atomic_add_32(&test->num_completions, 1); | ||||
ioat_test_transaction_destroy(tx); | ioat_test_transaction_destroy(tx); | ||||
if (test->num_completions == test->num_loops) | if (test->num_completions == test->num_loops) | ||||
wakeup(test); | wakeup(test); | ||||
} | } | ||||
▲ Show 20 Lines • Show All 128 Lines • Show Last 20 Lines |
I still think "miscompare" is the better term here. It is a very commonly understood and often used term when testing for data integrity. But it's not worth debating any further.