Differential D3456 Diff 8178 head/tools/tools/ioat/ioatcontrol.c

Changeset View

Standalone View

head/tools/tools/ioat/ioatcontrol.c

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				/*-
				* Copyright (C) 2012 Intel Corporation
				* All rights reserved.
				*
				* Redistribution and use in source and binary forms, with or without
				* modification, are permitted provided that the following conditions
				* are met:
				* 1. Redistributions of source code must retain the above copyright
				* notice, this list of conditions and the following disclaimer.
				* 2. Redistributions in binary form must reproduce the above copyright
				* notice, this list of conditions and the following disclaimer in the
				* documentation and/or other materials provided with the distribution.
				*
				* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
				* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
				* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
				* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
				* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
				* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
				* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
				* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
				* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
				* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
				* SUCH DAMAGE.
				*/

				__FBSDID("$FreeBSD$");

				#include <sys/ioctl.h>

				#include <fcntl.h>
				#include <stdio.h>
				#include <stdint.h>
				#include <stdlib.h>
				#include <sysexits.h>
				#include <unistd.h>

				#include "ioat_test.h"

				int
				main(int argc, char **argv)
				{
				struct ioat_test t;
				int fd;

				if (argc < 3) {
				printf("Usage: %s <channel #> <num_loops>\n", argv[0]);
				return (EX_USAGE);
				}

				t.channel_index = atoi(argv[1]);
				if (t.channel_index > 8) {
				ngieUnsubmitted Not Done Inline Actions What if I pass in -1? ngie: What if I pass in -1?
				cemAuthorUnsubmitted Not Done Inline Actions `channel_index` is unsigned. cem: `channel_index` is unsigned.
				printf("Channel number must be between 0 and 7.\n");
				return (EX_USAGE);
				}

				t.num_loops = atoi(argv[2]);
				ngieUnsubmitted Not Done Inline Actions Again, what if I pass in -1? ngie: Again, what if I pass in -1?
				cemAuthorUnsubmitted Not Done Inline Actions Also unsigned. cem: Also unsigned.

				fd = open("/dev/ioat_test", O_RDWR);
				if (fd < 0) {
				printf("Cannot open /dev/ioat_test\n");
				return (EX_UNAVAILABLE);
				}

				(void)ioctl(fd, IOAT_DMATEST, &t);
				ngieUnsubmitted Not Done Inline Actions It would be nice to err(3) on failure... especially because invalid data might cause t.status to blow up at the end if it's bogus. ngie: It would be nice to err(3) on failure... especially because invalid data might cause t.status…
				cemAuthorUnsubmitted Not Done Inline Actions As written, the ioctl cannot fail. The compiler cannot "blow up" t.status because it cannot know that it is not modified by `ioctl(2)`. cem: As written, the ioctl cannot fail. The compiler cannot "blow up" t.status because it cannot…
				close(fd);

				return (t.status);
				}