Differential D22146 Diff 63761 usr.sbin/valectl/Makefile

Changeset View

Standalone View

usr.sbin/valectl/Makefile

This file was added.

				# $FreeBSD$

				hrsUnsubmitted Done Inline Actions This line is not required. Please remove it. hrs: This line is not required. Please remove it.
				PROG= valectl
				MAN= valectl.8

				hrsUnsubmitted Done Inline Actions I forgot to point out this in the previous comment. This manual page should be in section 8, not 4. Please rename this with "valectl.8". hrs: I forgot to point out this in the previous comment. This manual page should be in section 8…
				WARNS?= 3

				hrsUnsubmitted Done Inline Actions I think WARNS=3 is required to build valectl because some of type casting in valectl.c is not strictly safe. Were you able to build valectl.c? Just checking. hrs: I think WARNS=3 is required to build valectl because some of type casting in valectl.c is not…
				vmaffioneAuthorUnsubmitted Done Inline Actions You are right, indeed. Without WARNS=3 (or lower) the source file does not build because of type casting. Thanks. vmaffione: You are right, indeed. Without WARNS=3 (or lower) the source file does not build because of…
				lwhsuUnsubmitted Done Inline Actions Sorry I didn't make it clear. I was asking if it is possible to fix the casting issue and keep the original WARNS level. lwhsu: Sorry I didn't make it clear. I was asking if it is possible to fix the casting issue and keep…
				vmaffioneAuthorUnsubmitted Done Inline Actions Oh I see. Unfortunately those warnings come from netmap_user.h, so I cannot fix them in this patch. vmaffione: Oh I see. Unfortunately those warnings come from netmap_user.h, so I cannot fix them in this…
				.include <bsd.prog.mk>