Changeset View
Changeset View
Standalone View
Standalone View
sys/amd64/conf/GENERIC
Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Lines | |||||
#options KCOV # Kernel Coverage Sanitizer | #options KCOV # Kernel Coverage Sanitizer | ||||
# Warning: KUBSAN can result in a kernel too large for loader to load | # Warning: KUBSAN can result in a kernel too large for loader to load | ||||
#options KUBSAN # Kernel Undefined Behavior Sanitizer | #options KUBSAN # Kernel Undefined Behavior Sanitizer | ||||
# Kernel dump features. | # Kernel dump features. | ||||
options EKCD # Support for encrypted kernel dumps | options EKCD # Support for encrypted kernel dumps | ||||
options GZIO # gzip-compressed kernel and user dumps | options GZIO # gzip-compressed kernel and user dumps | ||||
options ZSTDIO # zstd-compressed kernel and user dumps | options ZSTDIO # zstd-compressed kernel and user dumps | ||||
options DEBUGNET # debugnet networking | |||||
options NETDUMP # netdump(4) client support | options NETDUMP # netdump(4) client support | ||||
markj: I wish we had a way to automatically configure DEBUGNET if NETDUMP (or NETGDB) is configured… | |||||
Done Inline ActionsYeah, I agree it's a gap in our config system. I'm not opposed to making debugnet automatic on enable of either subsystem, but I'd prefer to just leave it as-is since it matches one of the prevailing patterns and is easier than restructuring. cem: Yeah, I agree it's a gap in our config system. I'm not opposed to making debugnet automatic on… | |||||
# Make an SMP-capable kernel by default | # Make an SMP-capable kernel by default | ||||
options SMP # Symmetric MultiProcessor Kernel | options SMP # Symmetric MultiProcessor Kernel | ||||
options EARLY_AP_STARTUP | options EARLY_AP_STARTUP | ||||
# CPU frequency control | # CPU frequency control | ||||
device cpufreq | device cpufreq | ||||
▲ Show 20 Lines • Show All 251 Lines • Show Last 20 Lines |
I wish we had a way to automatically configure DEBUGNET if NETDUMP (or NETGDB) is configured - it's unfortunate that anyone with a custom configuration containing options NETDUMP is going to have to update. Oh well.
One alternative would be to not add a new option, and instead conditionally compile the debugnet .c files depending on whether NETDUMP or NETGDB is configured. In debugnet.h we could then have
It's hacky, but I think we do similar things elsewhere for subsystems that don't have a lot of consumers as in this case. I don't strongly prefer one approach over the other though.