Changeset View
Changeset View
Standalone View
Standalone View
security/afl++/Makefile
# Created by: Fabian Keil <fk@fabiankeil.de> | # Created by: Fabian Keil <fk@fabiankeil.de> | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= afl | PORTNAME= afl | ||||
PORTVERSION= 2.54c | PORTVERSION= 2.54c | ||||
PORTREVISION= 1 | |||||
CATEGORIES= security | CATEGORIES= security | ||||
PKGNAMESUFFIX= ++ | PKGNAMESUFFIX= ++ | ||||
PATCH_SITES= https://github.com/vanhauser-thc/AFLplusplus/commit/ | PATCH_SITES= https://github.com/vanhauser-thc/AFLplusplus/commit/ | ||||
PATCHFILES= 52cbd650b7ae30c64152601fbc34350d61b3e02a.patch:-p1 \ | PATCHFILES= 52cbd650b7ae30c64152601fbc34350d61b3e02a.patch:-p1 \ | ||||
efa205289662db40382f9c2a4e83420438419bba.patch:-p1 | efa205289662db40382f9c2a4e83420438419bba.patch:-p1 | ||||
MAINTAINER= tobik@FreeBSD.org | MAINTAINER= tobik@FreeBSD.org | ||||
Show All 31 Lines | |||||
LLVM_ALL_TARGET= llvm_mode | LLVM_ALL_TARGET= llvm_mode | ||||
LLVM_TEST_TARGET= test_llvm_mode | LLVM_TEST_TARGET= test_llvm_mode | ||||
LLVM_BINARY_ALIAS= llvm-config=llvm-config${LLVM_DEFAULT} | LLVM_BINARY_ALIAS= llvm-config=llvm-config${LLVM_DEFAULT} | ||||
LLVM_VARS= CC=clang${LLVM_DEFAULT} \ | LLVM_VARS= CC=clang${LLVM_DEFAULT} \ | ||||
CXX=clang++${LLVM_DEFAULT} | CXX=clang++${LLVM_DEFAULT} | ||||
.include <bsd.port.options.mk> | .include <bsd.port.options.mk> | ||||
.if ${ARCH} == "i386" || ${ARCH} == "amd64" | .if ${ARCH} == "i386" || ${ARCH} == "amd64" | ||||
PLIST_SUB+= X86="" | PLIST_SUB+= X86="" | ||||
.else | .else | ||||
tobik: I think it is kind of ugly and confusing to set LLVM_DEFAULT like this. Ports in general should… | |||||
Done Inline Actions
Short of introducing USES=llvm (a la USES=python) there's no other way to limit range.
-devel is supposed to be always greater, so I've used 990. Given current cadence of 2 major releases per year it won't need to be changed for ~45 years. ;)
jbeich: > Ports in general should not set any `*_DEFAULT`.
Short of introducing `USES=llvm` (a la… | |||||
Done Inline ActionsThanks, reported here: https://github.com/vanhauser-thc/AFLplusplus/issues/40 tobik: Thanks, reported here: https://github.com/vanhauser-thc/AFLplusplus/issues/40 | |||||
Done Inline ActionsThis can be removed again after rP508373. tobik: This can be removed again after rP508373. | |||||
MAKE_ARGS+= AFL_NO_X86=1 | MAKE_ARGS+= AFL_NO_X86=1 | ||||
PLIST_SUB+= X86="@comment " | PLIST_SUB+= X86="@comment " | ||||
.endif | .endif | ||||
.if ${ARCH} == "i386" | .if ${ARCH} == "i386" | ||||
# Clang i386 emits .cfi_sections which base as(1) doesn't understand | # Clang i386 emits .cfi_sections which base as(1) doesn't understand | ||||
BUILD_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils | BUILD_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils | ||||
RUN_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils | RUN_DEPENDS+= ${LOCALBASE}/bin/as:devel/binutils | ||||
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines |
I think it is kind of ugly and confusing to set LLVM_DEFAULT like this. Ports in general should not set any *_DEFAULT.
Anyway it is not right with DEFAULT_VERSIONS+=llvm=-devel:
You could swap the comparisons, string first then integer, which solves the errors but will still show the warnings. Maybe do it like this instead
As for afl++ and ccls could you share the failure logs so that I can send them upstream?