Changeset View
Changeset View
Standalone View
Standalone View
sys/conf/makeLINT.mk
# $FreeBSD$ | # $FreeBSD$ | ||||
# The LINT files need to end up in the kernel source directory. | # The LINT files need to end up in the kernel source directory. | ||||
.OBJDIR: ${.CURDIR} | .OBJDIR: ${.CURDIR} | ||||
all: | all: | ||||
@echo "make LINT only" | @echo "make LINT only" | ||||
clean: | clean: | ||||
rm -f LINT | rm -f LINT | ||||
.if ${TARGET} == "amd64" || ${TARGET} == "i386" | .if ${TARGET} == "amd64" || ${TARGET} == "i386" | ||||
rm -f LINT-NOINET LINT-NOINET6 LINT-NOIP | rm -f LINT-NOINET LINT-NOINET6 LINT-NOIP | ||||
.endif | .endif | ||||
NOTES= ${.CURDIR}/../../conf/NOTES ${.CURDIR}/NOTES | NOTES+= ${.CURDIR}/../../conf/NOTES ${.CURDIR}/NOTES | ||||
jhb: I thought we'd just hack this file instead perhaps to add something like:
```
NOTES=
.if… | |||||
Done Inline ActionsYea, we could in the future, but now we can't. And we'd need to add back the ${.CURDIR}/NOTES too, which makes it too messy, imho, which is why I opted just for the default value. imp: Yea, we could in the future, but now we can't. And we'd need to add back the ${.CURDIR}/NOTES… | |||||
Done Inline ActionsIn addition, I think that the current state of the values of MACHINE_CPUARCH would mean that using it here would be hard. Based on all this, I think my approach is simpler, but we can revisit once we have MACHINE_CPUARCH=x86 for i386/amd64 in place. imp: In addition, I think that the current state of the values of MACHINE_CPUARCH would mean that… | |||||
Not Done Inline ActionsJust to be clear, we wouldn't have to add back .CURDIR/NOTES, you'd keep the existing line and have a += under it: NOTES= ${.CURDIR}/../../conf/NOTES ${.CURDIR}/NOTES .if ${TARGET} == "amd64" || ${TARGET} == "i386" NOTES+= ${.CURDIR}/../../x86/conf/NOTES .endif Either way is fine I guess, but I feel like this is clearer that we are just adding a new file instead of duplicating the default value of NOTES. jhb: Just to be clear, we wouldn't have to add back .CURDIR/NOTES, you'd keep the existing line and… | |||||
MAKELINT_SED= ${.CURDIR}/../../conf/makeLINT.sed | MAKELINT_SED= ${.CURDIR}/../../conf/makeLINT.sed | ||||
LINT: ${NOTES} ${MAKELINT_SED} | LINT: ${NOTES} ${MAKELINT_SED} | ||||
cat ${NOTES} | sed -E -n -f ${MAKELINT_SED} > ${.TARGET} | cat ${NOTES} | sed -E -n -f ${MAKELINT_SED} > ${.TARGET} | ||||
.if ${TARGET} == "amd64" || ${TARGET} == "i386" | .if ${TARGET} == "amd64" || ${TARGET} == "i386" | ||||
echo "include ${.TARGET}" > ${.TARGET}-NOINET | echo "include ${.TARGET}" > ${.TARGET}-NOINET | ||||
echo "ident ${.TARGET}-NOINET" >> ${.TARGET}-NOINET | echo "ident ${.TARGET}-NOINET" >> ${.TARGET}-NOINET | ||||
echo 'makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT="' >> ${.TARGET}-NOINET | echo 'makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT="' >> ${.TARGET}-NOINET | ||||
echo "nooptions INET" >> ${.TARGET}-NOINET | echo "nooptions INET" >> ${.TARGET}-NOINET | ||||
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines |
I thought we'd just hack this file instead perhaps to add something like:
In particular, you could replace that with something using TARGET_CPUARCH in the future.