Ports that get libtool from xorg-cat.mk should not need to also have it as a USES. There are several reasons for needing autoreconf, and keeping track of if a port gets libtool from the framework and suddenly need it as USES in the port will lead to strange issues.

I can fix the specific issue here with a work-around, but it doesn't fix the larger issue.

As a side note, without the change to xf86-video-intel to pull things from gitlab instead of cgit.freedesktop.org, the build also fails, so this is not an issue specific to the USE_GITLAB stuff.

A lot of XORG_CAT ports need libtool, so it is handled by the current framework in bsd.xorg.mk. Some ports also require autoreconf, and are currently responsible for pulling in autoreconf themselves. This works in bsd.xorg.mk. I'm trying to get the same thing to work in the new Uses/xorg-cat.mk. Currently, my best idea is to move the check for libtool_ARGS later in autoreconf.mk (in the MKPOSTINCLUDE stage. This seems to solve the issue where the check for if a port needs libtoolize is done before libtool_ARGS is defined.

Removing the libtool include from xorg-cat.mk would mean that a big number of ports needs to change, and suddenly keep track of the dependency on libtool themselves. It is possible to do this, but would make this change quite a lot larger, and also means functionality we have today get lost.