Page MenuHomeFreeBSD
Differential D20454 Diff 58102 sys/arm64/arm64/gic_v3_var.h

Changeset View

Standalone View

View Options

sys/arm64/arm64/gic_v3_var.h

Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Lines
}; };
#define GIC_INTR_ISRC(sc, irq) (&sc->gic_irqs[irq].gi_isrc) #define GIC_INTR_ISRC(sc, irq) (&sc->gic_irqs[irq].gi_isrc)
MALLOC_DECLARE(M_GIC_V3); MALLOC_DECLARE(M_GIC_V3);
/* ivars */ /* ivars */
#define GICV3_IVAR_NIRQS 1000 #define GICV3_IVAR_NIRQS 1000
#define GICV3_IVAR_REDIST_VADDR 1001 /* 1001 was GICV3_IVAR_REDIST_VADDR */
andrewUnsubmitted
Not Done
Inline Actions

I'd just remove it with a comment, e.g.:
/* 1001 was GICV3_IVAR_REDIST_VADDR */

andrew: I'd just remove it with a comment, e.g.: `/* 1001 was GICV3_IVAR_REDIST_VADDR */`
jchandraAuthorUnsubmitted
Done
Inline Actions

Will change.
(The #define looked better in my opinion, probably 'unused' was not the right description)

jchandra: Will change. (The #define looked better in my opinion, probably 'unused' was not the right…
andrewUnsubmitted
Not Done
Inline Actions

The main reason for removing the #define is to make it a compile error to continue using it.

andrew: The main reason for removing the `#define` is to make it a compile error to continue using it.
#define GICV3_IVAR_REDIST 1002 #define GICV3_IVAR_REDIST 1002
__BUS_ACCESSOR(gicv3, nirqs, GICV3, NIRQS, u_int); __BUS_ACCESSOR(gicv3, nirqs, GICV3, NIRQS, u_int);
__BUS_ACCESSOR(gicv3, redist_vaddr, GICV3, REDIST_VADDR, void *);
__BUS_ACCESSOR(gicv3, redist, GICV3, REDIST, void *); __BUS_ACCESSOR(gicv3, redist, GICV3, REDIST, void *);
/* Device methods */ /* Device methods */
int gic_v3_attach(device_t dev); int gic_v3_attach(device_t dev);
int gic_v3_detach(device_t dev); int gic_v3_detach(device_t dev);
int arm_gic_v3_intr(void *); int arm_gic_v3_intr(void *);
uint32_t gic_r_read_4(device_t, bus_size_t); uint32_t gic_r_read_4(device_t, bus_size_t);
Show All 38 Lines