Page MenuHomeFreeBSD
Differential D20367 Diff 57736 contrib/elftoolchain/libdwarf/libdwarf_reloc.c

Changeset View

Standalone View

View Options

contrib/elftoolchain/libdwarf/libdwarf_reloc.c

Context not available.
case DW_ISA_SPARC: case DW_ISA_SPARC:
return (is64 ? R_SPARC_UA64 : R_SPARC_UA32); return (is64 ? R_SPARC_UA64 : R_SPARC_UA32);
case DW_ISA_PPC: case DW_ISA_PPC:
return (R_PPC_ADDR32); return (is64 ? R_PPC_ADDR32 : R_PPC64_ADDR64);
bdragonAuthorUnsubmitted
Done
Inline Actions

OK obviously I got this one backwards.

bdragon: OK obviously I got this one backwards.
emasteUnsubmitted
Not Done
Inline Actions

where does this actually get used in the tree?

emaste: where does this actually get used in the tree?
bdragonAuthorUnsubmitted
Done
Inline Actions

It looks to me like this bit might only be used if you're using libdwarf to *generate* dwarf data. I am not convinced there's anything in-tree using it this way.

bdragon: It looks to me like this bit might only be used if you're using libdwarf to *generate* dwarf…
emasteUnsubmitted
Not Done
Inline Actions

I'm now not convinced anything is using this in or out of the tree, so it's perhaps somewhat academic. (See e.g. https://codesearch.debian.net/search?q=DW_ISA_PPC or a web search for DW_ISA_PPC)

Presumably we would treat PPC/PPC64 as with MIPS (a single DW_ISA_ constant) not as with x86 (which has two).

emaste: I'm now not convinced anything is using this in or out of the tree, so it's perhaps somewhat…
case DW_ISA_ARM: case DW_ISA_ARM:
return (R_ARM_ABS32); return (R_ARM_ABS32);
case DW_ISA_MIPS: case DW_ISA_MIPS:
Context not available.
if (rel_type == R_PPC_ADDR32) if (rel_type == R_PPC_ADDR32)
return (4); return (4);
break; break;
case EM_PPC64:
if (rel_type == R_PPC_ADDR32)
return (4);
else if (rel_type == R_PPC64_ADDR64)
return (8);
break;
case EM_MIPS: case EM_MIPS:
if (rel_type == R_MIPS_32) if (rel_type == R_MIPS_32)
return (4); return (4);
Context not available.