Differential D19985 Diff 57159 devel/zanata-platform/Makefile

Changeset View

Standalone View

devel/zanata-platform/Makefile

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PORTNAME= zanata-platform
				PORTVERSION= 4.6.2
				CATEGORIES= devel java
				MASTER_SITES= https://github.com/zanata/zanata-platform/releases/download/platform-${PORTVERSION}/ \
				https://repo1.maven.org/maven2/mysql/mysql-connector-java/${MYSQL_CONNECTOR_JAVA_VERSION}/:database
				DISTFILES= zanata-war-${PORTVERSION}.war \
				mysql-connector-java-${MYSQL_CONNECTOR_JAVA_VERSION}.jar:database
				EXTRACT_ONLY=

				matUnsubmitted Done Inline Actions Both files are versionned, this is probably not needed. mat: Both files are versionned, this is probably not needed.
				dbaioAuthorUnsubmitted Done Inline Actions right, I'll remove it. dbaio: right, I'll remove it.
				MAINTAINER= dbaio@FreeBSD.org
				COMMENT= Zanata is a web-based translation platform

				LICENSE= GPLv2 LGPL21+
				LICENSE_COMB= multi

				NO_ARCH= yes
				NO_BUILD= yes

				lwhsuUnsubmitted Done Inline Actions Is this really a required dependency? I think could be an optional dependency: http://docs.zanata.org/en/release/user-guide/system-admin/configuration/installation/ lwhsu: Is this really a required dependency? I think could be an optional dependency: http://docs.
				dbaioAuthorUnsubmitted Done Inline Actions right, I'll change this dbaio: right, I'll change this
				# It's needed this specific version, databases/mysql-connector-java51 is
				# currently with 5.1.47 version.
				lwhsuUnsubmitted Done Inline Actions It seems Zanata needs a mysql server to store data, but which is not "using" a mysql server. In other words, Zanata and mysql can be installed on different machines. Also, it seems we already pull in the mysql connector so there it doesn't need pull in mysql-client, either. lwhsu: It seems Zanata needs a mysql server to store data, but which is not "using" a mysql server.
				dbaioAuthorUnsubmitted Done Inline Actions ok, do you think it's worth to have another optional dependency or just a message about a database in the pkg-message? dbaio: ok, do you think it's worth to have another optional dependency or just a message about a…
				lwhsuUnsubmitted Done Inline Actions Can Zanata use other database? If it can only use mysql and we pulled in mysql connector, having a note to user to setup db connection settings should be fine. lwhsu: Can Zanata use other database? If it can only use mysql and we pulled in mysql connector…
				MYSQL_CONNECTOR_JAVA_VERSION= 5.1.26

				PLIST_SUB= APP_HOME=${APP_HOME}

				OPTIONS_DEFINE= CLAMAV

				OPTIONS_SINGLE= WF
				OPTIONS_SINGLE_WF= WILDFLY10 WILDFLY11 WILDFLY12 WILDFLY13 WILDFLY14 \
				WILDFLY15 WILDFLY16 WILDFLY90
				OPTIONS_DEFAULT= WILDFLY10

				CLAMAV_DESC= Clam AntiVirus
				CLAMAV_RUN_DEPENDS= clamav>=0:security/clamav

				WILDFLY10_DESC= WildFly version 10.0
				WILDFLY10_VARS= APP_HOME=${PREFIX}/wildfly10
				matUnsubmitted Not Done Inline Actions any reason the default is almost the oldest possible version ? mat: any reason the default is almost the oldest possible version ?
				dbaioAuthorUnsubmitted Done Inline Actions All Zanatta installations and instructions that I saw are using wildfly 9.X or 10.X. Their official container is using 10.X, see here, so I presumed that is safe to use the same version as default. dbaio: All Zanatta installations and instructions that I saw are using wildfly 9.X or 10.X. Their…
				WILDFLY10_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly10

				WILDFLY11_DESC= WildFly version 11.0
				WILDFLY11_VARS= APP_HOME=${PREFIX}/wildfly11
				WILDFLY11_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly11

				WILDFLY12_DESC= WildFly version 12.0
				WILDFLY12_VARS= APP_HOME=${PREFIX}/wildfly12
				WILDFLY12_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly12

				WILDFLY13_DESC= WildFly version 13.0
				WILDFLY13_VARS= APP_HOME=${PREFIX}/wildfly13
				WILDFLY13_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly13

				WILDFLY14_DESC= WildFly version 14.0
				WILDFLY14_VARS= APP_HOME=${PREFIX}/wildfly14
				WILDFLY14_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly14

				WILDFLY15_DESC= WildFly version 15.0
				WILDFLY15_VARS= APP_HOME=${PREFIX}/wildfly15
				WILDFLY15_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly15

				WILDFLY16_DESC= WildFly version 16.0
				WILDFLY16_VARS= APP_HOME=${PREFIX}/wildfly16
				WILDFLY16_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly16

				WILDFLY90_DESC= WildFly version 9.0
				WILDFLY90_VARS= APP_HOME=${PREFIX}/wildfly90
				WILDFLY90_RUN_DEPENDS= ${APP_HOME}/bin/standalone.sh:java/wildfly90

				do-install:
				@${MKDIR} ${STAGEDIR}/var/lib/zanata
				@${MKDIR} ${STAGEDIR}${APP_HOME}/standalone/deployments \
				${STAGEDIR}${APP_HOME}/standalone/configuration
				${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/zanata-war-${PORTVERSION}.war \
				${STAGEDIR}/${APP_HOME}/standalone/deployments/ROOT.war
				${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/mysql-connector-java-${MYSQL_CONNECTOR_JAVA_VERSION}.jar \
				${STAGEDIR}/${APP_HOME}/standalone/deployments/mysql-connector-java.jar
				${INSTALL_DATA} ${FILESDIR}/standalone-zanata.xml.sample \
				${STAGEDIR}/${APP_HOME}/standalone/configuration

				.include <bsd.port.mk>
				lwhsuUnsubmitted Done Inline Actions Having this file with weak default password in the installation makes me very nervous, can we at least just use a pkg-message to some (other) documents to guide users to initial the admin user data? lwhsu: Having this file with weak default password in the installation makes me very nervous, can we…
				dbaioAuthorUnsubmitted Done Inline Actions we can have another approach on this, defining a specific username as admin: advanced-configuration I'll test it first. dbaio: we can have another approach on this, defining a specific username as admin: [advanced…
				lwhsuUnsubmitted Done Inline Actions This looks better to me. I'm not sure using sql commands to create user is the official recommended way, if it really is, I think point to the document is enough. Having that .sql file installed on the system doesn't make much sense to me. lwhsu: This looks better to me. I'm not sure using sql commands to create user is the official…