Changeset View
Standalone View
sys/sys/fcntl.h
Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Lines | |||||
* XXX missing O_DSYNC, O_RSYNC. | * XXX missing O_DSYNC, O_RSYNC. | ||||
*/ | */ | ||||
#ifdef _KERNEL | #ifdef _KERNEL | ||||
/* Only for devfs d_close() flags. */ | /* Only for devfs d_close() flags. */ | ||||
#define FLASTCLOSE O_DIRECTORY | #define FLASTCLOSE O_DIRECTORY | ||||
#define FREVOKE O_VERIFY | #define FREVOKE O_VERIFY | ||||
/* Only for fo_close() from half-succeeded open */ | |||||
#define FOPENFAILED O_TTY_INIT | |||||
trasz: Unrelated change? | |||||
Done Inline ActionsVery much related. The error handling for VOP_OPEN/O_EXLOCK failures was significantly rewritten to properly handle v_writecount on error and this flag is no longer needed. Look at the change in vn_closefile(). kib: Very much related. The error handling for VOP_OPEN/O_EXLOCK failures was significantly… | |||||
Not Done Inline ActionsI might be missing something, but there's no other occurrence of O_TTY_INIT in the diff? trasz: I might be missing something, but there's no other occurrence of O_TTY_INIT in the diff? | |||||
Done Inline ActionsSure, there is no. FOPENFAILED reused open-only bit to not deplete limited flags namespace. kib: Sure, there is no. FOPENFAILED reused open-only bit to not deplete limited flags namespace. | |||||
Not Done Inline ActionsAh, okay. Commit the removal of the old #define separately, perhaps? trasz: Ah, okay. Commit the removal of the old #define separately, perhaps?
| |||||
Done Inline ActionsHow can this be done ? The define is needed right now, and it is not needed after the revision is landed. Are you proposing to commit everything but the define removal ? This is silly. kib: How can this be done ? The define is needed right now, and it is not needed after the revision… | |||||
Not Done Inline ActionsSigh, never mind, it's just me getting #define arguments backwards - I thought you were removing O_TTY_OPEN and not FOPENFAILED. Sorry for the noise. trasz: Sigh, never mind, it's just me getting #define arguments backwards - I thought you were… | |||||
/* convert from open() flags to/from fflags; convert O_RD/WR to FREAD/FWRITE */ | /* convert from open() flags to/from fflags; convert O_RD/WR to FREAD/FWRITE */ | ||||
#define FFLAGS(oflags) ((oflags) & O_EXEC ? (oflags) : (oflags) + 1) | #define FFLAGS(oflags) ((oflags) & O_EXEC ? (oflags) : (oflags) + 1) | ||||
#define OFLAGS(fflags) ((fflags) & O_EXEC ? (fflags) : (fflags) - 1) | #define OFLAGS(fflags) ((fflags) & O_EXEC ? (fflags) : (fflags) - 1) | ||||
/* bits to save after open */ | /* bits to save after open */ | ||||
#define FMASK (FREAD|FWRITE|FAPPEND|FASYNC|FFSYNC|FNONBLOCK|O_DIRECT|FEXEC) | #define FMASK (FREAD|FWRITE|FAPPEND|FASYNC|FFSYNC|FNONBLOCK|O_DIRECT|FEXEC) | ||||
/* bits settable by fcntl(F_SETFL, ...) */ | /* bits settable by fcntl(F_SETFL, ...) */ | ||||
▲ Show 20 Lines • Show All 190 Lines • Show Last 20 Lines |
Unrelated change?