Page MenuHomeFreeBSD
Differential D19779 Diff 55902 sbin/camcontrol/camcontrol.c

Changeset View

Standalone View

View Options

sbin/camcontrol/camcontrol.c

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,782 Lines • ▼ Show 20 Lines// mmc_arg |= SD_IOE_RW_BLK | SD_IOE_RW_LEN(len_arg) | SD_IO_RW_INCR;
} }
printf("CMD %d arg %d flags %02x\n", mmc_opcode, mmc_arg, mmc_flags); printf("CMD %d arg %d flags %02x\n", mmc_opcode, mmc_arg, mmc_flags);
if (mmc_data_len > 0) { if (mmc_data_len > 0) {
flags |= CAM_DIR_IN; flags |= CAM_DIR_IN;
mmc_data = malloc(mmc_data_len); mmc_data = malloc(mmc_data_len);
memset(mmc_data, 0, mmc_data_len); memset(mmc_data, 0, mmc_data_len);
memset(&mmc_d, 0, sizeof(mmc_d));
mmc_d.len = mmc_data_len; mmc_d.len = mmc_data_len;
mmc_d.data = mmc_data; mmc_d.data = mmc_data;
mmc_d.flags = MMC_DATA_READ; mmc_d.flags = MMC_DATA_READ;
} else flags |= CAM_DIR_NONE; } else flags |= CAM_DIR_NONE;
bzUnsubmitted
Done
Inline Actions

Well, given there is a memset(,0,) above it you don't need the extra assignments, do you?

bz: Well, given there is a memset(,0,) above it you don't need the extra assignments, do you?
kibabAuthorUnsubmitted
Done
Inline Actions

that memset() is for mmc_data variable, not for mmc_d. But I will better do another memset(,0,) for mmc_d as well.

kibab: that memset() is for mmc_data variable, not for mmc_d. But I will better do another memset(,0,)…
cam_fill_mmcio(&ccb->mmcio, cam_fill_mmcio(&ccb->mmcio,
/*retries*/ retry_count, /*retries*/ retry_count,
/*cbfcnp*/ NULL, /*cbfcnp*/ NULL,
/*flags*/ flags, /*flags*/ flags,
/*mmc_opcode*/ mmc_opcode, /*mmc_opcode*/ mmc_opcode,
/*mmc_arg*/ mmc_arg, /*mmc_arg*/ mmc_arg,
/*mmc_flags*/ mmc_flags, /*mmc_flags*/ mmc_flags,
/*mmc_data*/ mmc_data_len > 0 ? &mmc_d : NULL, /*mmc_data*/ mmc_data_len > 0 ? &mmc_d : NULL,
▲ Show 20 Lines • Show All 2,468 Lines • Show Last 20 Lines