Changeset View
Changeset View
Standalone View
Standalone View
sys/modules/zlib/README
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
1 - sys/crc32.h is split out of sys/libkern.h to avoid conflicts | |||||
between zlib's crc32 and system crc32. | |||||
2 - Use contrib/zstd/lib/freebsd's stdlib compatible includes. | |||||
3 - ZLIB_C is created con/kern.pre.mk to share compile paths. | |||||
-I contrib/zlib | |||||
-I sys/contrib/zstd/lib/freebsd | |||||
-DZ_PREIFX | |||||
#4 - opencryptodeflate.c | |||||
zfs.state->dummy is an address and doesn't seem to be useful. | |||||
Its DTRACE probe is removed. | |||||
Another DTRACE probe need to be changed. | |||||
#5 - zfs has its own copy of zlib, too. | |||||
- sys/cddl/contrib/opensolaris/uts/common/zmod has zlib | |||||
version 1.2.3 in 2005 | |||||
- However, it looks this code is not used and removed. | |||||
#6 - netgraph/deflate.c needs and uses FreeBSD enhancements to zlib. | |||||
Moved sys/zlib.h to netgraph/zlib.h, sys/libkern/zlib.c to | |||||
netgraph/zlib.c, and netgraph/deflate.c includes netgraph/zlib.c | |||||
to compile as a part of deflate.c. | |||||
We may consider dropping functions with the same implementation | |||||
as contrib/zlib from netgraph/zlib.c. However, this efforts | |||||
require exposing static functions to general public. | |||||
TODOs | |||||
1 - Should we move contrib/zlib to sys/contrib/zlib? | |||||
2 - GZIP APIs are redefined in multiple places as static functions. | |||||
3 - More on netgraph. |