Page MenuHomeFreeBSD
Differential D19646 Diff 55507 sys/dev/smartpqi/smartpqi_cam.c

Changeset View

Standalone View

View Options

sys/dev/smartpqi/smartpqi_cam.c

Show First 20 Lines • Show All 733 Lines • ▼ Show 20 Linesstatic int pqisrc_io_start(struct cam_sim *sim, union ccb *ccb)
} }
/* Check device state */ /* Check device state */
if (pqisrc_ctrl_offline(softs) || DEV_GONE(dvp)) { if (pqisrc_ctrl_offline(softs) || DEV_GONE(dvp)) {
ccb->ccb_h.status = CAM_DEV_NOT_THERE | CAM_REQ_CMP; ccb->ccb_h.status = CAM_DEV_NOT_THERE | CAM_REQ_CMP;
DBG_WARN("Device = %d GONE/OFFLINE\n", ccb->ccb_h.target_id); DBG_WARN("Device = %d GONE/OFFLINE\n", ccb->ccb_h.target_id);
return error; return error;
} }
/* Check device reset */ /* Check device reset */
if (DEV_RESET(dvp)) { if (dvp->reset_in_progress) {
impUnsubmitted
Not Done
Inline Actions

This file could be done as a separate commit, since it looks to be independent... I was kinda on the fence mentioning this, so if it's a hassle, it will be fine combining it.

imp: This file could be done as a separate commit, since it looks to be independent... I was kinda…
kibAuthorUnsubmitted
Done
Inline Actions

Yes, all this stuff is probably four commits total, if not more. I split at commit time.

kib: Yes, all this stuff is probably four commits total, if not more. I split at commit time.
jhbUnsubmitted
Not Done
Inline Actions

Now that there isn't a DEV_RESET method do you still need the smartpqi changes?

jhb: Now that there isn't a DEV_RESET method do you still need the smartpqi changes?
kibAuthorUnsubmitted
Done
Inline Actions

I asked myself the same question. I can remove it if you do not like it, but it stomps on the global namespace, which is why I decided to not drop the removal of single-use macro.

kib: I asked myself the same question. I can remove it if you do not like it, but it stomps on the…
jhbUnsubmitted
Not Done
Inline Actions

I don't care strongly, but I wasn't sure if this was a vendor driver and that this would introduce a local diff. sbruno@ might know as he was the last one to bring in a vendor update 8 months ago it seems.

jhb: I don't care strongly, but I wasn't sure if this was a vendor driver and that this would…
ccb->ccb_h.status = CAM_SCSI_BUSY | CAM_REQ_INPROG | CAM_BUSY; ccb->ccb_h.status = CAM_SCSI_BUSY | CAM_REQ_INPROG | CAM_BUSY;
DBG_WARN("Device %d reset returned busy\n", ccb->ccb_h.target_id); DBG_WARN("Device %d reset returned busy\n", ccb->ccb_h.target_id);
return error; return error;
} }
if (dvp->expose_device == false) { if (dvp->expose_device == false) {
ccb->ccb_h.status = CAM_DEV_NOT_THERE; ccb->ccb_h.status = CAM_DEV_NOT_THERE;
DBG_INFO("Device = %d not exposed\n", ccb->ccb_h.target_id); DBG_INFO("Device = %d not exposed\n", ccb->ccb_h.target_id);
▲ Show 20 Lines • Show All 464 Lines • Show Last 20 Lines