I don't use a linter, I simply follow the simple rules in that chapter. Feel free to complain to portlint's maintainer about it never working.

This chapter tells you in which order a Makefile should be written so that everyone can read it more easily without having to find stuff here and there.

The variables in lines 32-36 are standard framework variables, it is described in section 15.9, so they should go before the options variables which are in section 15.10. (see, 9 goes before 10 when you count on your fingers, easy.)

There is an "important" block on that page saying:

Each following block must be separated from the previous block by a single blank line.
In the following blocks, only set the variables that are required by the port. Define these variables in the order they are shown here.

Both lines are important, and should be easy to understand, if they are not clear, please explain what you do not understand, I will try to rewrite them in a more clearer way.

As per my other comment about the options variables being out of order, if you look at 15.10. Options and Helpers, its only sentence (the rest is an example) says:

define OPTIONS_DEFINE and OPTIONS_DEFAULT first, then the other OPTIONS_* variables first, then the *_DESC descriptions, then the options helpers

So, keeping this very simple rule in mind, your options block should look like this:

OPTIONS_DEFINE=	TSL
OPTIONS_DEFAULT=	TSL
OPTIONS_SUB=	yes

TSL_DESC=	Enables TSL licensed code in additon to Apache license code

TSL_CMAKE_BOOL_OFF=	APACHE_ONLY

Strange, the UI hilights the WANT_PGSQL line for me, not sure what is wrong here. But, well, the WANT_PGSQL line is the line I am talking about.