Changeset View
Standalone View
databases/timescaledb/Makefile
# Created by: Kevin Bowling <kbowling@freebsd.org> | # Created by: Kevin Bowling <kbowling@freebsd.org> | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= timescaledb | PORTNAME= timescaledb | ||||
PORTVERSION= 1.2.0 | PORTVERSION= 1.2.0 | ||||
PORTREVISION= 1 | |||||
CATEGORIES= databases | CATEGORIES= databases | ||||
MAINTAINER= kbowling@FreeBSD.org | MAINTAINER= kbowling@FreeBSD.org | ||||
COMMENT= Time-series database built on PostgreSQL | COMMENT= Time-series database built on PostgreSQL | ||||
LICENSE= APACHE20 TSL | LICENSE= APACHE20 TSL | ||||
LICENSE_COMB= multi | LICENSE_COMB= multi | ||||
LICENSE_NAME_TSL= Timescale License Agreement | LICENSE_NAME_TSL= Timescale License Agreement | ||||
LICENSE_FILE_APACHE20= ${WRKSRC}/LICENSE-APACHE | LICENSE_FILE_APACHE20= ${WRKSRC}/LICENSE-APACHE | ||||
LICENSE_FILE_TSL= ${WRKSRC}/tsl/LICENSE-TIMESCALE | LICENSE_FILE_TSL= ${WRKSRC}/tsl/LICENSE-TIMESCALE | ||||
LICENSE_PERMS_TSL= dist-mirror pkg-mirror auto-accept | LICENSE_PERMS_TSL= dist-mirror pkg-mirror auto-accept | ||||
USES= compiler:c11 cmake pgsql:9.6,10,11 ssl | USES= compiler:c11 cmake pgsql:9.6,10,11 ssl | ||||
USE_GITHUB= YES | USE_GITHUB= YES | ||||
GH_ACCOUNT= timescale | GH_ACCOUNT= timescale | ||||
OPTIONS_DEFINE= APACHEONLY | OPTIONS_DEFINE= TSL | ||||
OPTIONS_SUB= yes | OPTIONS_SUB= yes | ||||
APACHEONLY_CMAKE_BOOL= APACHE_ONLY | TSL_CMAKE_BOOL_OFF= APACHE_ONLY | ||||
APACHEONLY_DESC= Only build Apache licensed code | TSL_DESC= Enables TSL licensed code in additon to Apache license code | ||||
OPTIONS_DEFAULT= TSL | |||||
mat: Could you please reorder the variables correctly as the options section of [[ https://www. | |||||
PLIST_SUB= PORTVERSION=${PORTVERSION} | PLIST_SUB= PORTVERSION=${PORTVERSION} | ||||
SUB_FILES= pkg-message | SUB_FILES= pkg-message | ||||
SUB_LIST= PORTVERSION=${PORTVERSION} | |||||
WANT_PGSQL= server | WANT_PGSQL= server | ||||
matUnsubmitted Not Done Inline ActionsAll these need to go before options as per Chapter 15. Order of Variables in Port Makefiles. mat: All these need to go before options as per [[ https://www.freebsd.org/doc/en/books/porters… | |||||
kbowlingAuthorUnsubmitted Done Inline ActionsIf you are going to constantly neckbeard order, can you please write a linter or extend portlint to comply? Nothing on that page makes it obvious how to do this the way you want, and a machine would be a lot faster to check against. kbowling: If you are going to constantly neckbeard order, can you please write a linter or extend… | |||||
matUnsubmitted Not Done Inline ActionsI don't use a linter, I simply follow the simple rules in that chapter. Feel free to complain to portlint's maintainer about it never working. This chapter tells you in which order a Makefile should be written so that everyone can read it more easily without having to find stuff here and there. The variables in lines 32-36 are standard framework variables, it is described in section 15.9, so they should go before the options variables which are in section 15.10. (see, 9 goes before 10 when you count on your fingers, easy.) There is an "important" block on that page saying:
Both lines are important, and should be easy to understand, if they are not clear, please explain what you do not understand, I will try to rewrite them in a more clearer way. As per my other comment about the options variables being out of order, if you look at 15.10. Options and Helpers, its only sentence (the rest is an example) says:
So, keeping this very simple rule in mind, your options block should look like this: OPTIONS_DEFINE= TSL OPTIONS_DEFAULT= TSL OPTIONS_SUB= yes TSL_DESC= Enables TSL licensed code in additon to Apache license code TSL_CMAKE_BOOL_OFF= APACHE_ONLY mat: I don't use a linter, I simply follow the simple rules in that chapter. Feel free to complain… | |||||
Not Done Inline ActionsThis should still go before options. mat: This should still go before options. | |||||
Done Inline ActionsWhat should? I can't tell from the UI. kbowling: What should? I can't tell from the UI. | |||||
Not Done Inline ActionsStrange, the UI hilights the WANT_PGSQL line for me, not sure what is wrong here. But, well, the WANT_PGSQL line is the line I am talking about. mat: Strange, the UI hilights the WANT_PGSQL line for me, not sure what is wrong here. But, well… | |||||
.include <bsd.port.mk> | .include <bsd.port.mk> |
Could you please reorder the variables correctly as the options section of Chapter 15. Order of Variables in Port Makefiles says?