Differential D17947 Diff 52044 release/amd64/make-memstick.sh

Changeset View

Standalone View

release/amd64/make-memstick.sh

	#!/bin/sh			#!/bin/sh
	#			#
	# This script generates a "memstick image" (image that can be copied to a			# This script generates a "memstick image" (image that can be copied to a
	# USB memory stick) from a directory tree. Note that the script does not			# USB memory stick) from a directory tree. Note that the script does not
	# clean up after itself very well for error conditions on purpose so the			# clean up after itself very well for error conditions on purpose so the
	# problem can be diagnosed (full filesystem most likely but ...).			# problem can be diagnosed (full filesystem most likely but ...).
	#			#
	# Usage: make-memstick.sh <directory tree> <image filename>			# Usage: make-memstick.sh <directory tree> <image filename>
	#			#
	# $FreeBSD$			# $FreeBSD$
	#			#

	set -e			set -e

				scriptdir=$(dirname $(realpath $0))
				. ${scriptdir}/../../tools/boot/install-boot.sh

	PATH=/bin:/usr/bin:/sbin:/usr/sbin			PATH=/bin:/usr/bin:/sbin:/usr/sbin
	export PATH			export PATH

	if [ $# -ne 2 ]; then			if [ $# -ne 2 ]; then
	echo "make-memstick.sh /path/to/directory /path/to/image/file"			echo "make-memstick.sh /path/to/directory /path/to/image/file"
	exit 1			exit 1
	fi			fi

	if [ ! -d ${1} ]; then			if [ ! -d ${1} ]; then
	echo "${1} must be a directory"			echo "${1} must be a directory"
	exit 1			exit 1
	fi			fi

	if [ -e ${2} ]; then			if [ -e ${2} ]; then
	echo "won't overwrite ${2}"			echo "won't overwrite ${2}"
	exit 1			exit 1
	fi			fi

	echo '/dev/ufs/FreeBSD_Install / ufs ro,noatime 1 1' > ${1}/etc/fstab			echo '/dev/ufs/FreeBSD_Install / ufs ro,noatime 1 1' > ${1}/etc/fstab
	echo 'root_rw_mount="NO"' > ${1}/etc/rc.conf.local			echo 'root_rw_mount="NO"' > ${1}/etc/rc.conf.local
	makefs -B little -o label=FreeBSD_Install -o version=2 ${2}.part ${1}			makefs -B little -o label=FreeBSD_Install -o version=2 ${2}.part ${1}
	rm ${1}/etc/fstab			rm ${1}/etc/fstab
	rm ${1}/etc/rc.conf.local			rm ${1}/etc/rc.conf.local

				# Make an ESP in a file.
				espfilename=$(mktemp /tmp/efiboot.XXXXXX)
				rpokalaUnsubmitted Done Inline Actions A comment for the magic `count` value would be appreciated. rpokala: A comment for the magic `count` value would be appreciated.
				make_esp_file ${espfilename} ${fat32min} ${1}/boot/loader.efi
				impUnsubmitted Done Inline Actions It might make sense to use mktemp to create a better name. That would allow multiple copies of this script to be run at the same time by different users (or the same one). Both here and below (not specifically called out). imp: It might make sense to use mktemp to create a better name. That would allow multiple copies of…

				impUnsubmitted Done Inline Actions I'm not at all sure I like this construct... How do we know what SRCTOP is? Also the typical way to drag in a library of shell functions is to do it at the top of the file... imp: I'm not at all sure I like this construct... How do we know what SRCTOP is? Also the typical…
	mkimg -s mbr \			mkimg -s mbr \
	-b ${1}/boot/mbr \			-b ${1}/boot/mbr \
				impUnsubmitted Done Inline Actions does makefs support msdos yet? imp: does makefs support msdos yet?
				bcranAuthorUnsubmitted Done Inline Actions Not according to makefs(8). It looks like work on https://reviews.freebsd.org/D16438 stalled in September. bcran: Not according to makefs(8). It looks like work on https://reviews.freebsd.org/D16438 stalled in…
	-p efi:=${1}/boot/boot1.efifat \			-p efi:=${espfilename} \
	-p freebsd:-"mkimg -s bsd -b ${1}/boot/boot -p freebsd-ufs:=${2}.part" \			-p freebsd:-"mkimg -s bsd -b ${1}/boot/boot -p freebsd-ufs:=${2}.part" \
	-a 2 \			-a 2 \
	-o ${2}			-o ${2}
				rm ${espfilename}
				impUnsubmitted Done Inline Actions You have this same code in multiple .sh files (modulo filename). Any chance you could make it a function somewhere? imp: You have this same code in multiple .sh files (modulo filename). Any chance you could make it a…
	rm ${2}.part			rm ${2}.part