Changeset View
Changeset View
Standalone View
Standalone View
lib/libvmmapi/Makefile
# $FreeBSD$ | # $FreeBSD$ | ||||
PACKAGE=lib${LIB} | PACKAGE=lib${LIB} | ||||
LIB= vmmapi | LIB= vmmapi | ||||
SRCS= vmmapi.c vmmapi_freebsd.c | SRCS= vmmapi.c vmmapi_internal.c | ||||
INCS= vmmapi.h | INCS= vmmapi.h vmmapi_internal.h | ||||
WARNS?= 2 | WARNS?= 2 | ||||
LIBADD= util | LIBADD= util | ||||
CFLAGS+= -I${.CURDIR} | CFLAGS+= -I${.CURDIR} -I${.CURDIR}/${MACHINE} | ||||
.include "${MACHINE}/Makefile.inc" | |||||
rgrimes: Please put the SRCS, INCS, WARNS, LIBADD, CFLAGS back in the original order so that the diff is… | |||||
.include <bsd.lib.mk> | .include <bsd.lib.mk> | ||||
Not Done Inline ActionsI think it would be fine to just use the ARCH_SUBDIR variants needed for arm, arm64, and amd64 for now. Does MACHINE_ARCH work for all of those? jhb: I think it would be fine to just use the ARCH_SUBDIR variants needed for arm, arm64, and amd64… | |||||
Done Inline ActionsAfter looking at Makefile.inc1, MACHINE_ARCH can be i386 or amd64 when MACHINE is amd64, or aarch64 when MACHINE is arm64. I'll try to use MACHINE instead. alexandru.elisei_gmail.com: After looking at Makefile.inc1, MACHINE_ARCH can be i386 or amd64 when MACHINE is amd64, or… |
Please put the SRCS, INCS, WARNS, LIBADD, CFLAGS back in the original order so that the diff is minimized and made clear as to what is or is not changing. White space and line ordering changes should almost always be done in seperate commits and doing them in a code change review increase the work load on the reviewers trying to sort out what is just noise and what is actual changes.