Page MenuHomeFreeBSD
Differential D18519 Diff 51877 devel/py-mongoengine/Makefile

Changeset View

Standalone View

View Options

devel/py-mongoengine/Makefile

# Created by: Mirko Zinn <mail@derzinn.de> # Created by: Mirko Zinn <mail@derzinn.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= mongoengine PORTNAME= mongoengine
PORTVERSION= 0.10.0 PORTVERSION= 0.16.3
CATEGORIES= devel python CATEGORIES= devel python
koobsUnsubmitted
Done
Inline Actions

I'd put this in databases too (where mongodb exists)

koobs: I'd put this in `databases` too (where mongodb exists)
dvlAuthorUnsubmitted
Done
Inline Actions

I disagree. This isn't a database. It's a tool for working with a database.

dvl: I disagree. This isn't a database. It's a tool for working with a database.
koobsUnsubmitted
Done
Inline Actions

It's for database related things, not just things that implement databases

databases/p5-*
databases/pear-*
databases/pecl-*
...
pgpool*
...
databases/php*-*
databases/py-*
databases/qt*-*
databases/rubygem-*
...
tcl-lmdb/
tcl-Mysql/
tcl-sqlite3/
...
zabbix22-libzbxpgsql/
zabbix3-libzbxpgsql/
zabbix32-libzbxpgsql/
zabbix34-libzbxpgsql

koobs: It's for database related things, not just things that implement databases databases/p5-*…
dvlAuthorUnsubmitted
Done
Inline Actions

Conceded.

I will:

  • svn mv devel/py-mongoengine databases/py-mongoengine
  • update MOVED
  • update RUN_DEPENDS in devel/py-django-tastypie-mongoengine to refer to new location
dvl: Conceded. I will: * svn mv devel/py-mongoengine databases/py-mongoengine * update MOVED *…
MASTER_SITES= CHEESESHOP MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= wg@FreeBSD.org MAINTAINER= wg@FreeBSD.org
COMMENT= Object-Document-Mapper for working with MongoDB COMMENT= Object-Document-Mapper for working with MongoDB
LICENSE= MIT LICENSE= MIT
koobsUnsubmitted
Done
Inline Actions

Add LICENSE_FILE when a license is included in the distribution file.

This Python package includes one in its PyPI source distribution (sdist): LICENSE

koobs: Add `LICENSE_FILE` when a license is included in the distribution file. This Python package…
matUnsubmitted
Done
Inline Actions

I doubt very much this actually builds.

mat: I doubt very much this actually builds.
dvlAuthorUnsubmitted
Done
Inline Actions

For what it's worth, everything goes through a 'poudriere testport' before I submit it. I'll be working on this later today and will verify this for you.

dvl: For what it's worth, everything goes through a 'poudriere testport' before I submit it. I'll…
dvlAuthorUnsubmitted
Done
Inline Actions

One should rarely doubt mat

[dvl@dvl:~/FreeBSDPortsWorkingDirectory/databases/py-mongoengine] $ make patch
===>  Missing license file for MIT in LICENSE
*** Error code 1

This corrected that:

LICENSE_FILE=   ${WRKSRC}/LICENSE
dvl: One should rarely doubt mat ``` [dvl@dvl:~/FreeBSDPortsWorkingDirectory/databases/py…
BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}nose>0:devel/py-nose@${PY_FLAVOR} \ BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}nose>0:devel/py-nose@${PY_FLAVOR} \
${PYTHON_PKGNAMEPREFIX}rednose>0:devel/py-rednose@${PY_FLAVOR} ${PYTHON_PKGNAMEPREFIX}rednose>0:devel/py-rednose@${PY_FLAVOR}
koobsUnsubmitted
Done
Inline Actions

These are TEST_DEPENDS not (or no longer) BUILD_DEPENDS [1].

This block can be removed, or replaced with TEST_DEPENDS. Note: rednose is not (or no longer a test dependency either).

[1] setup.py:install_requires=['pymongo>=2.7.1', 'six'],

koobs: These are TEST_DEPENDS not (or no longer) BUILD_DEPENDS [1]. This block can be removed, or…
RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pymongo>=2.7:databases/pymongo@${PY_FLAVOR} RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pymongo>=2.7:databases/pymongo@${PY_FLAVOR}
koobsUnsubmitted
Done
Inline Actions
  • Minimum version is 2.7.1 [1]
  • Missing a RUN_DEPENDS on six (>0) [1]

[1] install_requires=['pymongo>=2.7.1', 'six'],

koobs: * Minimum version is 2.7.1 [1] * Missing a RUN_DEPENDS on six (>0) [1] [1] install_requires=…
koobsUnsubmitted
Done
Inline Actions

Add TEST_DEPENDS and (do-)test target if a Python package includes tests and supports running them. This gives you super/extra confidence, and an extra step, in QA.

This Python package includes test dependency specifications [1] and test target support [2]

[1] 'tests_require': ['nose', 'coverage==4.2', 'blinker', 'Pillow>=2.0.0'] ( + dateutil if python 2) - Note: coverage can likely be skipped
[2] test_suite='nose.collector',

Something like the following should suffice:

do-test:
   cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
koobs: Add TEST_DEPENDS and (do-)test target if a Python package includes tests and supports running…
dvlAuthorUnsubmitted
Done
Inline Actions

How does poudriere handle the do-test?

Do I run: make do-test in the port directory?

dvl: How does poudriere handle the do-test? Do I run: make do-test in the port directory?
koobsUnsubmitted
Done
Inline Actions

It doesn't (yet): https://github.com/freebsd/poudriere/pull/355

Close, make test to run the target. See Also TEST_* variables in Mk/bsd.port.mk

koobs: It doesn't (yet): https://github.com/freebsd/poudriere/pull/355 Close, `make test` to run the…
koobsUnsubmitted
Done
Inline Actions
  • Collapse into a single TEST_DEPENDS with \ entry line terminators
  • dateutil is a Python 2 only TEST_DEPENDS. Use a if PYTHON_VER < 3 block to add it conditionally
  • The nose dependency is duplicated, remove one
  • TEST_DEPENDS goes (alphabetically) after RUN_DEPENDS
koobs: * Collapse into a single TEST_DEPENDS with \ entry line terminators * `dateutil` is a Python…
USES= python USES= python
koobsUnsubmitted
Done
Inline Actions

Pillow is a TEST_DEPENDS (setup.py:tests_require)

koobs: Pillow is a TEST_DEPENDS (setup.py:tests_require)
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters…
USE_PYTHON= autoplist distutils USE_PYTHON= autoplist distutils
koobsUnsubmitted
Done
Inline Actions

Collapse into a single RUN_DEPENDS with \ entry line terminators

koobs: Collapse into a single RUN_DEPENDS with \ entry line terminators
# bson is provided by pymongo # bson is provided by pymongo
post-patch: post-patch:
@${RM} -r ${WRKSRC}/bson @${RM} -r ${WRKSRC}/bson
.include <bsd.port.mk> .include <bsd.port.mk>