Changeset View
Changeset View
Standalone View
Standalone View
sys/compat/linuxkpi/common/include/linux/fs.h
| Show First 20 Lines • Show All 313 Lines • ▼ Show 20 Lines | #define shmem_read_mapping_page_gfp(...) \ | ||||
| linux_shmem_read_mapping_page_gfp(__VA_ARGS__) | linux_shmem_read_mapping_page_gfp(__VA_ARGS__) | ||||
| #define shmem_file_setup(...) \ | #define shmem_file_setup(...) \ | ||||
| linux_shmem_file_setup(__VA_ARGS__) | linux_shmem_file_setup(__VA_ARGS__) | ||||
| #define shmem_truncate_range(...) \ | #define shmem_truncate_range(...) \ | ||||
| linux_shmem_truncate_range(__VA_ARGS__) | linux_shmem_truncate_range(__VA_ARGS__) | ||||
| static inline int | |||||
| simple_open(struct inode *inode, struct file *file) | |||||
| { | |||||
| // BSDFIXME: Is it OK to do same as Linux here?? | |||||
hselasky: Please don't use C99 comments. use /* */ instead or remove this comment.
From what I know… | |||||
| if (inode->i_private) | |||||
| file->private_data = inode->i_private; | |||||
| return 0; | |||||
| } | |||||
| #endif /* _LINUX_FS_H_ */ | #endif /* _LINUX_FS_H_ */ | ||||
Please don't use C99 comments. use /* */ instead or remove this comment.
From what I know i_private maps to v_data, but I doubt anyone is setting that, especially for open. You could check who is using it. Keeping the code as is doesn't harm. Try to use BSD style: return (0);