Changeset View
Changeset View
Standalone View
Standalone View
devel/geany-plugin-markdown/Makefile
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= geany-plugin-markdown | PORTNAME= geany-plugin-markdown | ||||
| PORTVERSION= ${GEANY_VER} | PORTVERSION= ${GEANY_VER} | ||||
| CATEGORIES= devel | CATEGORIES= devel | ||||
| MAINTAINER= madpilot@FreeBSD.org | MAINTAINER= madpilot@FreeBSD.org | ||||
| COMMENT= Geany plugin: ${${GEANY_PLUGIN}_DESC} | COMMENT= Geany plugin: ${${GEANY_PLUGIN}_DESC} | ||||
| LIB_DEPENDS= libwebkitgtk-1.0.so:www/webkit-gtk2 \ | LIB_DEPENDS= libsoup-2.4.so:devel/libsoup | ||||
| libsoup-2.4.so:devel/libsoup | |||||
| OPTIONS_DEFINE= DOCS | OPTIONS_DEFINE= DOCS | ||||
mat: Why `+=`? (Also, there should probably be a blank lines between the depends section and the… | |||||
Done Inline ActionsWas += because gtk[23]_LIB_DEPENDS is already populated in Makefile.common included below. Now that it's sorted back the += needs to be moved there really. Thanks for noticing! madpilot: Was += because gtk[23]_LIB_DEPENDS is already populated in Makefile.common included below. Now… | |||||
| .include "${.CURDIR}/../geany-plugins/files/Makefile.common" | .include "${.CURDIR}/../geany-plugins/files/Makefile.common" | ||||
| .if ${FLAVOR} == gtk2 | |||||
| LIB_DEPENDS+= libwebkitgtk-1.0.so:www/webkit-gtk2 | |||||
| .elif ${FLAVOR} == gtk3 | |||||
Not Done Inline ActionsWrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters… | |||||
Done Inline ActionsWrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters… | |||||
| LIB_DEPENDS+= libwebkitgtk-3.0.so:www/webkit-gtk3 | |||||
| .endif | |||||
Done Inline ActionsPlease use flavors helpers. mat: Please use flavors helpers. | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
Why +=? (Also, there should probably be a blank lines between the depends section and the flavors section.)