Page MenuHomeFreeBSD
Differential D3031 Diff 7363 sys/arm64/cavium/thunder_pcie.c

Changeset View

Standalone View

View Options

sys/arm64/cavium/thunder_pcie.c

  • This file was added.
/*-
* Copyright (c) 2015 The FreeBSD Foundation
* All rights reserved.
andrewUnsubmitted
Done
Inline Actions

Just 2014?

andrew: Just 2014?
*
* This software was developed by Semihalf under
* the sponsorship of the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
/* PCIe root complex driver for Cavium Thunder SOC */
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/systm.h>
#include <sys/malloc.h>
#include <sys/kernel.h>
#include <sys/rman.h>
#include <sys/module.h>
#include <sys/bus.h>
#include <sys/endian.h>
#include <sys/cpuset.h>
#include <dev/ofw/openfirm.h>
#include <dev/ofw/ofw_bus.h>
#include <dev/ofw/ofw_bus_subr.h>
#include <dev/pci/pcivar.h>
#include <dev/pci/pcireg.h>
#include <dev/pci/pcib_private.h>
#include <machine/cpu.h>
#include <machine/bus.h>
#include <machine/intr.h>
#include <dev/fdt/fdt_common.h>
#include "pcib_if.h"
/* Assembling ECAM Configuration Address */
#define PCIE_BUS_SHIFT 20
#define PCIE_SLOT_SHIFT 15
#define PCIE_FUNC_SHIFT 12
#define PCIE_BUS_MASK 0xFF
#define PCIE_SLOT_MASK 0x1F
#define PCIE_FUNC_MASK 0x07
#define PCIE_REG_MASK 0xFFF
#define PCIE_ADDR_OFFSET(bus, slot, func, reg) \
((((bus) & PCIE_BUS_MASK) << PCIE_BUS_SHIFT) | \
(((slot) & PCIE_SLOT_MASK) << PCIE_SLOT_SHIFT) | \
(((func) & PCIE_FUNC_MASK) << PCIE_FUNC_SHIFT) | \
((reg) & PCIE_REG_MASK))
#define MAX_RANGES_TUPLES 5
#define MIN_RANGES_TUPLES 2
#define THUNDER_ECAM0_CFG_BASE 0x848000000000UL
#define THUNDER_ECAM1_CFG_BASE 0x849000000000UL
#define THUNDER_ECAM2_CFG_BASE 0x84a000000000UL
#define THUNDER_ECAM3_CFG_BASE 0x84b000000000UL
#define THUNDER_ECAM4_CFG_BASE 0x948000000000UL
#define THUNDER_ECAM5_CFG_BASE 0x949000000000UL
#define THUNDER_ECAM6_CFG_BASE 0x94a000000000UL
#define THUNDER_ECAM7_CFG_BASE 0x94b000000000UL
#define SPACE_CODE_SHIFT 24
#define SPACE_CODE_MASK 0x3
#define SPACE_CODE_IO_SPACE 0x1
#define PROPS_CELL_SIZE 1
#define PCI_ADDR_CELL_SIZE 2
struct pcie_range {
uint64_t pci_base;
uint64_t phys_base;
uint64_t size;
};
struct thunder_pcie_softc {
struct pcie_range ranges[MAX_RANGES_TUPLES];
struct rman mem_rman;
struct resource *res;
int ecam;
device_t dev;
};
/* Forward prototypes */
static uint64_t range_addr_pci_to_phys(struct thunder_pcie_softc *, uint64_t);
static int thunder_pcie_alloc_msi(device_t, device_t, int, int, int *);
static int thunder_pcie_alloc_msix(device_t, device_t, int *);
static struct resource *thunder_pcie_alloc_resource(device_t,
device_t, int, int *, u_long, u_long, u_long, u_int);
static int thunder_pcie_attach(device_t);
static int thunder_pcie_identify_pcib(device_t);
static int thunder_pcie_map_msi(device_t, device_t, int, uint64_t *, uint32_t *);
static int thunder_pcie_maxslots(device_t);
static int parse_pci_mem_ranges(struct thunder_pcie_softc *);
static int thunder_pcie_probe(device_t);
static uint32_t thunder_pcie_read_config(device_t, u_int, u_int, u_int, u_int,
int);
static int thunder_pcie_read_ivar(device_t, device_t, int, uintptr_t *);
static int thunder_pcie_release_msi(device_t, device_t, int, int *);
static int thunder_pcie_release_msix(device_t, device_t, int);
andrewUnsubmitted
Done
Inline Actions

A comment explaining what these are for would be useful.

andrew: A comment explaining what these are for would be useful.
static int thunder_pcie_release_resource(device_t, device_t, int, int,
struct resource *);
static void thunder_pcie_write_config(device_t, u_int, u_int,
u_int, u_int, uint32_t, int);
static int thunder_pcie_write_ivar(device_t, device_t, int, uintptr_t);
static int
andrewUnsubmitted
Done
Inline Actions

And these

andrew: And these
thunder_pcie_probe(device_t dev)
{
if (!ofw_bus_status_okay(dev))
return (ENXIO);
if (ofw_bus_is_compatible(dev, "cavium,thunder-pcie")) {
device_set_desc(dev, "Cavium Integrated PCI/PCI-E Controller");
return (BUS_PROBE_DEFAULT);
}
return (ENXIO);
}
static int
thunder_pcie_attach(device_t dev)
{
int rid;
struct thunder_pcie_softc *sc;
int error;
int tuple;
uint64_t base, size;
sc = device_get_softc(dev);
sc->dev = dev;
/* Identify pcib domain */
if (thunder_pcie_identify_pcib(dev))
return (ENXIO);
rid = 0;
sc->res = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &rid, RF_ACTIVE);
if (sc->res == NULL) {
device_printf(dev, "could not map memory.\n");
return (ENXIO);
}
sc->mem_rman.rm_type = RMAN_ARRAY;
sc->mem_rman.rm_descr = "PCIe Memory";
/* Retrieve 'ranges' property from FDT */
if (bootverbose) {
device_printf(dev, "parsing FDT for ECAM%d:\n",
sc->ecam);
}
if (parse_pci_mem_ranges(sc))
return (ENXIO);
/* Initialize rman and allocate memory regions */
error = rman_init(&sc->mem_rman);
if (error) {
device_printf(dev, "rman_init() failed. error = %d\n", error);
return (error);
}
for (tuple = 0; tuple < MAX_RANGES_TUPLES; tuple++) {
base = sc->ranges[tuple].phys_base;
size = sc->ranges[tuple].size;
if (base == 0 || size == 0)
continue; /* empty range element */
error = rman_manage_region(&sc->mem_rman, base, base + size - 1);
andrewUnsubmitted
Done
Inline Actions

What are these for?

andrew: What are these for?
if (error) {
device_printf(dev, "rman_manage_region() failed. error = %d\n", error);
rman_fini(&sc->mem_rman);
return (error);
}
}
device_add_child(dev, "pci", -1);
return (bus_generic_attach(dev));
}
static uint64_t
range_addr_pci_to_phys(struct thunder_pcie_softc *sc, uint64_t pci_addr)
{
struct pcie_range *r;
uint64_t offset;
int tuple;
/* Find physical address corresponding to given bus address */
for (tuple = 0; tuple < MAX_RANGES_TUPLES; tuple++) {
r = &sc->ranges[tuple];
if (pci_addr >= r->pci_base &&
pci_addr < (r->pci_base + r->size)) {
/* Given pci addr is in this range.
* Translate bus addr to phys addr.
*/
offset = pci_addr - r->pci_base;
return (r->phys_base + offset);
}
}
return (0);
}
static int
parse_pci_mem_ranges(struct thunder_pcie_softc *sc)
{
phandle_t node;
pcell_t pci_addr_cells, parent_addr_cells, size_cells;
pcell_t attributes;
pcell_t *ranges_buf, *cell_ptr;
int cells_count, tuples_count;
andrewUnsubmitted
Done
Inline Actions

Why do you need to use fdtbus_bs_tag here? It should only be used directly in the early boot code.

andrew: Why do you need to use `fdtbus_bs_tag` here? It should only be used directly in the early boot…
int tuple;
int rv;
node = ofw_bus_get_node(sc->dev);
if (fdt_addrsize_cells(node, &pci_addr_cells, &size_cells))
return (ENXIO);
parent_addr_cells = fdt_parent_addr_cells(node);
if (parent_addr_cells != 2 || pci_addr_cells != 3 || size_cells != 2) {
device_printf(sc->dev,
"Unexpected number of address or size cells in FDT\n");
return (ENXIO);
}
cells_count = OF_getprop_alloc(node, "ranges",
sizeof(pcell_t), (void **)&ranges_buf);
if (cells_count == -1) {
device_printf(sc->dev, "Error parsing FDT 'ranges' property\n");
return (ENXIO);
}
tuples_count = cells_count /
(pci_addr_cells + parent_addr_cells + size_cells);
if (tuples_count > MAX_RANGES_TUPLES || tuples_count < MIN_RANGES_TUPLES) {
device_printf(sc->dev,
"Unexpected number of 'ranges' tuples in FDT\n");
rv = ENXIO;
goto out;
}
cell_ptr = ranges_buf;
andrewUnsubmitted
Done
Inline Actions

Why is the I/O space ignored?

andrew: Why is the I/O space ignored?
wma_semihalf.comAuthorUnsubmitted
Done
Inline Actions

It's not supported by internal PCIe controller. Will add a comment.

wma_semihalf.com: It's not supported by internal PCIe controller. Will add a comment.
for (tuple = 0; tuple < tuples_count; tuple++) {
attributes = fdt_data_get((void *)cell_ptr, PROPS_CELL_SIZE);
attributes = (attributes >> SPACE_CODE_SHIFT) & SPACE_CODE_MASK;
if (attributes == SPACE_CODE_IO_SPACE) {
/* Ignore I/O space range, mark as empty */
sc->ranges[tuple].phys_base = 0;
sc->ranges[tuple].size = 0;
cell_ptr +=
(pci_addr_cells + parent_addr_cells + size_cells);
continue;
}
cell_ptr += PROPS_CELL_SIZE; /* move ptr to pci addr */
sc->ranges[tuple].pci_base = fdt_data_get((void *)cell_ptr, 2);
cell_ptr += PCI_ADDR_CELL_SIZE; /* move ptr to cpu addr */
sc->ranges[tuple].phys_base = fdt_data_get((void *)cell_ptr, 2);
cell_ptr += parent_addr_cells; /* move ptr to size cells*/
sc->ranges[tuple].size = fdt_data_get((void *)cell_ptr, 2);
cell_ptr += size_cells; /* move ptr to next tuple*/
if (bootverbose) {
device_printf(sc->dev,
"\tPCI addr: 0x%jx, CPU addr: 0x%jx, Size: 0x%jx\n",
sc->ranges[tuple].pci_base,
sc->ranges[tuple].phys_base,
sc->ranges[tuple].size);
}
}
for (; tuple < MAX_RANGES_TUPLES; tuple++) {
/* zero-fill remaining tuples to mark empty elements in array */
sc->ranges[tuple].phys_base = 0;
sc->ranges[tuple].size = 0;
}
rv = 0;
out:
free(ranges_buf, M_OFWPROP);
return (rv);
}
static uint32_t
thunder_pcie_read_config(device_t dev, u_int bus, u_int slot,
u_int func, u_int reg, int bytes)
{
uint64_t offset;
uint32_t data;
struct thunder_pcie_softc *sc;
andrewUnsubmitted
Not Done
Inline Actions

Should this be a KASSERT?

andrew: Should this be a `KASSERT`?
wma_semihalf.comAuthorUnsubmitted
Not Done
Inline Actions

No, because KASSERTs can be disabled. These values are used to calculate an offset in #315 and I don't want to allow any access exceed ECAM space. That could corrupt PCIe registers and stay unnoticed for a long time.

wma_semihalf.com: No, because KASSERTs can be disabled. These values are used to calculate an offset in #315 and…
emasteUnsubmitted
Not Done
Inline Actions

I'd be a little worried that returning here might also mask a problem and thus leave it unnoticed.

emaste: I'd be a little worried that returning here might also mask a problem and thus leave it…
wma_semihalf.comAuthorUnsubmitted
Not Done
Inline Actions

I'll add device_printf here and below. I guess it will be the best compromise. The PCI spec tells to return 0xff...ff whenever the request is invalid so we be in-sync with it, and the user still could notice that something is not right.

wma_semihalf.com: I'll add device_printf here and below. I guess it will be the best compromise. The PCI spec…
jhbUnsubmitted
Done
Inline Actions

The x86 code has returned -1 for this condition for a long time without a printf. I think this is fine as-is.

(See sys/amd64/pci/pci_cfgreg.c pcireg_cfgread() and pciereg_cfgread())

jhb: The x86 code has returned -1 for this condition for a long time without a printf. I think this…
bus_space_tag_t t;
bus_space_handle_t h;
if ((bus > PCI_BUSMAX) || (slot > PCI_SLOTMAX) ||
(func > PCI_FUNCMAX) || (reg > PCIE_REGMAX))
return (~0U);
sc = device_get_softc(dev);
offset = PCIE_ADDR_OFFSET(bus, slot, func, reg);
t = rman_get_bustag(sc->res);
h = rman_get_bushandle(sc->res);
switch (bytes) {
case 1:
andrewUnsubmitted
Done
Inline Actions

What is this magic number?

andrew: What is this magic number?
data = bus_space_read_1(t, h, offset);
break;
case 2:
data = le16toh(bus_space_read_2(t, h, offset));
break;
case 4:
data = le32toh(bus_space_read_4(t, h, offset));
break;
default:
return (~0U);
}
return (data);
andrewUnsubmitted
Done
Inline Actions

Why 0x3?

andrew: Why 0x3?
}
static void
thunder_pcie_write_config(device_t dev, u_int bus, u_int slot,
andrewUnsubmitted
Done
Inline Actions

Magic 32?

andrew: Magic 32?
u_int func, u_int reg, uint32_t val, int bytes)
{
uint64_t offset;
struct thunder_pcie_softc *sc;
andrewUnsubmitted
Not Done
Inline Actions

KASSERT?

andrew: `KASSERT`?
bus_space_tag_t t;
bus_space_handle_t h;
if ((bus > PCI_BUSMAX) || (slot > PCI_SLOTMAX) ||
(func > PCI_FUNCMAX) || (reg > PCIE_REGMAX))
return ;
sc = device_get_softc(dev);
andrewUnsubmitted
Done
Inline Actions

0x3?

andrew: 0x3?
offset = PCIE_ADDR_OFFSET(bus, slot, func, reg);
t = rman_get_bustag(sc->res);
h = rman_get_bushandle(sc->res);
switch (bytes) {
case 1:
bus_space_write_1(t, h, offset, val);
break;
andrewUnsubmitted
Done
Inline Actions

Why a delay of 1000?

andrew: Why a delay of 1000?
case 2:
bus_space_write_2(t, h, offset, htole16(val));
break;
andrewUnsubmitted
Done
Inline Actions

Should be (regval & PEM_LINK_LT) != 0

andrew: Should be `(regval & PEM_LINK_LT) != 0`
case 4:
bus_space_write_4(t, h, offset, htole32(val));
break;
default:
return;
}
}
static int
thunder_pcie_maxslots(device_t dev)
{
/* max slots per bus acc. to standard */
return (PCI_SLOTMAX);
}
static int
thunder_pcie_read_ivar(device_t dev, device_t child, int index,
uintptr_t *result)
{
struct thunder_pcie_softc *sc;
sc = device_get_softc(dev);
if (index == PCIB_IVAR_BUS) {
/* this pcib is always on bus 0 */
*result = 0;
return (0);
}
if (index == PCIB_IVAR_DOMAIN) {
*result = sc->ecam;
return (0);
}
return (ENOENT);
}
static int
thunder_pcie_write_ivar(device_t dev, device_t child, int index,
uintptr_t value)
{
andrewUnsubmitted
Done
Inline Actions

Why not the following, but with a comment on why 3 is magic?

sli = sc->pem / 3;
sli_group = sc->pem % 3;
if (sli > 1)
  return (ENXIO);
andrew: Why not the following, but with a comment on why 3 is magic? sli = sc->pem / 3; sli_group…
return (ENOENT);
}
static int
thunder_pcie_release_resource(device_t dev, device_t child, int type, int rid,
struct resource *res)
{
if (type != SYS_RES_MEMORY)
return (BUS_RELEASE_RESOURCE(device_get_parent(dev), child,
type, rid, res));
return (rman_release_resource(res));
}
andrewUnsubmitted
Done
Inline Actions

What is a PEM number?

andrew: What is a PEM number?
static struct resource *
thunder_pcie_alloc_resource(device_t dev, device_t child, int type, int *rid,
andrewUnsubmitted
Done
Inline Actions

Magic numbers

andrew: Magic numbers
u_long start, u_long end, u_long count, u_int flags)
{
struct thunder_pcie_softc *sc = device_get_softc(dev);
struct rman *rm = NULL;
andrewUnsubmitted
Done
Inline Actions

retval != 0

andrew: `retval != 0`
struct resource *res;
switch (type) {
case SYS_RES_IOPORT:
goto fail;
break;
case SYS_RES_MEMORY:
rm = &sc->mem_rman;
break;
default:
return (BUS_ALLOC_RESOURCE(device_get_parent(dev), dev,
type, rid, start, end, count, flags));
};
if ((start == 0UL) && (end == ~0UL)) {
device_printf(dev,
"Cannot allocate resource with unspecified range\n");
goto fail;
}
/* Check if address translation is needed */
if (!(start & 0xF00000000000UL)) {
start = range_addr_pci_to_phys(sc, start);
end = start + count - 1;
/* Check if address translation was successful */
if (start == 0)
goto fail;
}
if (bootverbose) {
device_printf(dev,
"rman_reserve_resource: start=%#lx, end=%#lx, count=%#lx\n",
jhbUnsubmitted
Not Done
Inline Actions

Please do not set bustag/handle in bus_alloc_resource() routines, but do it in a bus_activate_resource() method for this driver instead.

jhb: Please do not set bustag/handle in bus_alloc_resource() routines, but do it in a…
start, end, count);
wma_semihalf.comAuthorUnsubmitted
Not Done
Inline Actions

Removed it completely, since these values are being setup by parent nexus_activate_resource.

wma_semihalf.com: Removed it completely, since these values are being setup by parent nexus_activate_resource.
}
res = rman_reserve_resource(rm, start, end, count, flags, child);
if (res == NULL)
goto fail;
rman_set_rid(res, *rid);
rman_set_bustag(res, rman_get_bustag(sc->res));
rman_set_bushandle(res, start);
if (flags & RF_ACTIVE)
if (bus_activate_resource(child, type, *rid, res)) {
rman_release_resource(res);
goto fail;
}
return (res);
fail:
if (bootverbose) {
device_printf(dev, "%s FAIL: type=%d, rid=%d, "
"start=%016lx, end=%016lx, count=%016lx, flags=%x\n",
__func__, type, *rid, start, end, count, flags);
}
return (NULL);
}
static int
thunder_pcie_identify_pcib(device_t dev)
{
struct thunder_pcie_softc *sc;
u_long start;
sc = device_get_softc(dev);
start = bus_get_resource_start(dev, SYS_RES_MEMORY, 0);
switch(start) {
case THUNDER_ECAM0_CFG_BASE:
sc->ecam = 0;
break;
case THUNDER_ECAM1_CFG_BASE:
sc->ecam = 1;
break;
case THUNDER_ECAM2_CFG_BASE:
sc->ecam = 2;
break;
case THUNDER_ECAM3_CFG_BASE:
sc->ecam = 3;
break;
andrewUnsubmitted
Done
Inline Actions

Should be:

/*
 * This ...
andrew: Should be: /* * This ...
case THUNDER_ECAM4_CFG_BASE:
sc->ecam = 4;
break;
case THUNDER_ECAM5_CFG_BASE:
sc->ecam = 5;
break;
case THUNDER_ECAM6_CFG_BASE:
sc->ecam = 6;
break;
case THUNDER_ECAM7_CFG_BASE:
sc->ecam = 7;
break;
default:
device_printf(dev,
"error: incorrect resource address=%#lx.\n", start);
return (ENXIO);
}
return (0);
}
static int
thunder_pcie_map_msi(device_t pcib, device_t child, int irq,
uint64_t *addr, uint32_t *data)
{
int error;
error = arm_map_msix(child, irq, addr, data);
return (error);
}
static int
thunder_pcie_alloc_msix(device_t pcib, device_t child, int *irq)
{
int error;
error = arm_alloc_msix(child, irq);
return (error);
}
static int
thunder_pcie_release_msix(device_t pcib, device_t child, int irq)
{
int error;
error = arm_release_msix(child, irq);
return (error);
}
static int
thunder_pcie_alloc_msi(device_t pcib, device_t child, int count, int maxcount,
int *irqs)
{
int error;
error = arm_alloc_msi(child, count, irqs);
return (error);
}
static int
thunder_pcie_release_msi(device_t pcib, device_t child, int count, int *irqs)
{
int error;
error = arm_release_msi(child, count, irqs);
return (error);
}
static device_method_t thunder_pcie_methods[] = {
DEVMETHOD(device_probe, thunder_pcie_probe),
DEVMETHOD(device_attach, thunder_pcie_attach),
DEVMETHOD(pcib_maxslots, thunder_pcie_maxslots),
DEVMETHOD(pcib_read_config, thunder_pcie_read_config),
DEVMETHOD(pcib_write_config, thunder_pcie_write_config),
DEVMETHOD(bus_read_ivar, thunder_pcie_read_ivar),
DEVMETHOD(bus_write_ivar, thunder_pcie_write_ivar),
DEVMETHOD(bus_alloc_resource, thunder_pcie_alloc_resource),
DEVMETHOD(bus_release_resource, thunder_pcie_release_resource),
DEVMETHOD(bus_activate_resource, bus_generic_activate_resource),
DEVMETHOD(bus_deactivate_resource, bus_generic_deactivate_resource),
DEVMETHOD(bus_setup_intr, bus_generic_setup_intr),
DEVMETHOD(bus_teardown_intr, bus_generic_teardown_intr),
DEVMETHOD(pcib_map_msi, thunder_pcie_map_msi),
DEVMETHOD(pcib_alloc_msix, thunder_pcie_alloc_msix),
DEVMETHOD(pcib_release_msix, thunder_pcie_release_msix),
DEVMETHOD(pcib_alloc_msi, thunder_pcie_alloc_msi),
DEVMETHOD(pcib_release_msi, thunder_pcie_release_msi),
DEVMETHOD_END
};
static driver_t thunder_pcie_driver = {
"pcib",
thunder_pcie_methods,
sizeof(struct thunder_pcie_softc),
};
static devclass_t thunder_pcie_devclass;
DRIVER_MODULE(thunder_pcib, simplebus, thunder_pcie_driver,
thunder_pcie_devclass, 0, 0);
DRIVER_MODULE(thunder_pcib, ofwbus, thunder_pcie_driver,
thunder_pcie_devclass, 0, 0);
andrewUnsubmitted
Done
Inline Actions

Magic

andrew: Magic
andrewUnsubmitted
Done
Inline Actions

Magic

andrew: Magic
andrewUnsubmitted
Done
Inline Actions

Magic

andrew: Magic
andrewUnsubmitted
Done
Inline Actions

Why does this address need to be translated?

andrew: Why does this address need to be translated?
andrewUnsubmitted
Done
Inline Actions

It feels like you could extract the ecam value from the data.

andrew: It feels like you could extract the ecam value from the data.
andrewUnsubmitted
Done
Inline Actions

Magic

andrew: Magic