Changeset View
Changeset View
Standalone View
Standalone View
net-mgmt/rubygem-riemann-client/files/patch-riemann-client.gemspec
- This file was added.
--- riemann-client.gemspec.orig 2018-10-26 00:25:08 UTC | |||||
+++ riemann-client.gemspec | |||||
@@ -25,20 +25,20 @@ Gem::Specification.new do |s| | |||||
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then | |||||
s.add_development_dependency(%q<bundler>.freeze, [">= 1.3"]) | |||||
s.add_development_dependency(%q<bacon>.freeze, [">= 0"]) | |||||
- s.add_runtime_dependency(%q<beefcake>.freeze, ["<= 1.0.0", ">= 0.3.5"]) | |||||
+ s.add_runtime_dependency(%q<beefcake>.freeze, [">= 1.2.0"]) | |||||
s.add_runtime_dependency(%q<trollop>.freeze, [">= 1.16.2"]) | |||||
romain: Ah yes… I started looking into this and stopped when I had to tweak the gemspec (for my testing… | |||||
Done Inline ActionsLooks like the tests have been broken for a while, I submitted a fix upstream: https://github.com/riemann/riemann-ruby-client/pull/29 dch: Looks like the tests have been broken for a while, I submitted a fix upstream: https://github. | |||||
s.add_runtime_dependency(%q<mtrc>.freeze, [">= 0.0.4"]) | |||||
else | |||||
s.add_dependency(%q<bundler>.freeze, [">= 1.3"]) | |||||
s.add_dependency(%q<bacon>.freeze, [">= 0"]) | |||||
- s.add_dependency(%q<beefcake>.freeze, ["<= 1.0.0", ">= 0.3.5"]) | |||||
+ s.add_dependency(%q<beefcake>.freeze, [">= 1.2.0"]) | |||||
s.add_dependency(%q<trollop>.freeze, [">= 1.16.2"]) | |||||
s.add_dependency(%q<mtrc>.freeze, [">= 0.0.4"]) | |||||
end | |||||
else | |||||
s.add_dependency(%q<bundler>.freeze, [">= 1.3"]) | |||||
s.add_dependency(%q<bacon>.freeze, [">= 0"]) | |||||
- s.add_dependency(%q<beefcake>.freeze, ["<= 1.0.0", ">= 0.3.5"]) | |||||
+ s.add_dependency(%q<beefcake>.freeze, [">= 1.2.0"]) | |||||
s.add_dependency(%q<trollop>.freeze, [">= 1.16.2"]) | |||||
s.add_dependency(%q<mtrc>.freeze, [">= 0.0.4"]) | |||||
end |
Ah yes… I started looking into this and stopped when I had to tweak the gemspec (for my testing purpose, creating a Gemfile and pulling-in the required gem as a regular user was okay).
I still think adding this to the ports tree makes some sense. This change can probably be upstreamed, but the impact would have to be known (I guess 1.0.0 introduced regressions that might have been fixed in 1.0.1 or 1.1.0 or whatever version we should put here), and the commit that adds the <= 1.0.0 does not provide any details about why:
https://github.com/riemann/riemann-ruby-client/commit/a9d38b4743ce237dd05e4c0266130de69dfeaa91