Differential D17947 Diff 50287 release/amd64/make-memstick.sh

Changeset View

Standalone View

release/amd64/make-memstick.sh

Context not available.
	rm ${1}/etc/fstab	rm ${1}/etc/fstab
	rm ${1}/etc/rc.conf.local	rm ${1}/etc/rc.conf.local


		dd if=/dev/zero of=efiboot.img bs=1k count=33292
		rpokalaUnsubmitted Done Inline Actions A comment for the magic `count` value would be appreciated. rpokala: A comment for the magic `count` value would be appreciated.
		device=`mdconfig -a -t vnode -f efiboot.img`
		newfs_msdos -F 32 -c 1 -L EFISYS /dev/$device
		impUnsubmitted Done Inline Actions I'm not at all sure I like this construct... How do we know what SRCTOP is? Also the typical way to drag in a library of shell functions is to do it at the top of the file... imp: I'm not at all sure I like this construct... How do we know what SRCTOP is? Also the typical…
		mkdir efi
		mount -t msdosfs /dev/$device efi
		impUnsubmitted Done Inline Actions does makefs support msdos yet? imp: does makefs support msdos yet?
		bcranAuthorUnsubmitted Done Inline Actions Not according to makefs(8). It looks like work on https://reviews.freebsd.org/D16438 stalled in September. bcran: Not according to makefs(8). It looks like work on https://reviews.freebsd.org/D16438 stalled in…
		impUnsubmitted Done Inline Actions It might make sense to use mktemp to create a better name. That would allow multiple copies of this script to be run at the same time by different users (or the same one). Both here and below (not specifically called out). imp: It might make sense to use mktemp to create a better name. That would allow multiple copies of…
		mkdir -p efi/efi/boot
		cp -p "${1}/boot/loader.efi" efi/efi/boot/bootx64.efi
		umount efi
		rmdir efi
		mdconfig -d -u $device
		impUnsubmitted Done Inline Actions You have this same code in multiple .sh files (modulo filename). Any chance you could make it a function somewhere? imp: You have this same code in multiple .sh files (modulo filename). Any chance you could make it a…

	mkimg -s mbr \	mkimg -s mbr \
	-b ${1}/boot/mbr \	-b ${1}/boot/mbr \
	-p efi:=${1}/boot/boot1.efifat \	-p efi:=efiboot.img \
	-p freebsd:-"mkimg -s bsd -b ${1}/boot/boot -p freebsd-ufs:=${2}.part" \	-p freebsd:-"mkimg -s bsd -b ${1}/boot/boot -p freebsd-ufs:=${2}.part" \
	-a 2 \	-a 2 \
	-o ${2}	-o ${2}
		rm efiboot.img
	rm ${2}.part	rm ${2}.part

Context not available.