Differential D16719 Diff 48781 sys/amd64/amd64/machdep.c

Changeset View

Standalone View

sys/amd64/amd64/machdep.c

Context not available.
	#ifdef FDT	#ifdef FDT
	#include <x86/fdt.h>	#include <x86/fdt.h>
	#endif	#endif
		#ifdef DEV_PCI
		#include <dev/pci/pci_early_quirks.h>
		#endif

	#ifdef DEV_ATPIC	#ifdef DEV_ATPIC
	#include <x86/isa/icu.h>	#include <x86/isa/icu.h>
Context not available.

	/* now running on new page tables, configured,and u/iom is accessible */	/* now running on new page tables, configured,and u/iom is accessible */

		#ifdef DEV_PCI
		/* This function might manipulate phys_avail. */
		pci_early_quirks();
		#endif

	if (late_console)	if (late_console)
	cninit();	cninit();

Context not available.
		kibUnsubmitted Not Done Inline Actions What is end ? Is it the address to reserve, or the address right after the reserve ? kib: What is end ? Is it the address to reserve, or the address right after the reserve ?
		johalun0_gmail.comAuthorUnsubmitted Not Done Inline Actions End is the address right after the reserve. Maybe having the function take base and size as arguments would make things more clear? johalun0_gmail.com: End is the address right after the reserve. Maybe having the function take base and size as…
		kibUnsubmitted Not Done Inline Actions No, it is common to take the range end as the address after the range. But then you have off by one in the check. kib: No, it is common to take the range end as the address after the range. But then you have off…
		kibUnsubmitted Not Done Inline Actions No init at the declaration location. kib: No init at the declaration location.
		kibUnsubmitted Not Done Inline Actions binary ops require spaces around the op symbol. kib: binary ops require spaces around the op symbol.
		johalun0_gmail.comAuthorUnsubmitted Not Done Inline Actions Do you mean [(i+2)] ? johalun0_gmail.com: Do you mean [(i+2)] ?
		kibUnsubmitted Not Done Inline Actions I mean spaces, not braces. phys_avail[i + 2] kib: I mean spaces, not braces. ``` phys_avail[i + 2] ```