Page MenuHomeFreeBSD
Differential D17276 Diff 48655 crypto/heimdal/lib/ntlm/heimntlm-protos.h

Changeset View

Standalone View

View Options

crypto/heimdal/lib/ntlm/heimntlm-protos.h

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Linesheim_ntlm_decode_type2 (
struct ntlm_type2 */*type2*/); struct ntlm_type2 */*type2*/);
int int
heim_ntlm_decode_type3 ( heim_ntlm_decode_type3 (
const struct ntlm_buf */*buf*/, const struct ntlm_buf */*buf*/,
int /*ucs2*/, int /*ucs2*/,
struct ntlm_type3 */*type3*/); struct ntlm_type3 */*type3*/);
void int
jhbAuthorUnsubmitted
Done
Inline Actions

I changed this function to return an int to avoid just calling abort() if malloc failed. I'm not sure how public of an API this is such that changing it to an int is ok or if we need to resort to abort() instead. This is the only function whose API I changed in this fashion.

jhb: I changed this function to return an int to avoid just calling abort() if malloc failed. I'm…
bjkUnsubmitted
Not Done
Inline Actions

it's unclear why we even install this generated file, but we do. I am not sure how much precedent we have for changing prototypes from void to int return value.

bjk: it's unclear why we even install this generated file, but we do. I am not sure how much…
heim_ntlm_derive_ntlm2_sess ( heim_ntlm_derive_ntlm2_sess (
const unsigned char sessionkey[16], const unsigned char sessionkey[16],
const unsigned char */*clnt_nonce*/, const unsigned char */*clnt_nonce*/,
size_t /*clnt_nonce_length*/, size_t /*clnt_nonce_length*/,
const unsigned char svr_chal[8], const unsigned char svr_chal[8],
unsigned char derivedkey[16]); unsigned char derivedkey[16]);
int int
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines