Differential D17282 Diff 48428 lib/libc/gen/sysctlbyname.c

Changeset View

Standalone View

lib/libc/gen/sysctlbyname.c

	/*			/*-
	* ----------------------------------------------------------------------------			* SPDX-License-Identifier: BSD-2-Clause
	* "THE BEER-WARE LICENSE" (Revision 42):
	* <phk@FreeBSD.org> wrote this file. As long as you retain this notice you
	* can do whatever you want with this stuff. If we meet some day, and you think
	* this stuff is worth it, you can buy me a beer in return. Poul-Henning Kamp
	* ----------------------------------------------------------------------------
	*			*
				* Copyright 2018 Pawel Biernacki, Mysterious Code Ltd.
				*
				* Redistribution and use in source and binary forms, with or without
				* modification, are permitted provided that the following conditions
				* are met:
				*
				* 1. Redistributions of source code must retain the above copyright
				* notice, this list of conditions and the following disclaimer.
				* 2. Redistributions in binary form must reproduce the above copyright
				* notice, this list of conditions and the following disclaimer in the
				* documentation and/or other materials provided with the distribution.
				*
				* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND ANY
				* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
				* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
				* DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
				* ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
				* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
				* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
				* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
				* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
				* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
				* SUCH DAMAGE.
	*/			*/

	#include <sys/cdefs.h>			#include <sys/cdefs.h>
	__FBSDID("$FreeBSD$");			__FBSDID("$FreeBSD$");

	#include <sys/types.h>			#include <sys/types.h>
	#include <sys/sysctl.h>			#include <sys/sysctl.h>
				#include <string.h>

				extern int __sysctlbyname(const char name, u_int namelen, void oldp,
				size_t oldlenp, const void newp, size_t newlen);

	int			int
	sysctlbyname(const char name, void oldp, size_t *oldlenp,			sysctlbyname(const char name, void oldp, size_t *oldlenp,
	const void *newp, size_t newlen)			const void *newp, size_t newlen)
	{			{
	int real_oid[CTL_MAXNAME+2];			u_int namelen;
				kibUnsubmitted Not Done Inline Actions What is the point of creating this single-use variable ? Esp. of type u_int which theoretically causes truncation ? kib: What is the point of creating this single-use variable ? Esp. of type u_int which…
	size_t oidlen;

	oidlen = sizeof(real_oid) / sizeof(int);			namelen = strlen(name);
	if (sysctlnametomib(name, real_oid, &oidlen) < 0)			return (__sysctlbyname(name, namelen, oldp, oldlenp, newp, newlen));
				mjgUnsubmitted Done Inline Actions this should be namelen to avoid namespace collision with newlen the strlen call should be done in a separate line mjg: this should be namelen to avoid namespace collision with newlen the strlen call should be done…
	return (-1);
	return (sysctl(real_oid, oidlen, oldp, oldlenp, newp, newlen));
	}			}

				kibUnsubmitted Not Done Inline Actions This is no-go outright. Library must not manipulate global process state. It is both non-thread-safe and non-async-signal-safe. If you want to handle older kernels in libc(why ?) use __FreeBSD_version. Look for examples. kib: This is no-go outright. Library must not manipulate global process state. It is both non…
				kaktusAuthorUnsubmitted Done Inline Actions I agree, it was just an idea to ease the upgrade process for those installing new libc while running older kernel, because even reboot would be killed by SIGSYS as it use sysctlbyname(3). Guarding on __FreeBSD_version wouldn't help here anyway, it'd need a runtime check on osreldate or so to find if the syscall is present. So my idea is to drop this broken-anyway-compat and add an UPDATING note, maybe post heads up on current@, or should I implement runtime check on kern.osreldate for some period of time? kaktus: I agree, it was just an idea to ease the upgrade process for those installing new libc while…
				kibUnsubmitted Not Done Inline Actions My opinion is that newer libc requires newer kernel, but some people are nicer to users. Look at lib/libc/sys/stat.c for what I mean by checks for __FreeBSD_version. kib: My opinion is that newer libc requires newer kernel, but some people are nicer to users. Look…