Changeset View
Changeset View
Standalone View
Standalone View
kerberos5/Makefile.inc
# $FreeBSD$ | # $FreeBSD$ | ||||
.include <src.opts.mk> | .include <src.opts.mk> | ||||
NO_LINT= | NO_LINT= | ||||
KRB5DIR= ${SRCTOP}/crypto/heimdal | KRB5DIR= ${SRCTOP}/crypto/heimdal | ||||
CFLAGS+= -DHAVE_CONFIG_H -I${.CURDIR:H:H}/include | CFLAGS+= -DHAVE_CONFIG_H -I${.CURDIR:H:H}/include | ||||
WARNS?= 1 | |||||
jhb: Having warnings enabled was really helpful, and I'm surprised we currently don't have them… | |||||
jhbAuthorUnsubmitted Done Inline ActionsI tried to build with TARGET_ARCH=mips to test a GCC build but that failed because only the x86 openssl-conf.h.in has been updated. jhb: I tried to build with TARGET_ARCH=mips to test a GCC build but that failed because only the x86… | |||||
jkimUnsubmitted Done Inline ActionsPlease try again. I have updated opensslconf.h for all architectures. jkim: Please try again. I have updated opensslconf.h for all architectures. | |||||
CWARNFLAGS.clang+= -Wno-error=absolute-value | |||||
jhbAuthorUnsubmitted Done Inline ActionsSeveral places in kerberos use abs() on time_t values and clang warns about passing a long when time_t is 64-bits to abs() and wants to use labs() instead. I chose not to fix those and just suppress the warnings for now to avoid noise in the diff. jhb: Several places in kerberos use abs() on time_t values and clang warns about passing a long when… | |||||
CWARNFLAGS.clang+= -Wno-error=deprecated-declarations | |||||
jhbAuthorUnsubmitted Done Inline Actionsheimdal has krb5_get_err_text() marked as deprecated, but all of the tools use it still. jhb: heimdal has krb5_get_err_text() marked as deprecated, but all of the tools use it still. | |||||
.if ${MK_OPENLDAP} != "no" && !defined(COMPAT_32BIT) | .if ${MK_OPENLDAP} != "no" && !defined(COMPAT_32BIT) | ||||
OPENLDAPBASE?= /usr/local | OPENLDAPBASE?= /usr/local | ||||
LDAPLDADD= -lldap -llber | LDAPLDADD= -lldap -llber | ||||
LDAPDPADD= ${LDAPLDADD:C;^-l(.*)$;${OPENLDAPBASE}/lib/lib\1.a;} | LDAPDPADD= ${LDAPLDADD:C;^-l(.*)$;${OPENLDAPBASE}/lib/lib\1.a;} | ||||
LDAPCFLAGS= -I${OPENLDAPBASE}/include -DOPENLDAP=1 -DLDAP_DEPRECATED=1 | LDAPCFLAGS= -I${OPENLDAPBASE}/include -DOPENLDAP=1 -DLDAP_DEPRECATED=1 | ||||
LDAPLDFLAGS= -L${OPENLDAPBASE}/lib -rpath ${OPENLDAPBASE}/lib | LDAPLDFLAGS= -L${OPENLDAPBASE}/lib -rpath ${OPENLDAPBASE}/lib | ||||
.endif | .endif | ||||
Show All 35 Lines |
Having warnings enabled was really helpful, and I'm surprised we currently don't have them enabled at all for kerberos5. I haven't yet tested a build with GCC to see if the CWARNFLAGS need to be pan-compiler rather than just for clang.