Page MenuHomeFreeBSD
Differential D17255 Diff 48305 benchmarks/linux-vdbench/Makefile

Changeset View

Standalone View

View Options

benchmarks/linux-vdbench/Makefile

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= vdbench
PORTVERSION= 5.04.07
CATEGORIES= benchmarks linux java
koobsUnsubmitted
Done
Inline Actions

It looks like the canonical version scheme upstream uses is X.Y.Z so use that as the PORTVERSION. [1]

You'll need to set DISTVERSION as well.

[1] Eg: Vdbench (5.04.07) via https://www.oracle.com/technetwork/server-storage/vdbench-downloads-1901681.html

koobs: It looks like the canonical version scheme upstream uses is //X.Y.Z// so use that as the…
MASTER_SITES= #
PKGNAMEPREFIX= linux-
DISTNAME= ${PORTNAME}${PORTVERSION:S/.//g}
MAINTAINER= loader@FreeBSD.org
COMMENT= Command line disk I/O benchmark utility
LICENSE= OTN
LICENSE_NAME= Oracle Technology Network
LICENSE_FILE= ${FILESDIR}/LICENSE
LICENSE_PERMS= none
koobsUnsubmitted
Done
Inline Actions

Prefer https URL's when they are available. This one is available under https

koobs: Prefer https URL's when they are available. This one is available under https
matUnsubmitted
Done
Inline Actions

LICENSE_TEXT is supposed to be the text of the license. So, this should either be some text saying that the license is readable there, or maybe the license should be added to the files directory which is probably a better idea.

mat: LICENSE_TEXT is supposed to be the text of the license. So, this should either be some text…
matUnsubmitted
Done
Inline Actions

also known as none.

mat: also known as `none`.
ONLY_FOR_ARCHS= amd64 i386
ONLY_FOR_ARCHS_REASON= contains Linux shared librares
koobsUnsubmitted
Done
Inline Actions

Minor nits:

  • Capitalise messages
  • Does this actually mean, and should this be Linux compatibility layer only supports i386/amd64 ?
koobs: Minor nits: * Capitalise messages * Does this actually mean, and should this be `Linux…
USES= linux shebangfix uniquefiles:dirs zip
USE_JAVA= yes
EXTRACT_AFTER_ARGS= -d ${WRKSRC}
JAVA_VERSION= 1.7+
matUnsubmitted
Done
Inline Actions

I think this is USES=uniquefiles:dirs.

mat: I think this is `USES=uniquefiles:dirs`.
JAVA_OS= linux
koobsUnsubmitted
Done
Inline Actions

Prefer https URL's when they are available. This one is available under https

koobs: Prefer https URL's when they are available. This one is available under https
NO_BUILD= yes
SHEBANG_FILES= ${PORTNAME} linux/config.sh
bash_CMD= ${SH}
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters…
matUnsubmitted
Done
Inline Actions

Remove, you are using the LICENSE framework.

mat: Remove, you are using the LICENSE framework.
OPTIONS_DEFINE= DOCS EXAMPLES
koobsUnsubmitted
Not Done
Inline Actions

LICENSE_PERMS values above already specifies this. From Porters Handbook - 5.7.2 [1]:

no-dist-mirror

Redistribution of the distribution files is prohibited. This is equivalent to setting RESTRICTED

no-dist-sell

Selling of distribution files is prohibited. This is equivalent to setting NO_CDROM.

no-pkg-mirror

Free redistribution of package is prohibited. Equivalent to setting NO_PACKAGE.

no-pkg-sell

Selling of package is prohibited. This is equivalent to setting NO_CDROM

[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#licenses

koobs: `LICENSE_PERMS` values above already specifies this. From Porters Handbook - 5.7.2 [1]: no…
loaderAuthorUnsubmitted
Not Done
Inline Actions

LEGALint compares the RESTRICTED= with the string in /usr/ports/LEGAL.

# /usr/ports/Tools/scripts/LEGALlint
... ...
211 (benchmarks/linux-vdbench): reason mismatch
... ...
loader: LEGALint compares the RESTRICTED= with the string in /usr/ports/LEGAL. ```#…
loaderAuthorUnsubmitted
Not Done
Inline Actions

Should I change RESTRICTED= to LEGAL_TEXT= ?

loader: Should I change `RESTRICTED=` to `LEGAL_TEXT=` ?
DOWNLOAD_URL= https://www.oracle.com/technetwork/server-storage/vdbench-downloads-1901681.html
.include <bsd.port.pre.mk>
koobsUnsubmitted
Done
Inline Actions

Use ${DISTFILES} here, it is the already derived/calculated distribution filename based on the above DISTNAME/etc variables and defaults to ${DISTNAME}${EXTRACT_SUFX} already (see bsd.port.mk)

koobs: Use `${DISTFILES}` here, it is the already derived/calculated distribution filename based on…
.if !exists(${DISTDIR}/${DISTFILES})
IGNORE=You must manually download ${DISTFILES} from ${DOWNLOAD_URL} and place it in ${DISTDIR} then run make again
.endif
.if ${LINUX_ARCH} == "i386"
PLIST_SUB+= LINUX_ARCH_32="" LINUX_ARCH_64="@comment "
.endif
.if ${LINUX_ARCH} == "x86_64"
PLIST_SUB+= LINUX_ARCH_32="@comment " LINUX_ARCH_64=""
.endif
post-patch:
${REINPLACE_CMD} -e 's|^java=java|java=${JAVA_HOME}/bin/java|' \
-e 's|^dir=.*|dir=${DATADIR}|' ${WRKSRC}/vdbench
${REINPLACE_CMD} -e 's|/proc/meminfo|/compat/proc/meminfo|' \
-e '/^free/d' ${WRKSRC}/linux/config.sh
koobsUnsubmitted
Done
Inline Actions

Try using USES=shebangfix and SHEBANG_* variables for this block

koobs: Try using `USES=shebangfix` and `SHEBANG_*` variables for this block
do-install:
${MKDIR} ${STAGEDIR}${DATADIR}
${MKDIR} ${STAGEDIR}${DATADIR}/linux
for f in vdbench.jar build_sds.txt swatcharts.txt; do \
${INSTALL_DATA} ${WRKSRC}/$${f} ${STAGEDIR}${DATADIR}; \
done
.if ${LINUX_ARCH} == "i386"
${INSTALL_DATA} ${WRKSRC}/linux/linux32.so ${STAGEDIR}${DATADIR}/linux
.endif
.if ${LINUX_ARCH} == "x86_64"
${INSTALL_DATA} ${WRKSRC}/linux/linux64.so ${STAGEDIR}${DATADIR}/linux
.endif
${INSTALL_SCRIPT} ${WRKSRC}/linux/config.sh ${STAGEDIR}${DATADIR}/linux
${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${DATADIR}
${RLN} ../${DATADIR_REL}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin/${PKGNAMEPREFIX}${PORTNAME}
do-install-DOCS-on:
${MKDIR} ${STAGEDIR}${DOCSDIR}
for f in vdbench.pdf readme.txt; do \
${INSTALL_DATA} ${WRKSRC}/$${f} ${STAGEDIR}${DOCSDIR}; \
done
do-install-EXAMPLES-on:
${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
(cd ${WRKSRC}; ${COPYTREE_SHARE} examples ${STAGEDIR}${EXAMPLESDIR})
matUnsubmitted
Done
Inline Actions

Use ${RLN}

mat: Use ${RLN}
for e in $$(${JOT} - 1 7); do \
${INSTALL_DATA} ${WRKSRC}/example$${e} ${STAGEDIR}${EXAMPLESDIR}; \
done
.include <bsd.port.post.mk>