Changeset View
Standalone View
www/py-bench/files/patch-setup.py
- This file was added.
| Property | Old Value | New Value |
|---|---|---|
| fbsd:nokeywords | null | yes \ No newline at end of property |
| svn:eol-style | null | native \ No newline at end of property |
| svn:mime-type | null | text/plain \ No newline at end of property |
| --- setup.py.orig 2014-11-19 06:36:44 UTC | |||||
| +++ setup.py | |||||
| @@ -3,7 +3,7 @@ from setuptools import setup, find_packa | |||||
| setup( | |||||
| name='bench', | |||||
| version='0.1', | |||||
| - py_modules=find_packages(), | |||||
| + packages=find_packages(), | |||||
koobs: Why as this needed?
If it's a bug fix, has it been submitted upstream?
If so, add patch… | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsI'm new to this, please correct me if I'm wrong. py_modules=['foo'] installs foo.py to lib/site-packages/foo.py and this port needs to install the bench/ directory. loader: I'm new to this, please correct me if I'm wrong.
py_modules=['foo'] installs foo.py to… | |||||
koobsUnsubmitted Not Done Inline ActionsI just wanted to understand the need (certainly I know packages=['foo'] is the most common way), and whether the port doesn't work or breaks other things without this patch .. If things don't work without this patch, or the package doesn't install the way, or where it is supposed to according to Python packaging rules/conventions, the upstream should be fixed, and links/references/description added to the patch. koobs: I just wanted to understand the need (certainly I know packages=['foo'] is the most common way)… | |||||
| include_package_data=True, | |||||
| url='https://github.com/frappe/bench', | |||||
| author='Web Notes Technologies Pvt. Ltd.', | |||||
| @@ -15,7 +15,7 @@ setup( | |||||
| 'requests', | |||||
| 'honcho', | |||||
| 'semantic_version', | |||||
| - 'GitPython==0.3.2.RC1' | |||||
| + 'GitPython' | |||||
koobsUnsubmitted Not Done Inline ActionsI would probably use >= in this case, rather than no version at all. Update the RUN_DEPENDS version accordingly. koobs: I would probably use >= in this case, rather than no version at all.
Update the RUN_DEPENDS… | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsOkay, I will upload a new patch when I got their reply for new port name. Thank your help. loader: Okay, I will upload a new patch when I got their reply for new port name. Thank your help. | |||||
| ], | |||||
| entry_points=''' | |||||
| [console_scripts] | |||||
Why as this needed?
If it's a bug fix, has it been submitted upstream?
If so, add patch header breadcrumbs/comments with description and link references