Changeset View
Standalone View
www/py-bench/Makefile
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
# Created by: loader <loader@FreeBSD.org> | |||||
# $FreeBSD$ | |||||
PORTNAME= bench | |||||
koobs: This doesn't appear to be the same as PyPI's //bench// package, and thus is incorrectly named… | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsSure, submitted. https://github.com/frappe/bench/issues/127 loader: Sure, submitted. https://github.com/frappe/bench/issues/127 | |||||
PORTVERSION= 0.1.s20150713 | |||||
koobsUnsubmitted Not Done Inline ActionsI would look at whether DISTVERION might be better than PORTVERSION here due to the letter in the version koobs: I would look at whether DISTVERION might be better than PORTVERSION here due to the letter in… | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsThe last release version v0.92 on GitHub needs a lot changes to work, what is the best solution for this kind of ports if I have to use the master branch? can I just the version number in setup.py + date, like PORTVERSION= 0.1.20150713? or is it possible to use the ${GH_TAGNAME} as the port version? loader: The last release version v0.92 on GitHub needs a lot changes to work, what is the best solution… | |||||
koobsUnsubmitted Not Done Inline ActionsThe only reason for suggesting DISTVERSION was because of 's' character in PORTVERSION, but I can't tell where it came from. Typo? Intentional? Regardless of the reason, using DISTVERSION for these kinds of non-numeric version strings, automatically derives a 'sane' PORTVERSION value, that is less prone to issues. Specifically, this is related to the requirement for PORTVERSION strings only to 'increase in their values, never decrease (thus requiring a PORTEPOCH bump), and the need to be able to say a version is less-than or greater-than another value, which is more difficult with alphabetic characters in version strings. See: http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#idp57382352 Key part: Some vendor's distribution names which do not fit into the ${PORTNAME}-${PORTVERSION}-scheme can be handled automatically by setting DISTVERSION. PORTVERSION will be derived from it automatically. Having said all that (above), and since looking at the upstream code, it appears that the version scheme upstream is using is currently X.YZ, and that the version value (0.1) in setup.py is just plain wrong, and needs to be fixed to match the current 'proper' version. An issue should be created for that. This brings us to the last bit, that is, "the latest 'release' version is broken or doesn't have fixes that haven't been released yet'. In this case, something like PORTVERSION.<DATESTAMP> is OK, but only if the new version that is greater-than the previous. I'm not particularly a fan of 'making up version strings', and I tend to use the following alternatives:
TLDR: Upstream needs to fix their packaging, versioning and release practices koobs: The only reason for suggesting DISTVERSION was because of 's' character in PORTVERSION, but I… | |||||
CATEGORIES= www python | |||||
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | |||||
MAINTAINER= loader@FreeBSD.org | |||||
COMMENT= Frappe / ERPNext apps setup tool | |||||
koobsUnsubmitted Not Done Inline ActionsUpstream (and setup.py) description is: Benchmark resources usage koobs: Upstream (and setup.py) description is:
//Benchmark resources usage// | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsThis is the package on PyPI :) loader: This is the package on PyPI :) | |||||
koobsUnsubmitted Not Done Inline ActionsSorry, I meant to delete this comment. *shakes fist at phabricator*. Ignore. koobs: Sorry, I meant to delete this comment. *shakes fist at phabricator*. Ignore. | |||||
LICENSE= GPLv3 | |||||
LICENSE_FILE= ${WRKSRC}/LICENSE.md | |||||
RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}click>0:${PORTSDIR}/devel/py-click \ | |||||
${PYTHON_PKGNAMEPREFIX}Jinja2>0:${PORTSDIR}/devel/py-Jinja2 \ | |||||
${PYTHON_PKGNAMEPREFIX}virtualenv>0:${PORTSDIR}/devel/py-virtualenv \ | |||||
${PYTHON_PKGNAMEPREFIX}requests>0:${PORTSDIR}/www/py-requests \ | |||||
${PYTHON_PKGNAMEPREFIX}honcho>0:${PORTSDIR}/sysutils/py-honcho \ | |||||
${PYTHON_PKGNAMEPREFIX}semantic_version>0:${PORTSDIR}/devel/py-semantic_version \ | |||||
${PYTHON_PKGNAMEPREFIX}GitPython>0:${PORTSDIR}/devel/py-gitpython \ | |||||
${PYTHON_PKGNAMEPREFIX}pip>0:${PORTSDIR}/devel/py-pip \ | |||||
git:${PORTSDIR}/devel/git | |||||
USE_GITHUB= yes | |||||
GH_ACCOUNT= frappe | |||||
GH_TAGNAME= 7a9dc9a | |||||
koobsUnsubmitted Not Done Inline ActionsIf you end up getting upstream to tag a new release, use that tag here. koobs: If you end up getting upstream to tag a new release, use that tag here. | |||||
USES= python | |||||
USE_PYTHON= autoplist distutils | |||||
koobsUnsubmitted Not Done Inline ActionsSome Python ports install setup.py:console_script's (in LOCALBASE/bin), as this one does: https://github.com/frappe/bench/blob/master/setup.py#L21 Try using USE_PYTHON=concurrent, which will ensure that installed script filenames have the correct Python version suffix for the users installed/desired version of Python. Note: Some python packages (not this one) install already version-suffixed scripts. In this case, one should stop (rm) those from being installed, and use USE_PYTHON=concurrent to do it instead. Everything else aside, the end result of a Python port installation (that supports multiple versions of Python) should always be:
koobs: Some Python ports install //setup.py:console_script//'s (in LOCALBASE/bin), as this one does… | |||||
loaderAuthorUnsubmitted Not Done Inline ActionsThanks for the tip. I will add it. loader: Thanks for the tip. I will add it. | |||||
.include <bsd.port.mk> |
This doesn't appear to be the same as PyPI's bench package, and thus is incorrectly named and conflicts:
https://pypi.python.org/pypi/bench