Page MenuHomeFreeBSD
Differential D16942 Diff 47482 net-mgmt/librenms/Makefile

Changeset View

Standalone View

View Options

net-mgmt/librenms/Makefile

# Created by: Muhammad Moinur Rahman<bofh@FreeBSD.org> # Created by: Muhammad Moinur Rahman<bofh@FreeBSD.org>
# $FreeBSD$ # $FreeBSD$
PORTNAME= librenms PORTNAME= librenms
PORTVERSION= 1.35 PORTVERSION= 1.42.01
PORTREVISION= 0 # RELEASE_TIMESTAMP is used for a patch inside the vendor code
# it represents the release date via: git show --pretty='%H|%ct' -s 1.42.01
# It sits here so you remember to update it with each release
RELEASE_TIMESTAMP= 1533413232
dvlAuthorUnsubmitted
Not Done
Inline Actions

This is for net-mgmt/librenms/files/patch-includes_common.php

The code expects a timestamp value.

dvl: This is for net-mgmt/librenms/files/patch-includes_common.php The code expects a timestamp…
PORTREVISION= 9
dvlAuthorUnsubmitted
Not Done
Inline Actions

This must be removed before the commit.

dvl: This must be removed before the commit.
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= net-mgmt CATEGORIES= net-mgmt
MASTER_SITES= LOCAL/dvl:vendor
DISTFILES= ${PORTNAME}-vendor-${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX}${EXTRACT_SUFX}:vendor
dvlAuthorUnsubmitted
Done
Inline Actions

I have no idea if this is the correct way to specify additional MASTER_SITES and DISTFILES

It is working, but I suspect there is a better way.

dvl: I have no idea if this is the correct way to specify additional MASTER_SITES and DISTFILES It…
matUnsubmitted
Done
Inline Actions

It is not, as make fetch-urlall-list will show you. Read 5.4.9. Multiple Distribution or Patches Files from Multiple Locations

mat: It is not, as `make fetch-urlall-list` will show you. Read [[ https://www.freebsd.
dvlAuthorUnsubmitted
Not Done
Inline Actions

Ahh, I did not see that when searching. merci.

$ make fetch-urlall-list
http://distcache.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
http://distcache.us-east.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
http://distcache.eu.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
http://distcache.us-west.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
http://distcache.FreeBSD.org/ports-distfiles/librenms-vendor-1.42.01.tar.gz
https://codeload.github.com/librenms/librenms/tar.gz/1.42.01?dummy=/librenms-librenms-1.42.01_GH0.tar.gz
http://distcache.FreeBSD.org/ports-distfiles/librenms-librenms-1.42.01_GH0.tar.gz
https://codeload.github.com/librenms/librenms/tar.gz/1.42.01?dummy=/librenms-librenms-1.42.01_GH0.tar.gz
http://distcache.FreeBSD.org/ports-distfiles/librenms-librenms-1.42.01_GH0.tar.gz
dvl: Ahh, I did not see that when searching. merci. ``` $ make fetch-urlall-list http://distcache.
matUnsubmitted
Done
Inline Actions

You should probably use ports-mgmt/distilator to check things instead of relying on eyes and fetch-urlall-list :-)

mat: You should probably use ports-mgmt/distilator to check things instead of relying on eyes and…
dvlAuthorUnsubmitted
Not Done
Inline Actions

This is a nice tool. Thank you.

$ distilator . 
301 [WWW]	http://www.librenms.org -> https://www.librenms.org/
200 [DISTFILE]	http://distcache.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
200 [DISTFILE]	http://distcache.eu.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
200 [DISTFILE]	https://codeload.github.com/librenms/librenms/tar.gz/1.42.01?dummy=/librenms-librenms-1.42.01_GH0.tar.gz
200 [DISTFILE]	http://distcache.us-west.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
200 [DISTFILE]	http://distcache.us-east.FreeBSD.org/local-distfiles/dvl/librenms-vendor-1.42.01.tar.gz
dvl: This is a nice tool. Thank you. ``` $ distilator . 301 [WWW] http://www.librenms.org ->…
dvlAuthorUnsubmitted
Done
Inline Actions

I am going to change this to use PORTVERSION etc.

dvl: I am going to change this to use PORTVERSION etc.
MAINTAINER= bofh@FreeBSD.org MAINTAINER= bofh@FreeBSD.org
dvlAuthorUnsubmitted
Not Done
Inline Actions

Is this an appropriate way to name the vendor distfile?

dvl: Is this an appropriate way to name the vendor distfile?
matUnsubmitted
Done
Inline Actions

Remove all the :librenms stuff, it's already added, correctly, by USE_GITHUB.

mat: Remove all the `:librenms` stuff, it's already added, correctly, by `USE_GITHUB`.
dvlAuthorUnsubmitted
Not Done
Inline Actions

Yes, I noticed this:

===>  Extracting for librenms-1.42.01_5,1
=> SHA256 Checksum OK for librenms-vendor-1.42.01.tar.gz.
=> SHA256 Checksum OK for librenms-librenms-1.42.01_GH0.tar.gz.
=> SHA256 Checksum OK for librenms-librenms-1.42.01_GH0.tar.gz.
dvl: Yes, I noticed this: ``` ===> Extracting for librenms-1.42.01_5,1 => SHA256 Checksum OK for…
COMMENT= Autodiscovering PHP/MySQL/SNMP based network monitoring COMMENT= Autodiscovering PHP/MySQL/SNMP based network monitoring
LICENSE= GPLv3 LICENSE= GPLv3
USES= python${PY_MYSQL} shebangfix
USERS= www
WWW_USER= www
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters…
dvlAuthorUnsubmitted
Not Done
Inline Actions

I moved a whole bunch of stuff around.

dvl: I moved a whole bunch of stuff around.
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= librenms GH_ACCOUNT= librenms
USES= python${PY_MYSQL} shebangfix
SHEBANG_FILES= scripts/auth_test.php scripts/deploy-docs.sh scripts/github-remove \ SHEBANG_FILES= scripts/auth_test.php scripts/deploy-docs.sh scripts/github-remove \
scripts/Migration/Standard_Conversion/convert_no_xml.sh \ scripts/Migration/Standard_Conversion/convert_no_xml.sh \
scripts/Migration/Standard_Conversion/destwork_no_xml.sh \ scripts/Migration/Standard_Conversion/destwork_no_xml.sh \
scripts/Migration/Standard_Conversion/mkdir.sh \ scripts/Migration/Standard_Conversion/mkdir.sh \
scripts/Migration/XML_Conversion/convert.sh \ scripts/Migration/XML_Conversion/convert.sh \
scripts/Migration/XML_Conversion/destwork.sh \ scripts/Migration/XML_Conversion/destwork.sh \
scripts/Migration/XML_Conversion/mkdir.sh \ scripts/Migration/XML_Conversion/mkdir.sh \
scripts/removespikes.php scripts/agent-local/nfs-stats.sh \ scripts/removespikes.php scripts/agent-local/nfs-stats.sh \
scripts/removespikes.pl scripts/watchmaillog/watchmaillog.pl \ scripts/removespikes.pl scripts/watchmaillog/watchmaillog.pl \
vendor/ezyang/htmlpurifier/maintenance/add-vimline.php \ poller.php poller-wrapper.py \
vendor/ezyang/htmlpurifier/maintenance/config-scanner.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/generate-includes.php \
vendor/ezyang/htmlpurifier/maintenance/flush-definition-cache.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/flush-definition-cache.php \
vendor/ezyang/htmlpurifier/maintenance/flush.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/old-remove-require-once.php \
vendor/ezyang/htmlpurifier/maintenance/generate-entity-file.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/config-scanner.php \
vendor/ezyang/htmlpurifier/maintenance/generate-includes.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/flush.php \
vendor/ezyang/htmlpurifier/maintenance/generate-schema-cache.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/add-vimline.php \
vendor/ezyang/htmlpurifier/maintenance/generate-standalone.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/remove-trailing-whitespace.php \
vendor/ezyang/htmlpurifier/maintenance/merge-library.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/merge-library.php \
vendor/ezyang/htmlpurifier/maintenance/old-extract-schema.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/old-extract-schema.php \
vendor/ezyang/htmlpurifier/maintenance/old-remove-require-once.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/rename-config.php \
vendor/ezyang/htmlpurifier/maintenance/old-remove-schema-def.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/generate-standalone.php \
vendor/ezyang/htmlpurifier/maintenance/rename-config.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/generate-schema-cache.php \
vendor/ezyang/htmlpurifier/maintenance/remove-trailing-whitespace.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/old-remove-schema-def.php \
vendor/ezyang/htmlpurifier/maintenance/update-config.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/generate-entity-file.php \
vendor/tecnickcom/tcpdf/tools/tcpdf_addfont.php \ ../${PORTNAME}-vendor-${PORTVERSION}/ezyang/htmlpurifier/maintenance/update-config.php \
poller.php poller-wrapper.py ../${PORTNAME}-vendor-${PORTVERSION}/swiftmailer/swiftmailer/lib/swiftmailer_generate_mimes_config.php \
../${PORTNAME}-vendor-${PORTVERSION}/tecnickcom/tcpdf/tools/tcpdf_addfont.php
USE_PHP= ctype curl filter gd hash json ldap mcrypt mysqli openssl posix session simplexml snmp tokenizer xml USE_PHP= ctype curl filter gd hash json ldap mbstring mcrypt mysqli openssl pdo posix session simplexml snmp tokenizer xml zip
# perhaps we also need python-memcache python-mysqldb
NO_BUILD= yes NO_BUILD= yes
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters…
dvlAuthorUnsubmitted
Not Done
Inline Actions

Oh, it goes after USES and USE

dvl: Oh, it goes after USES and USE
RUN_DEPENDS+= rrdtool:databases/rrdtool \ RUN_DEPENDS+= rrdtool:databases/rrdtool \
matUnsubmitted
Done
Inline Actions

Why +=?

mat: Why `+=`?
dvlAuthorUnsubmitted
Not Done
Inline Actions

I don't know.

dvl: I don't know.
dot:graphics/graphviz \ dot:graphics/graphviz \
${LOCALBASE}/share/pear/Net/IPv4.php:net/pear-Net_IPv4@${PHP_FLAVOR} \ ${LOCALBASE}/share/pear/Net/IPv4.php:net/pear-Net_IPv4@${PHP_FLAVOR} \
${LOCALBASE}/share/pear/Net/IPv6.php:net/pear-Net_IPv6@${PHP_FLAVOR} \ ${LOCALBASE}/share/pear/Net/IPv6.php:net/pear-Net_IPv6@${PHP_FLAVOR} \
snmpget:net-mgmt/net-snmp \ snmpget:net-mgmt/net-snmp \
bash:shells/bash \ bash:shells/bash \
sudo:security/sudo sudo:security/sudo
OPTIONS_DEFINE= APACHEMOD FPING IPMITOOL LIBVIRT MYSQLD NAGPLUGINS NMAP PYPOLLER WMIC DOCS EXAMPLES X11 OPTIONS_DEFINE= APACHEMOD FPING IPMITOOL LIBVIRT MYSQLD NAGPLUGINS NMAP PYPOLLER WMIC DOCS EXAMPLES X11
Show All 19 Lines
WMIC_RUN_DEPENDS= wmic:net-mgmt/wmi-client WMIC_RUN_DEPENDS= wmic:net-mgmt/wmi-client
MYSQLD_USES= mysql:server MYSQLD_USES= mysql:server
MYSQLD_USES_OFF= mysql:client MYSQLD_USES_OFF= mysql:client
SUB_FILES+= pkg-message SUB_FILES+= pkg-message
SUB_LIST+= PHP="${PHPBASE}/bin/php" PYTHON=${PYTHON_CMD} SUB_LIST+= PHP="${PHPBASE}/bin/php" PYTHON=${PYTHON_CMD}
ROOT_FILES= addhost.php adduser.php alerts.php build-base.php build.sql \ ROOT_FILES= .env.example addhost.php adduser.php alerts.php artisan billing-calculate.php \
billing-calculate.php check-services.php composer.json \ build-base.php build.sql check-services.php composer.json \
config.php.default config_to_json.php cronic daily.php daily.sh \ composer.lock config.php.default config_to_json.php cronic daily.php daily.sh \
delhost.php discovery-wrapper.py discovery.php dist-pollers.php irc.php \ delhost.php discovery-wrapper.py discovery.php dist-pollers.php irc.php \
mkdocs.yml pbin.sh phpunit.xml poll-billing.php poller.php poller-service.py \ librenms-service.py mkdocs.yml pbin.sh phpunit.xml ping.php poll-billing.php poller.php poller-service.py \
poller-wrapper.py readmegen.yml renamehost.php services-wrapper.py \ poller-wrapper.py readmegen.yml renamehost.php services-wrapper.py snmp-scan.py \
snmptrap.php syslog.php validate.php snmptrap.php syslog.php validate.php
ROOT_DIRS= LibreNMS contrib doc html includes lib logs mibs misc rrd scripts sql-schema tests vendor ROOT_DIRS= LibreNMS app bootstrap config contrib database doc html includes lib licenses logs mibs misc resources routes scripts sql-schema storage tests
DOCS= AUTHORS.md CHANGELOG CONTRIBUTING.md LICENSE.txt README.md # these are directories which require a generic @DIR entry in pkg-plist
OTHER_DIRS= storage/app/public \
storage/debugbar \
storage/framework/testing \
storage/logs \
vendor/amenadiel/jpgraph/tests/_output \
vendor/amenadiel/jpgraph/tests/_support/_generated \
vendor/laravel/laravel/bootstrap/cache \
vendor/laravel/laravel/storage/app/public \
vendor/laravel/laravel/storage/framework/cache \
vendor/laravel/laravel/storage/framework/sessions \
vendor/laravel/laravel/storage/framework/testing \
vendor/laravel/laravel/storage/framework/views \
vendor/laravel/laravel/storage/logs
DOCS= AUTHORS.md CHANGELOG.md CONTRIBUTING.md LICENSE.txt README.md
PORTDOCS= * PORTDOCS= *
PORTEXAMPLES= snmp.conf.example snmpd.conf.example PORTEXAMPLES= snmp.conf.example snmpd.conf.example
NO_ARCH= yes NO_ARCH= yes
APACHEMOD_USES= php:mod APACHEMOD_USES= php:mod
APACHEMOD_USES_OFF= php:web APACHEMOD_USES_OFF= php:web
APACHEMOD_USE= APACHE_RUN=22+ APACHEMOD_USE= USES=apache:run,22+
post-patch: post-patch:
${REINPLACE_CMD} 's|%%LOCALBASE%%|${LOCALBASE}|g' \ ${REINPLACE_CMD} 's|%%PORTNAME%%|${PORTNAME}|g' ${WRKSRC}/config.php.default
${WRKSRC}/poller-wrapper.py ${WRKSRC}/poller.php ${REINPLACE_CMD} 's|%%WWW_USER%%|${WWW_USER}|g' ${WRKSRC}/config.php.default
${REINPLACE_CMD} 's|%%PORTVERSION%%|${PORTVERSION}|g' \ ${REINPLACE_CMD} 's|%%LOCALBASE%%|${LOCALBASE}|g' ${WRKSRC}/poller-wrapper.py ${WRKSRC}/poller.php
${WRKSRC}/includes/common.php ${REINPLACE_CMD} 's|%%PORTVERSION%%|${PORTVERSION}|g' ${WRKSRC}/includes/common.php
${REINPLACE_CMD} -e 's|/opt/librenms|${WWWDIR}|' \ ${REINPLACE_CMD} 's|%%RELEASE_TIMESTAMP%%|${RELEASE_TIMESTAMP}|g' ${WRKSRC}/includes/common.php
${WRKSRC}/html/install.php ${REINPLACE_CMD} -e 's|/opt/librenms|${WWWDIR}|' ${WRKSRC}/html/install.php
${RM} ${WRKSRC}/LibreNMS/Validations/Updates.php ${RM} ${WRKSRC}/LibreNMS/Validations/Updates.php
do-install: do-install:
${MKDIR} ${STAGEDIR}/${WWWDIR} ${MKDIR} ${STAGEDIR}/${WWWDIR}
.for dir in ${ROOT_DIRS} .for dir in ${ROOT_DIRS}
${MKDIR} ${STAGEDIR}/${WWWDIR}/${dir} ${MKDIR} ${STAGEDIR}/${WWWDIR}/${dir}
(cd ${WRKSRC}/${dir} && ${COPYTREE_SHARE} . ${STAGEDIR}/${WWWDIR}/${dir}) (cd ${WRKSRC}/${dir} && ${COPYTREE_SHARE} . ${STAGEDIR}/${WWWDIR}/${dir})
.endfor .endfor
.for f in ${ROOT_FILES} .for f in ${ROOT_FILES}
${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${WWWDIR} ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${WWWDIR}
.endfor .endfor
${MKDIR} ${STAGEDIR}/${WWWDIR}/vendor
(cd ${WRKDIR}/${PORTNAME}-vendor-${PORTVERSION} && ${COPYTREE_SHARE} . ${STAGEDIR}/${WWWDIR}/vendor)
# Make daily.sh executable # Make daily.sh executable
${CHMOD} 0755 ${STAGEDIR}/${WWWDIR}/daily.sh ${CHMOD} 0755 ${STAGEDIR}/${WWWDIR}/daily.sh
# Files in scripts dir should be executable # Files in scripts dir should be executable
${FIND} ${STAGEDIR}/${WWWDIR}/scripts -type f -exec ${CHMOD} +x {} \; ${FIND} ${STAGEDIR}/${WWWDIR}/scripts -type f -exec ${CHMOD} +x {} \;
# Ensure PHP and Python scripts are executable # Ensure PHP and Python scripts are executable
${FIND} ${STAGEDIR}/${WWWDIR} -type f -name '*.py' -or -type f -name \ ${FIND} ${STAGEDIR}/${WWWDIR} -type f -name '*.py' -or -type f -name \
'*.php' -exec ${CHMOD} +x {} \; '*.php' -exec ${CHMOD} +x {} \;
do-install-DOCS-on: do-install-DOCS-on:
${MKDIR} ${STAGEDIR}/${DOCSDIR} ${MKDIR} ${STAGEDIR}/${DOCSDIR}
.for f in ${DOCS} .for f in ${DOCS}
${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${DOCSDIR} ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${DOCSDIR}
.endfor .endfor
cd ${WRKSRC}/doc && ${COPYTREE_SHARE} . ${STAGEDIR}/${DOCSDIR} cd ${WRKSRC}/doc && ${COPYTREE_SHARE} . ${STAGEDIR}/${DOCSDIR}
do-install-EXAMPLES-on: do-install-EXAMPLES-on:
${MKDIR} ${STAGEDIR}/${EXAMPLESDIR} ${MKDIR} ${STAGEDIR}/${EXAMPLESDIR}
.for f in ${PORTEXAMPLES} .for f in ${PORTEXAMPLES}
${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${EXAMPLESDIR} ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}/${EXAMPLESDIR}
.endfor .endfor
post-install: post-install:
@${FIND} -s ${STAGEDIR}${WWWDIR} -type f '(' -name '*.orig' -or -name '*.bak' ')' -delete @${FIND} -s ${STAGEDIR}${WWWDIR} -type f '(' -name '*.orig' -or -name '*.bak' -or -name '.gitignore' ')' -delete
@${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \ @${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \
${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST} ${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/logs" >> ${TMPPLIST} @${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/logs" >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/rrd" >> ${TMPPLIST} @${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/bootstrap/cache" >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/storage" >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/storage/framework/cache" >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/storage/framework/sessions" >> ${TMPPLIST}
@${ECHO_CMD} "@dir(www,www,0775) ${WWWDIR}/storage/framework/views" >> ${TMPPLIST}
.for f in ${OTHER_DIRS}
@${ECHO_CMD} "@dir(root,www,0775) ${WWWDIR}/${f}" >> ${TMPPLIST}
.endfor
dvlAuthorUnsubmitted
Not Done
Inline Actions

The upstream vendor code expects to write to this location, hence the +w

I don't like it. I would prefer the code did not do this, but there is no known configuration change which will affect this.

dvl: The upstream vendor code expects to write to this location, hence the +w I don't like it. I…
.include <bsd.port.mk> .include <bsd.port.mk>