Differential D13528 Diff 47055 head/sys/fs/fuse/fuse_kernel.h

Changeset View

Standalone View

head/sys/fs/fuse/fuse_kernel.h

	Show First 20 Lines • Show All 276 Lines • ▼ Show 20 Lines
	};			};

	struct fuse_fsync_in {			struct fuse_fsync_in {
	__u64 fh;			__u64 fh;
	__u32 fsync_flags;			__u32 fsync_flags;
	__u32 padding;			__u32 padding;
	};			};

	struct fuse_setxattr_in {			struct fuse_listxattr_in {
	__u32 size;			__u32 size;
	__u32 flags;			__u32 flags;
				john_john-millikin.comUnsubmitted Not Done Inline Actions Shouldn't this line be `__u32 padding`, to match the previous use of `fuse_getxattr_in` for `FUSE_LISTXATTR`? Otherwise it's deviating from the ABI of mainline FUSE. john_john-millikin.com: Shouldn't this line be `__u32 padding`, to match the previous use of `fuse_getxattr_in` for…
				cemUnsubmitted Not Done Inline Actions Perhaps the name should match for stylistic reasons (or perhaps not, I don't know), but the name of a C struct member variable does not affect wire protocol ABI in any way. cem: Perhaps the name should match for stylistic reasons (or perhaps not, I don't know), but the…
	};			};

				struct fuse_listxattr_out {
				__u32 size;
				__u32 flags;
				john_john-millikin.comUnsubmitted Not Done Inline Actions I think this should also be `padding`, to match `fuse_getxattr_out`. john_john-millikin.com: I think this should also be `padding`, to match `fuse_getxattr_out`.
				};

	struct fuse_getxattr_in {			struct fuse_getxattr_in {
	__u32 size;			__u32 size;
	__u32 padding;			__u32 padding;
	};			};

	struct fuse_getxattr_out {			struct fuse_getxattr_out {
	__u32 size;			__u32 size;
	__u32 padding;			__u32 padding;
				};

				struct fuse_setxattr_in {
				__u32 size;
				__u32 flags;
	};			};

	struct fuse_lk_in {			struct fuse_lk_in {
	__u64 fh;			__u64 fh;
	__u64 owner;			__u64 owner;
	struct fuse_file_lock lk;			struct fuse_file_lock lk;
	};			};

	▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines