Changeset View
Changeset View
Standalone View
Standalone View
lib/libc/gen/arc4random-compat.c
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
/*- | |||||
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD | |||||
* | |||||
* Copyright (c) 2018 Google LLC | |||||
* All rights reserved. | |||||
* | |||||
* Redistribution and use in source and binary forms, with or without | |||||
* modification, are permitted provided that the following conditions | |||||
* are met: | |||||
* 1. Redistributions of source code must retain the above copyright | |||||
* notice, this list of conditions and the following disclaimer. | |||||
* 2. Redistributions in binary form must reproduce the above copyright | |||||
* notice, this list of conditions and the following disclaimer in the | |||||
* documentation and/or other materials provided with the distribution. | |||||
* | |||||
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND | |||||
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | |||||
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | |||||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | |||||
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | |||||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | |||||
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | |||||
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | |||||
* SUCH DAMAGE. | |||||
* | |||||
* $FreeBSD$ | |||||
*/ | |||||
#include <sys/cdefs.h> | |||||
__FBSDID("$FreeBSD$"); | |||||
#include <sys/types.h> | |||||
#include <stdbool.h> | |||||
#include <syslog.h> | |||||
/* | |||||
* The following functions were removed from OpenBSD for good reasons: | |||||
* | |||||
* - arc4random_stir() | |||||
* - arc4random_addrandom() | |||||
* | |||||
* On FreeBSD, for backward ABI compatibility, we provide two wrapper which | |||||
* logs this event and returns. | |||||
*/ | |||||
void __arc4random_stir_fbsd11(void); | |||||
void __arc4random_addrandom_fbsd11(u_char *, int); | |||||
void | |||||
__arc4random_stir_fbsd11(void) | |||||
{ | |||||
static bool warned = false; | |||||
if (!warned) | |||||
syslog(LOG_DEBUG, "Deprecated function arc4random_stir() called"); | |||||
warned = true; | |||||
} | |||||
devnexen_gmail.com: WARNING level maybe since it s advertised only once. | |||||
Done Inline Actions@devnexen_gmail.com It's not very clear to me what would be the best level. The fact that an application is doing it doesn't necessarily mean something bad (and it's actually a good sign that they are not linking against libc statically). With that in mind, maybe this belongs to LOG_DEBUG? For userland LOG_WARNING isn't really distinguishable to LOG_NOTICE (only kern.warning are being sent to console). delphij: @devnexen_gmail.com It's not very clear to me what would be the best level. The fact that an… | |||||
Done Inline ActionsIt seems weird to warn about a specific function being invoked but share a single warned variable. cem: It seems weird to warn about a specific function being invoked but share a single `warned`… | |||||
Done Inline ActionsACK. Will move it to a per function static. delphij: ACK. Will move it to a per function static. | |||||
void | |||||
Done Inline Actionsreturn is gratuitous cem: return is gratuitous | |||||
Done Inline ActionsACK, this is actually against style(9), I will also fix __arc4random_addrandom_fbsd11. delphij: ACK, this is actually against style(9), I will also fix __arc4random_addrandom_fbsd11. | |||||
__arc4random_addrandom_fbsd11(u_char * dummy1 __unused, int dummy2 __unused) | |||||
{ | |||||
static bool warned = false; | |||||
if (!warned) | |||||
syslog(LOG_DEBUG, "Deprecated function arc4random_addrandom() called"); | |||||
warned = true; | |||||
} | |||||
__sym_compat(arc4random_stir, __arc4random_stir_fbsd11, FBSD_1.0); | |||||
__sym_compat(arc4random_addrandom, __arc4random_addrandom_fbsd11, FBSD_1.0); |
WARNING level maybe since it s advertised only once.