Changeset View
Standalone View
net-p2p/transmission-qt/Makefile
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PKGNAMESUFFIX= -qt4 | PKGNAMESUFFIX= -${FLAVOR} | ||||
| MAINTAINER= crees@FreeBSD.org | LIB_DEPENDS= libfontconfig.so:x11-fonts/fontconfig \ | ||||
| COMMENT= Fast and lightweight Qt4 BitTorrent client | |||||
| LIB_DEPENDS= ${GEN_LIB_DEPENDS} \ | |||||
| libfontconfig.so:x11-fonts/fontconfig \ | |||||
| libfreetype.so:print/freetype2 | libfreetype.so:print/freetype2 | ||||
| RUN_DEPENDS= ${GEN_RUN_DEPENDS} | |||||
| CONFLICTS_INSTALL= transmission-qt5-[0-9]* | FLAVORS= qt4 qt5 | ||||
| FLAVOR?= ${FLAVORS:[1]} | |||||
| DESCR= ${.CURDIR}/pkg-descr | qt4_CONFLICTS_INSTALL= transmission-qt5 | ||||
| MASTERDIR= ${.CURDIR}/../transmission-cli | qt5_CONFLICTS_INSTALL= transmission-qt4 | ||||
| PLIST= ${.CURDIR}/pkg-plist | |||||
| SLAVEPORT= qt4 | |||||
| USE_QT= moc_build qmake_build uic_build rcc_build \ | .if ${FLAVOR} == qt4 | ||||
| corelib gui dbus network xml | USES= qt:4 | ||||
| USES= compiler:c++11-lib desktop-file-utils qmake:no_env qt:4 | NLS_USES= gettext-runtime:run qt:4 | ||||
mat: This should happen later. See [[ https://www.freebsd.org/doc/en/books/porters-handbook/porting… | |||||
| USE_QT= moc_build linguisttools_build qmake_build rcc_build \ | |||||
| uic_build corelib dbus gui network xml | |||||
Done Inline Actions^ you should probably set the shared USES lines in the master port, with += and only add the qt-specific here. tcberner: ^ you should probably set the shared USES lines in the master port, with += and only add the qt… | |||||
| CMAKE_OFF+= USE_QT5 | |||||
Done Inline ActionsWrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters… | |||||
Done Inline Actions^ you should add tcberner: ^ you should add
CMAKE_OFF+=USE_QT5 for the qt4 one | |||||
| .endif | |||||
| EXTRA_CONF_ARGS=--disable-cli \ | .if ${FLAVOR} == qt5 | ||||
Done Inline ActionsBoth USES lines are the same, extract them from the .if. mat: Both USES lines are the same, extract them from the .if. | |||||
| --disable-daemon \ | USES= qt:5 | ||||
| --without-gtk \ | NLS_USES= gettext-runtime:run qt:5 | ||||
| --disable-mac \ | USE_QT= buildtools_build linguisttools_build qmake_build \ | ||||
Done Inline Actionsyou need to add CMAKE_ON= #empty (to not use the default in the masterport) tcberner: you need to add
```
CMAKE_ON= #empty (to not use the default in the masterport)
``` | |||||
Done Inline Actionsmake that CMAKE_ON=ENABLE_QT othwerise you'll get -D:BOOL=TRUE added .... that needs to be fixed in cmake.mk :D tcberner: make that
```
CMAKE_ON=ENABLE_QT
```
othwerise you'll get `-D:BOOL=TRUE` added .... that… | |||||
| --disable-nls | core dbus gui network widgets | ||||
| CMAKE_ON= USE_QT5 | |||||
| .endif | |||||
Done Inline ActionsStill wrong. up, up, with the flavors. Could you please read Chapter 15. Order of Variables in Port Makefiles, and apply its content. It would go so much faster than me having to knit pick every lines. mat: Still wrong. up, up, with the flavors.
Could you please read [[ https://www.freebsd. | |||||
| post-patch: general-patch | MASTERDIR= ${.CURDIR}/../transmission-cli | ||||
| @${REINPLACE_CMD} -e 's|/share/man|/man|g ; /PKGCONFIG/s| openssl||g' \ | DESCR= ${.CURDIR}/pkg-descr | ||||
Done Inline Actions^typo tcberner: ^typo | |||||
| ${WRKSRC}/qt/qtr.pro | PLIST= ${.CURDIR}/pkg-plist | ||||
| @${ECHO_CMD} 'LIBS += -l${PORT_OPTIONS:M*SSL:tl:S/openssl/crypto/}' \ | |||||
| >>${WRKSRC}/qt/qtr.pro | |||||
| post-build: | SLAVEPORT= qt | ||||
| @(cd ${WRKSRC}/qt && ${QMAKE} ${QMAKE_ARGS} qtr.pro && ${MAKE_CMD}) | |||||
| do-install: | |||||
| @(cd ${WRKSRC}/qt && \ | |||||
| ${SETENV} INSTALL_ROOT=${STAGEDIR}${PREFIX} ${MAKE_CMD} install) | |||||
| post-install: general-install | |||||
| @${MKDIR} ${STAGEDIR}${DOCSDIR} | |||||
| @${INSTALL_DATA} ${WRKSRC}/qt/README.txt \ | |||||
| ${STAGEDIR}${DOCSDIR}/README-qt4 | |||||
| @${INSTALL_DATA} ${WRKSRC}/qt/transmission-qt.desktop \ | |||||
| ${STAGEDIR}${PREFIX}/share/applications/ | |||||
| @${INSTALL_DATA} ${WRKSRC}/qt/icons/transmission.png \ | |||||
| ${STAGEDIR}${PREFIX}/share/pixmaps/transmission-qt.png | |||||
| .include "${MASTERDIR}/Makefile" | .include "${MASTERDIR}/Makefile" | ||||
Done Inline ActionsThis looks bogus. mat: This looks bogus. | |||||
Done Inline Actionsqt[4,5] versions can not be installed together because several files are called 'transmission-qt' and would conflict. rigoletto: qt[4,5] versions can not be installed together because several files are called 'transmission… | |||||
Done Inline ActionsYes, good, I had understood that. The line is still wrong. mat: Yes, good, I had understood that. The line is still wrong. | |||||
Done Inline ActionsThis is still wrong. mat: This is still wrong. | |||||
Done Inline ActionsThis should happen earlier. mat: This should happen earlier. | |||||
Done Inline Actionstcberner: [[https://www.freebsd.org/doc/en/books/porters-handbook/conflicts.html|Conflicts… | |||||
Done Inline Actions^ this still looks wrong. qt4_CONFLICTS_INSTALL= transmission-qt5 qt5_CONFLICTS_INSTALL= transmission-qt4 you could also do it a bit more magically/confusing in one line with something like ${FLAVOR}_CONFLICTS_INSTALL=transmission-${FLAVORS:N${FLAVOR}}:P tcberner: ^ this still looks wrong.
I would probably just set something like
```
qt4_CONFLICTS_INSTALL=… | |||||
Done Inline ActionsAlso, as a side-note: the master port is overriding whatever you set directly as CONFLICTS_INSTALL :) you can check the values you need by doing for example /usr/ports # make -VPKGBASE FLAVOR=qt4 -C net-p2p/transmission-qt transmission-qt4 /usr/ports # make -VPKGBASE FLAVOR=qt5 -C net-p2p/transmission-qt transmission-qt5 In the qt4-flavor you therefore want to conflict with transmission-qt5 and vice versa. tcberner: Also, as a side-note: the master port is overriding whatever you set directly as… | |||||
Done Inline ActionsThat is extremely fragile, and extremely obfuscated, please expand it in the two lines it ends up doing. mat: That is extremely fragile, and extremely obfuscated, please expand it in the two lines it ends… | |||||
Done Inline ActionsWrong place in the Makefile, they are flavors helpers, they should happen in the flavors block. See Chapter 15. Order of Variables in Port Makefiles. mat: Wrong place in the Makefile, they are flavors helpers, they should happen in the flavors block. | |||||
This should happen later. See Chapter 15. Order of Variables in Port Makefiles.