Changeset View
Changeset View
Standalone View
Standalone View
en_US.ISO8859-1/articles/committers-guide/article.xml
| Show First 20 Lines • Show All 3,310 Lines • ▼ Show 20 Lines | */</programlisting> | ||||
| <listitem> | <listitem> | ||||
| <para>Respect existing maintainers if listed.</para> | <para>Respect existing maintainers if listed.</para> | ||||
| <para>Many parts of &os; are not <quote>owned</quote> in | <para>Many parts of &os; are not <quote>owned</quote> in | ||||
| the sense that any specific individual will jump up and | the sense that any specific individual will jump up and | ||||
| yell if you commit a change to <quote>their</quote> area, | yell if you commit a change to <quote>their</quote> area, | ||||
| but it still pays to check first. One convention we use | but it still pays to check first. One convention we use | ||||
| is to put a maintainer line in the | is to put a maintainer line in the | ||||
| <filename>Makefile</filename> for any package or subtree | <filename>Makefile</filename> for any package or subtree | ||||
jhb: src doesn't do this very often if ever. src uses MAINTAINERS which doesn't seem to be… | |||||
eadlerAuthorUnsubmitted Not Done Inline ActionsIts mentioned in other places. See
eadler: Its mentioned in other places. See
> To determine if an area of the tree is maintained, check… | |||||
jhbUnsubmitted Not Done Inline ActionsI just find it confusing that we mention the practice we don't use and don't mention the one we do use. I don't think that is part of this commit btw, but something worth clarifying. (also I can't tell what line that is from your quote, if we want to only describe "how to find a maintainer" in one place, then that is fine, but we should use links to reference that from the other places) jhb: I just find it confusing that we mention the practice we don't use and don't mention the one we… | |||||
eadlerAuthorUnsubmitted Not Done Inline ActionsI agree with you. The guide could use some more work. The patches I sent y'all recently were ones that changed policy or introduced new guidance, and thus required core@ approvals. When my development machine is back to functional, I'll make some more passes over the commit guide for these kinds of issues. eadler: I agree with you. The guide could use some more work. The patches I sent y'all recently were… | |||||
| which is being actively maintained by one or more people; | which is being actively maintained by one or more people; | ||||
| see <link | see <link | ||||
| xlink:href="&url.books.developers-handbook;/policies.html">https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/developers-handbook/policies.html</link> | xlink:href="&url.books.developers-handbook;/policies.html">https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/developers-handbook/policies.html</link> | ||||
| for documentation on this. Where sections of code have | for documentation on this. Where sections of code have | ||||
| several maintainers, commits to affected areas by one | several maintainers, commits to affected areas by one | ||||
| maintainer need to be reviewed by at least one other | maintainer need to be reviewed by at least one other | ||||
| maintainer. In cases where the | maintainer. In cases where the | ||||
| <quote>maintainer-ship</quote> of something is not clear, | <quote>maintainer-ship</quote> of something is not clear, | ||||
| look at the repository logs for the files | look at the repository logs for the files | ||||
| in question and see if someone has been working recently | in question and see if someone has been working recently | ||||
| or predominantly in that area.</para> | or predominantly in that area.</para> | ||||
| <para>Other areas of &os; fall under the control of someone | |||||
| who manages an overall category of &os; evolution, such as | |||||
| internationalization or networking. See <link | |||||
| xlink:href="&url.base;/administration.html">https://www.FreeBSD.org/administration.html</link> | |||||
| for more information on this.</para> | |||||
| </listitem> | </listitem> | ||||
| <listitem> | <listitem> | ||||
| <para>Any disputed change must be backed out pending | <para>Any disputed change must be backed out pending | ||||
| resolution of the dispute if requested by a maintainer. | resolution of the dispute if requested by a maintainer. | ||||
| Security related changes may override a maintainer's | Security related changes may override a maintainer's | ||||
| wishes at the Security Officer's discretion.</para> | wishes at the Security Officer's discretion.</para> | ||||
| ▲ Show 20 Lines • Show All 1,859 Lines • Show Last 20 Lines | |||||
src doesn't do this very often if ever. src uses MAINTAINERS which doesn't seem to be mentioned here.