Page MenuHomeFreeBSD
Differential D14699 Diff 44608 net-p2p/transmission-qt/Makefile

Changeset View

Standalone View

View Options

net-p2p/transmission-qt/Makefile

# $FreeBSD$ # $FreeBSD$
PKGNAMESUFFIX= -qt4 PKGNAMESUFFIX= -${FLAVOR}
MAINTAINER= crees@FreeBSD.org LIB_DEPENDS= libfontconfig.so:x11-fonts/fontconfig \
COMMENT= Fast and lightweight Qt4 BitTorrent client
LIB_DEPENDS= ${GEN_LIB_DEPENDS} \
libfontconfig.so:x11-fonts/fontconfig \
libfreetype.so:print/freetype2 libfreetype.so:print/freetype2
RUN_DEPENDS= ${GEN_RUN_DEPENDS}
CONFLICTS_INSTALL= transmission-qt5-[0-9]* FLAVORS= qt4 qt5
FLAVOR?= ${FLAVORS:[1]}
DESCR= ${.CURDIR}/pkg-descr qt4_CONFLICTS_INSTALL= transmission-qt5
MASTERDIR= ${.CURDIR}/../transmission-cli qt5_CONFLICTS_INSTALL= transmission-qt4
PLIST= ${.CURDIR}/pkg-plist
SLAVEPORT= qt4
USE_QT= moc_build qmake_build uic_build rcc_build \ USES= gettext-runtime:run
corelib gui dbus network xml
USES= compiler:c++11-lib desktop-file-utils qmake:no_env qt:4
EXTRA_CONF_ARGS=--disable-cli \ .if ${FLAVOR} == qt4
matUnsubmitted
Done
Inline Actions

This should happen later. See Chapter 15. Order of Variables in Port Makefiles.

mat: This should happen later. See [[ https://www.freebsd.org/doc/en/books/porters-handbook/porting…
--disable-daemon \ USES= qt:4
--without-gtk \ USE_QT= moc_build qmake_build rcc_build uic_build corelib \
tcbernerUnsubmitted
Done
Inline Actions

^ you should probably set the shared USES lines in the master port, with += and only add the qt-specific here.

tcberner: ^ you should probably set the shared USES lines in the master port, with += and only add the qt…
--disable-mac \ dbus gui network xml
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile. See [[ https://www.freebsd.org/doc/en/books/porters…
tcbernerUnsubmitted
Done
Inline Actions

^ you should add
CMAKE_OFF+=USE_QT5 for the qt4 one

tcberner: ^ you should add CMAKE_OFF+=USE_QT5 for the qt4 one
--disable-nls .endif
post-patch: general-patch .if ${FLAVOR} == qt5
matUnsubmitted
Done
Inline Actions

Both USES lines are the same, extract them from the .if.

mat: Both USES lines are the same, extract them from the .if.
@${REINPLACE_CMD} -e 's|/share/man|/man|g ; /PKGCONFIG/s| openssl||g' \ USES= qt:5
${WRKSRC}/qt/qtr.pro USE_QT= buildtools_build linguisttools_build qmake_build \
@${ECHO_CMD} 'LIBS += -l${PORT_OPTIONS:M*SSL:tl:S/openssl/crypto/}' \ core dbus gui network widgets
tcbernerUnsubmitted
Done
Inline Actions

you need to add

CMAKE_ON= #empty (to not use the default in the masterport)
tcberner: you need to add ``` CMAKE_ON= #empty (to not use the default in the masterport) ```
tcbernerUnsubmitted
Done
Inline Actions

make that

CMAKE_ON=ENABLE_QT

othwerise you'll get -D:BOOL=TRUE added .... that needs to be fixed in cmake.mk :D

tcberner: make that ``` CMAKE_ON=ENABLE_QT ``` othwerise you'll get `-D:BOOL=TRUE` added .... that…
>>${WRKSRC}/qt/qtr.pro CMAKE_ON= USE_QT5
.endif
post-build: MASTERDIR= ${.CURDIR}/../transmission-cli
matUnsubmitted
Done
Inline Actions

Still wrong. up, up, with the flavors.

Could you please read Chapter 15. Order of Variables in Port Makefiles, and apply its content. It would go so much faster than me having to knit pick every lines.

mat: Still wrong. up, up, with the flavors. Could you please read [[ https://www.freebsd.
@(cd ${WRKSRC}/qt && ${QMAKE} ${QMAKE_ARGS} qtr.pro && ${MAKE_CMD}) DESCR= ${.CURDIR}/pkg-descr
PLIST= ${.CURDIR}/pkg-plist
tcbernerUnsubmitted
Done
Inline Actions

^typo

tcberner: ^typo
do-install: SLAVEPORT= qt
@(cd ${WRKSRC}/qt && \
${SETENV} INSTALL_ROOT=${STAGEDIR}${PREFIX} ${MAKE_CMD} install)
post-install: general-install
@${MKDIR} ${STAGEDIR}${DOCSDIR}
@${INSTALL_DATA} ${WRKSRC}/qt/README.txt \
${STAGEDIR}${DOCSDIR}/README-qt4
@${INSTALL_DATA} ${WRKSRC}/qt/transmission-qt.desktop \
${STAGEDIR}${PREFIX}/share/applications/
@${INSTALL_DATA} ${WRKSRC}/qt/icons/transmission.png \
${STAGEDIR}${PREFIX}/share/pixmaps/transmission-qt.png
.include "${MASTERDIR}/Makefile" .include "${MASTERDIR}/Makefile"
matUnsubmitted
Done
Inline Actions

This looks bogus.

mat: This looks bogus.
rigolettoAuthorUnsubmitted
Done
Inline Actions

qt[4,5] versions can not be installed together because several files are called 'transmission-qt' and would conflict.

rigoletto: qt[4,5] versions can not be installed together because several files are called 'transmission…
matUnsubmitted
Done
Inline Actions

Yes, good, I had understood that. The line is still wrong.

mat: Yes, good, I had understood that. The line is still wrong.
matUnsubmitted
Done
Inline Actions

This is still wrong.

mat: This is still wrong.
matUnsubmitted
Done
Inline Actions

This should happen earlier.

mat: This should happen earlier.
tcbernerUnsubmitted
Done
Inline Actions

Conflicts Documentation :)

tcberner: [[https://www.freebsd.org/doc/en/books/porters-handbook/conflicts.html|Conflicts…
tcbernerUnsubmitted
Done
Inline Actions

^ this still looks wrong.
I would probably just set something like

qt4_CONFLICTS_INSTALL= transmission-qt5
qt5_CONFLICTS_INSTALL= transmission-qt4

you could also do it a bit more magically/confusing in one line with something like

${FLAVOR}_CONFLICTS_INSTALL=transmission-${FLAVORS:N${FLAVOR}}

:P

tcberner: ^ this still looks wrong. I would probably just set something like ``` qt4_CONFLICTS_INSTALL=…
tcbernerUnsubmitted
Done
Inline Actions

Also, as a side-note: the master port is overriding whatever you set directly as CONFLICTS_INSTALL :)

you can check the values you need by doing for example

/usr/ports # make -VPKGBASE FLAVOR=qt4 -C net-p2p/transmission-qt
transmission-qt4
/usr/ports # make -VPKGBASE FLAVOR=qt5 -C net-p2p/transmission-qt
transmission-qt5

In the qt4-flavor you therefore want to conflict with transmission-qt5 and vice versa.

tcberner: Also, as a side-note: the master port is overriding whatever you set directly as…
matUnsubmitted
Done
Inline Actions

That is extremely fragile, and extremely obfuscated, please expand it in the two lines it ends up doing.

mat: That is extremely fragile, and extremely obfuscated, please expand it in the two lines it ends…
matUnsubmitted
Done
Inline Actions

Wrong place in the Makefile, they are flavors helpers, they should happen in the flavors block. See Chapter 15. Order of Variables in Port Makefiles.

mat: Wrong place in the Makefile, they are flavors helpers, they should happen in the flavors block.