Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/ips/ips_pci.c
Context not available. | |||||
static int ips_pci_free(ips_softc_t *sc); | static int ips_pci_free(ips_softc_t *sc); | ||||
static void ips_intrhook(void *arg); | static void ips_intrhook(void *arg); | ||||
static struct ips_pci_dev { | |||||
uint16_t vendorid; | |||||
uint16_t deviceid; | |||||
const char *description; | |||||
} ips_pci_devs[] = { | |||||
{IPS_VENDOR_ID, IPS_MORPHEUS_DEVICE_ID, "IBM ServeRAID Adapter"}, | |||||
{IPS_VENDOR_ID, IPS_COPPERHEAD_DEVICE_ID, "IBM ServeRAID Adapter"}, | |||||
{IPS_VENDOR_ID_ADAPTEC, IPS_MARCO_DEVICE_ID, "Adaptec ServeRAID Adapter"}, | |||||
{0,0,0}, | |||||
}; | |||||
static int ips_pci_probe(device_t dev) | static int ips_pci_probe(device_t dev) | ||||
{ | { | ||||
const struct ips_pci_dev *ipsd; | |||||
if ((pci_get_vendor(dev) == IPS_VENDOR_ID) && | u_int16_t vid; | ||||
(pci_get_device(dev) == IPS_MORPHEUS_DEVICE_ID)) { | u_int16_t did; | ||||
device_set_desc(dev, "IBM ServeRAID Adapter"); | size_t i; | ||||
return (BUS_PROBE_DEFAULT); | |||||
} else if ((pci_get_vendor(dev) == IPS_VENDOR_ID) && | vid = pci_get_vendor(dev); | ||||
(pci_get_device(dev) == IPS_COPPERHEAD_DEVICE_ID)) { | did = pci_get_device(dev); | ||||
device_set_desc(dev, "IBM ServeRAID Adapter"); | for (i=0; i<nitems(ips_pci_devs) - 1; i++) { | ||||
chuck: `style(9)` nits including:
- Unary operators do not require spaces, binary operators do. | |||||
Done Inline ActionsBetter, but for() should be: chuck: Better, but for() should be:
`for (i = 0; i < nitems(ips_pci_devs) - 1; i++) {`
Fix here and… | |||||
Done Inline ActionsThis is how i can see it. "for (i = 0; i < nitems(ips_pci_devs) - 1; i++) {" lakhanshiva_gmail.com: This is how i can see it. "for (i = 0; i < nitems(ips_pci_devs) - 1; i++) {"
Is it for some… | |||||
Done Inline ActionsUnderstood, the space between i and nitems. My bad ! Fixed it. lakhanshiva_gmail.com: Understood, the space between i and nitems. My bad ! Fixed it. | |||||
return (BUS_PROBE_DEFAULT); | ipsd = &ips_pci_devs[i]; | ||||
} else if ((pci_get_vendor(dev) == IPS_VENDOR_ID_ADAPTEC) && | if((vid == ipsd->vendorid) && (did == ipsd->deviceid)) { | ||||
(pci_get_device(dev) == IPS_MARCO_DEVICE_ID)) { | device_set_desc(dev, ipsd->description); | ||||
device_set_desc(dev, "Adaptec ServeRAID Adapter"); | return (BUS_PROBE_DEFAULT); | ||||
return (BUS_PROBE_DEFAULT); | } | ||||
} | } | ||||
return(ENXIO); | return (ENXIO); | ||||
} | } | ||||
static int ips_pci_attach(device_t dev) | static int ips_pci_attach(device_t dev) | ||||
Context not available. | |||||
static devclass_t ips_devclass; | static devclass_t ips_devclass; | ||||
DRIVER_MODULE(ips, pci, ips_pci_driver, ips_devclass, 0, 0); | DRIVER_MODULE(ips, pci, ips_pci_driver, ips_devclass, 0, 0); | ||||
MODULE_PNP_INFO("U16:vendor;U16:device;D:#", pci, ips, ips_pci_devs, | |||||
Done Inline ActionsShould this include D:#? chuck: Should this include `D:#`? | |||||
sizeof(ips_pci_devs[0]), nitems(ips_pci_devs) - 1); | |||||
Context not available. |
style(9) nits including: