Page MenuHomeFreeBSD
Differential D14699 Diff 44449 net-p2p/transmission/Makefile

Changeset View

Standalone View

View Options

net-p2p/transmission/Makefile

# $FreeBSD$ # $FreeBSD$
PORTNAME= transmission PORTNAME= transmission
PORTVERSION= 2.93 DISTVERSION= 2.94
CATEGORIES= net-p2p CATEGORIES= net-p2p
MAINTAINER= crees@FreeBSD.org MAINTAINER= lebarondemerde@privacychain.ch
COMMENT= Meta-port for Transmission BitTorrent client COMMENT= Meta-port for Transmission BitTorrent client
RUN_DEPENDS= transmission-cli:net-p2p/transmission-cli \ USES= metaport
transmission-daemon:net-p2p/transmission-daemon \
transmission-gtk:net-p2p/transmission-gtk
CONFLICTS_INSTALL= ${PORTNAME}${PKGNAMESUFFIX}-2.[56]* OPTIONS_DEFINE= CLI DAEMON GTK QT4 QT5 WEB
USES= metaport CLI_DESC= Command line version
DAEMON_DESC= Daemon version
GTK_DESC= GTK version
QT4_DESC= Qt4 version
QT5_DESC= Qt5 version
adridgUnsubmitted
Done
Inline Actions

The web flavor (assuming it's just the files in web/) is GPLv2-only, for instance. You could say GPLv2 here and be not-wrong.

adridg: The web flavor (assuming it's just the files in web/) is GPLv2-only, for instance. You could…
rigolettoAuthorUnsubmitted
Done
Inline Actions

I will let this LICENSE issue for when I manage to the last. :o)

Thanks

rigoletto: I will let this LICENSE issue for when I manage to the last. :o) Thanks
WEB_DESC= Web client
OPTIONS_DEFAULT= CLI DAEMON GTK QT4 QT5 WEB
tcbernerUnsubmitted
Done
Inline Actions

^ what's the issue with web?

tcberner: ^ what's the issue with `web`?
rigolettoAuthorUnsubmitted
Done
Inline Actions

The web does not have any LIB_DEPENDS, if I do not isolate the "general" LIB_DEPENDS with

. if ${FLAVOR} != web

they will be all built when building transmission-web instead of just packing the /web data. And the ${FLAVOR} seem to just work after setting FLAVORS:

EDIT: Error: Port is broken

rigoletto: The web does not have any LIB_DEPENDS, if I do not isolate the "general" LIB_DEPENDS with .
CLI_RUN_DEPENDS= transmission-cli:net-p2p/transmission-cli
adridgUnsubmitted
Done
Inline Actions

If FLAVOR is needed to set LIB_DEPENDS, then so be it (otherwise you get the silly-but-it-follows-the-rules setup LIB_DEPENDS=<brank>, followed by adding to it depending on the flavor).

adridg: If FLAVOR is needed to set LIB_DEPENDS, then so be it (otherwise you get the silly-but-it…
rigolettoAuthorUnsubmitted
Done
Inline Actions

This just changed the message to:

WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "FLAVORS".

I will let the FLAVORS before LIB_DEPENDS for now to leave the port more "clean".

rigoletto: This just changed the message to: //WARN: Makefile: extra item placed in the *_DEPENDS section…
DAEMON_RUN_DEPENDS= transmission-daemon:net-p2p/transmission-daemon
GTK_RUN_DEPENDS= transmission-gtk:net-p2p/transmission-gtk
QT4_RUN_DEPENDS= transmission-qt4:net-p2p/transmission-qt@qt4
QT5_RUN_DEPENDS= transmission-qt5:net-p2p/transmission-qt@qt5
WEB_RUN_DEPENDS= transmission-cli:www/transmission-web
.include <bsd.port.mk> .include <bsd.port.mk>
adridgUnsubmitted
Done
Inline Actions

Seems superfluous if you're using cmake

adridg: Seems superfluous if you're using cmake
adridgUnsubmitted
Done
Inline Actions

If flavors work like options, perhaps you can just list all of the cmake bools? Then they will be explicitly switched on (or off) as needed.

adridg: If flavors work like options, perhaps you can just list all of the cmake bools? Then they will…
adridgUnsubmitted
Done
Inline Actions

That comment could be more descriptive .. and you might want to avoid installing LICENSE and Makefile.am. Come to think of it, you might even want to set LICENSE_FILE differently for the web flavor.

adridg: That comment could be more descriptive .. and you might want to avoid installing LICENSE and…
rigolettoAuthorUnsubmitted
Done
Inline Actions

This comment is just to identification for now. ^^

rigoletto: This comment is just to identification for now. ^^
tcbernerUnsubmitted
Done
Inline Actions

^ you probably mean gtk_LIB_DEPENDS, and same for the others.

tcberner: ^ you probably mean `gtk_LIB_DEPENDS`, and same for the others.
tcbernerUnsubmitted
Done
Inline Actions

^ CMAKE_BOOL, not CLI_CMAKE_BOOL. Also, as this is no longer an option, you want CMAKE_ON= ENABLE_CLI

tcberner: ^ `CMAKE_BOOL`, not `CLI_CMAKE_BOOL`. Also, as this is no longer an option, you want…
tcbernerUnsubmitted
Done
Inline Actions

CMAKE_ON&OFF, without the old OPTION-prefix :)

tcberner: CMAKE_ON&OFF, without the old OPTION-prefix :)
tcbernerUnsubmitted
Done
Inline Actions

^ probably move this outside of the this is all *ssl related block here

tcberner: ^ probably move this outside of the //this is all *ssl related// block here
tcbernerUnsubmitted
Done
Inline Actions

use more spaces after the dot for nested ifs, otherwise it's very hard to see the nesting
so

.  if ${FLAVOR$ != web
.    if ${FLAVOR} == gtk
[...]
.    endif
.  endif
tcberner: use more spaces after the dot for nested ifs, otherwise it's very hard to see the nesting so…
rigolettoAuthorUnsubmitted
Done
Inline Actions

Oh, I did that at first but had move the dot too. :-)

rigoletto: Oh, I did that at first but had move the dot too. :-)
tcbernerUnsubmitted
Done
Inline Actions

there is a script to do it: /usr/ports/Tools/scripts/indent_make_if.pl :)

tcberner: there is a script to do it: /usr/ports/Tools/scripts/indent_make_if.pl :)
tcbernerUnsubmitted
Done
Inline Actions

pkg-plist.cli seem to be the more common pattern

tcberner: pkg-plist.cli seem to be the more common pattern
rigolettoAuthorUnsubmitted
Done
Inline Actions

I've done that first but looking in the existent ports I had found more -{FLAVOR}. :-D

rigoletto: I've done that first but looking in the existent ports I had found more -{FLAVOR}. :-D