Changeset View
Standalone View
games/barony/Makefile
- This file was added.
# $FreeBSD$ | |||||
PORTNAME= barony | |||||
DISTVERSIONPREFIX= v | |||||
DISTVERSION= 3.1.4 | |||||
CATEGORIES= games | |||||
MAINTAINER= devnexen@gmail.com | |||||
AMDmi3: MASTER_SITES is where you fetch distfiles from. This is bogus in presence of USE_GITHUB. See… | |||||
COMMENT= 3D roguelike game | |||||
LICENSE= GPLv3 | |||||
LICENSE_FILE= ${WRKSRC}/GPL.3.0.txt | |||||
Not Done Inline ActionsAdd LICENSE_FILE tobik: Add `LICENSE_FILE` | |||||
LIB_DEPENDS= libvorbisfile.so:audio/libvorbis \ | |||||
libpng.so:graphics/png \ | |||||
libogg.so:audio/libogg | |||||
USES= cmake compiler:c++11-lib openal:al \ | |||||
Not Done Inline ActionsThe indentation after the variables looks seriously off in the entire file (hard to tell in Phabricator). Indent with one tab or two if needed. tobik: The indentation after the variables looks seriously off in the entire file (hard to tell in… | |||||
localbase:ldflags pkgconfig | |||||
Not Done Inline Actionsmixer2 (aka SDL2_mixer) is commented out in the source i.e., unused. jbeich: `mixer2` (aka `SDL2_mixer`) is commented out in the source i.e., unused. | |||||
USE_GL= gl glu | |||||
USE_SDL= sdl2 image2 net2 ttf2 | |||||
LLD_UNSAFE= yes | |||||
USE_GITHUB= yes | |||||
Not Done Inline ActionsConvert CMAKE_ARGS=-D<VAR>=ON to CMAKE_ON=<VAR> per /usr/ports/CHANGES from 20171231. jbeich: Convert `CMAKE_ARGS=-D<VAR>=ON` to `CMAKE_ON=<VAR>` per `/usr/ports/CHANGES` from `20171231`. | |||||
GH_ACCOUNT= TurningWheel | |||||
Not Done Inline ActionsUSES=localbase preferred AMDmi3: USES=localbase preferred | |||||
Not Done Inline ActionsMaybe qualify type e.g., -DEDITOR_EXE_NAME:STRING="barony-editor" jbeich: Maybe qualify [type](https://cmake.org/cmake/help/v3.0/prop_cache/TYPE.html) e.g., `… | |||||
GH_PROJECT= Barony | |||||
Not Done Inline ActionsSee above about CMAKE_ON. jbeich: See above about `CMAKE_ON`. | |||||
CMAKE_ON= OPENAL_ENABLED DATA_DIR | |||||
Not Done Inline ActionsNot needed. AMDmi3: Not needed. | |||||
CMAKE_ARGS= -DEDITOR_EXE_NAME:STRING="barony-editor" | |||||
LDFLAGS+= -Wl,--as-needed | |||||
Not Done Inline ActionsTargets after all definitions please. AMDmi3: Targets after all definitions please. | |||||
Not Done Inline ActionsBetter use SUB_FILES=barony.sh - this will automatically process placeholders from files/barony.sh.in and place resulting file under ${WRKDIR}/barony.sh. Then you'll just have to install it with ${INSTALL_SCRIPT}. Also, instead of a huge effort to rename game binary, you can just move it into libexec/ here: ${MV} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} ${STAGEDIR}${PREFIX}/libexec/${PORTNAME} and call it from the wrapper script. AMDmi3: Better use `SUB_FILES=barony.sh` - this will automatically process placeholders from… | |||||
Not Done Inline Actionsshare/barony is ${DATADIR_REL} or ${DATADIR} (absolute path). If you plan to use bin/${PORTNAME} maybe convert this one as well. jbeich: `share/barony` is `${DATADIR_REL}` or `${DATADIR}` (absolute path). If you plan to use… | |||||
SUB_FILES= barony.sh | |||||
PLIST_FILES= bin/${PORTNAME} \ | |||||
bin/barony-editor \ | |||||
libexec/${PORTNAME} \ | |||||
Not Done Inline ActionsNot consistent with PLIST_FILES: libexec/${PORTNAME} vs. libexec/barony. jbeich: Not consistent with `PLIST_FILES`: `libexec/${PORTNAME}` vs. `libexec/barony`. | |||||
${DATADIR}/lang/en.ttf \ | |||||
${DATADIR}/lang/en.txt | |||||
Not Done Inline ActionsNot consistent with PLIST_FILES: bin/${PORTNAME} vs. bin/barony. jbeich: Not consistent with `PLIST_FILES`: `bin/${PORTNAME}` vs. `bin/barony`. | |||||
post-install: | |||||
${MV} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} \ | |||||
${STAGEDIR}${PREFIX}/libexec/${PORTNAME} | |||||
${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME}.sh \ | |||||
${STAGEDIR}${PREFIX}/bin/${PORTNAME} | |||||
.include <bsd.port.mk> |
MASTER_SITES is where you fetch distfiles from. This is bogus in presence of USE_GITHUB. See not about WWW: in pkg-descr