Changeset View
Standalone View
multimedia/handbrake/Makefile
| # Created by: Andrew Thompson <andy@fud.org.nz> | # Created by: Andrew Thompson <andy@fud.org.nz> | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= handbrake | PORTNAME= handbrake | ||||
| DISTVERSION= 1.1.0 | DISTVERSION= 1.1.0 | ||||
tcberner: ^ as the line already changes, you can switch it to DISTVERSION. | |||||
| CATEGORIES= multimedia | CATEGORIES= multimedia | ||||
| DIST_SUBDIR= ${PORTNAME} | DIST_SUBDIR= ${PORTNAME} | ||||
| MAINTAINER= naito.yuichiro@gmail.com | MAINTAINER= naito.yuichiro@gmail.com | ||||
| COMMENT= Versatile DVD ripper and video transcoder | COMMENT= Versatile DVD ripper and video transcoder | ||||
| LICENSE= GPLv2 | LICENSE= GPLv2 | ||||
| LICENSE_FILE= ${WRKSRC}/COPYING | LICENSE_FILE= ${WRKSRC}/COPYING | ||||
| ONLY_FOR_ARCHS= amd64 i386 | ONLY_FOR_ARCHS= amd64 i386 | ||||
| ONLY_FOR_ARCHS_REASON= invokes x86 assembler | |||||
Not Done Inline ActionsONLY_FOR_ARCH=i386 amd64 seems more idiomatic to express that. tcberner: `ONLY_FOR_ARCH=i386 amd64` seems more idiomatic to express that.
[[https://www.freebsd. | |||||
| BUILD_DEPENDS= bash:shells/bash \ | BUILD_DEPENDS= bash:shells/bash \ | ||||
| yasm:devel/yasm \ | yasm:devel/yasm \ | ||||
| cmake:devel/cmake | cmake:devel/cmake | ||||
| LIB_DEPENDS= libdbus-1.so:devel/dbus \ | LIB_DEPENDS= libdbus-1.so:devel/dbus \ | ||||
| libharfbuzz.so:print/harfbuzz \ | libharfbuzz.so:print/harfbuzz \ | ||||
| libfontconfig.so:x11-fonts/fontconfig \ | libfontconfig.so:x11-fonts/fontconfig \ | ||||
| libfreetype.so:print/freetype2 \ | libfreetype.so:print/freetype2 \ | ||||
| libfribidi.so:converters/fribidi \ | libfribidi.so:converters/fribidi \ | ||||
| ▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Lines | |||||
| FDK_AAC_DESC= Enable non-free Fraunhofer FDK AAC codec | FDK_AAC_DESC= Enable non-free Fraunhofer FDK AAC codec | ||||
| X11_DESC= Build GTK+3 based GUI program | X11_DESC= Build GTK+3 based GUI program | ||||
| FDK_AAC_CONFIGURE_ENABLE= fdk-aac | FDK_AAC_CONFIGURE_ENABLE= fdk-aac | ||||
| FDK_AAC_VARS= LICENSE+=FDK_AAC LICENSE_COMB=multi | FDK_AAC_VARS= LICENSE+=FDK_AAC LICENSE_COMB=multi | ||||
| LICENSE_NAME_FDK_AAC= Software License for The Fraunhofer FDK AAC Codec Library for Android | LICENSE_NAME_FDK_AAC= Software License for The Fraunhofer FDK AAC Codec Library for Android | ||||
| LICENSE_FILE_FDK_AAC= ${WRKDIR}/${DISTFILES:Mfdk*:R:R}/NOTICE | LICENSE_FILE_FDK_AAC= ${WRKDIR}/${DISTFILES:Mfdk*:R:R}/NOTICE | ||||
| LICENSE_PERMS_FDK_AAC= dist-mirror pkg-mirror auto-accept | LICENSE_PERMS_FDK_AAC= dist-mirror pkg-mirror auto-accept | ||||
| # Recent GNU binutils are required to handle inline SSSE3 asm (in x264), and | # Recent GNU binutils are required to handle inline SSSE3 asm (in x264), and | ||||
Not Done Inline ActionsThis whole option block should be changed to use the options helpers tcberner: This whole option block should be changed to use the [[https://www.freebsd. | |||||
| # to support --exclude-libs option for ld(1) when building GUI program | # to support --exclude-libs option for ld(1) when building GUI program | ||||
| X11_CONFIGURE_ENV= COMPILER_PATH=${LOCALBASE}/bin | X11_CONFIGURE_ENV= COMPILER_PATH=${LOCALBASE}/bin | ||||
| X11_MAKE_ENV= COMPILER_PATH=${LOCALBASE}/bin | X11_MAKE_ENV= COMPILER_PATH=${LOCALBASE}/bin | ||||
| X11_CONFIGURE_ON= --disable-gtk-update-checks | X11_CONFIGURE_ON= --disable-gtk-update-checks | ||||
| X11_CONFIGURE_OFF= --disable-gtk | X11_CONFIGURE_OFF= --disable-gtk | ||||
Not Done Inline ActionsExcuse me. naito.yuichiro_gmail.com: Excuse me.
I'm Yuichiro NAITO, submitter of this patch.
Why did you add --disable-gst ?
It… | |||||
Not Done Inline ActionsIt seems to be already there in the current version in the ports tree: tcberner: It seems to be already there in the current version in the ports tree:
`CONFIGURE_ARGS+=… | |||||
Not Done Inline ActionsHi, I compiled on 11.1 with and without --disable-gst. In both cases, the preview of the main window show a frame of the video. Clicking on "show preview" plays that only frame for the length of the video (mp4). It also warns about some gstreamer missing plugins. Can you confirm this behavior? fernape: Hi,
I compiled on 11.1 with and without --disable-gst. In both cases, the preview of the main… | |||||
Not Done Inline ActionsNo, I can't see any warnings on my HandBrake except of 'inhibited 0'. naito.yuichiro_gmail.com: No, I can't see any warnings on my HandBrake except of 'inhibited 0'.
'inhibited 0' is a debug… | |||||
Not Done Inline ActionsThis is the first msg: Then, a second one shows up: In this system I have the following gstreamer packages: $ pkg info -x 'gstreamer.*' In the console I see only this message: fernape: This is the first msg:
https://www.dropbox.com/s/nadocvs1cwoiof1/msg.png?dl=0
Then, a second… | |||||
Not Done Inline ActionsThank you so much. "X11_USE= gstreamer1=gdkpixbuf,libav" If someone claims the redundancy, naito.yuichiro_gmail.com: Thank you so much.
I found gstreamer1-libav plugin is needed for preview.
Gstreamer1-libav… | |||||
Not Done Inline ActionsIt works for me now. Thanks! fernape: It works for me now.
Thanks! | |||||
| X11_BUILD_DEPENDS= ${LOCALBASE}/bin/ld:devel/binutils | X11_BUILD_DEPENDS= ${LOCALBASE}/bin/ld:devel/binutils | ||||
| X11_LIB_DEPENDS= libvpx.so:multimedia/libvpx \ | X11_LIB_DEPENDS= libvpx.so:multimedia/libvpx \ | ||||
| libnotify.so:devel/libnotify | libnotify.so:devel/libnotify | ||||
| X11_USES= gettext desktop-file-utils | X11_USES= gettext desktop-file-utils | ||||
| X11_USE= gstreamer1=gdkpixbuf,libav \ | X11_USE= gstreamer1=gdkpixbuf,libav \ | ||||
| gnome=gtk30,intltool,cairo,gdkpixbuf2 | gnome=gtk30,intltool,cairo,gdkpixbuf2 | ||||
| # HandBrake tries to fetch its dependencies during build phase, which is not | # HandBrake tries to fetch its dependencies during build phase, which is not | ||||
| Show All 15 Lines | |||||
^ as the line already changes, you can switch it to DISTVERSION.