Page MenuHomeFreeBSD
Differential D15063 Diff 41627 multimedia/handbrake/Makefile

Changeset View

Standalone View

View Options

multimedia/handbrake/Makefile

# Created by: Andrew Thompson <andy@fud.org.nz> # Created by: Andrew Thompson <andy@fud.org.nz>
# $FreeBSD$ # $FreeBSD$
PORTNAME= handbrake PORTNAME= handbrake
PORTVERSION= 1.0.7 DISTVERSION= 1.1.0
tcbernerUnsubmitted
Not Done
Inline Actions

^ as the line already changes, you can switch it to DISTVERSION.

tcberner: ^ as the line already changes, you can switch it to DISTVERSION.
PORTREVISION= 5
CATEGORIES= multimedia CATEGORIES= multimedia
DIST_SUBDIR= ${PORTNAME} DIST_SUBDIR= ${PORTNAME}
MAINTAINER= ports@FreeBSD.org MAINTAINER= naito.yuichiro@gmail.com
COMMENT= Versatile DVD ripper and video transcoder COMMENT= Versatile DVD ripper and video transcoder
LICENSE= GPLv2 LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/COPYING LICENSE_FILE= ${WRKSRC}/COPYING
ONLY_FOR_ARCHS= amd64 i386
tcbernerUnsubmitted
Not Done
Inline Actions

ONLY_FOR_ARCH=i386 amd64 seems more idiomatic to express that.
Porters Handbook

tcberner: `ONLY_FOR_ARCH=i386 amd64` seems more idiomatic to express that. [[https://www.freebsd.
BUILD_DEPENDS= bash:shells/bash \ BUILD_DEPENDS= bash:shells/bash \
yasm:devel/yasm \ yasm:devel/yasm \
cmake:devel/cmake cmake:devel/cmake
LIB_DEPENDS= libdbus-1.so:devel/dbus \ LIB_DEPENDS= libdbus-1.so:devel/dbus \
libharfbuzz.so:print/harfbuzz \ libharfbuzz.so:print/harfbuzz \
libfontconfig.so:x11-fonts/fontconfig \ libfontconfig.so:x11-fonts/fontconfig \
libfreetype.so:print/freetype2 \ libfreetype.so:print/freetype2 \
libfribidi.so:converters/fribidi \ libfribidi.so:converters/fribidi \
libxml2.so:textproc/libxml2 \ libxml2.so:textproc/libxml2 \
libass.so:multimedia/libass \ libass.so:multimedia/libass \
libogg.so:audio/libogg \ libogg.so:audio/libogg \
libvorbis.so:audio/libvorbis \ libvorbis.so:audio/libvorbis \
libvorbisenc.so:audio/libvorbis \ libvorbisenc.so:audio/libvorbis \
libtheoradec.so:multimedia/libtheora \ libtheoradec.so:multimedia/libtheora \
libtheoraenc.so:multimedia/libtheora \ libtheoraenc.so:multimedia/libtheora \
libsamplerate.so:audio/libsamplerate \ libsamplerate.so:audio/libsamplerate \
libx264.so:multimedia/libx264 \ libx264.so:multimedia/libx264 \
libmp3lame.so:audio/lame \ libmp3lame.so:audio/lame \
libopus.so:audio/opus \ libopus.so:audio/opus \
libjansson.so:devel/jansson libjansson.so:devel/jansson
BROKEN_aarch64= invokes x86 assembler CONTRIB_FILES= fdk-aac-0.1.5.tar.gz \
BROKEN_armv6= invokes x86 assembler libav-12.3.tar.gz \
BROKEN_armv7= invokes x86 assembler libbluray-1.0.2.tar.bz2 \
BROKEN_mips= invokes x86 assembler libdvdnav-5.0.3.tar.bz2 \
BROKEN_mips64= invokes x86 assembler libdvdread-5.0.3.tar.bz2 \
BROKEN_sparc64= invokes x86 assembler libvpx-1.6.1.tar.bz2 \
BROKEN_powerpc64= invokes x86 assembler x265_2.6.tar.gz
MASTER_SITES+= https://download.handbrake.fr/contrib/:contrib
USE_GITHUB= yes
GH_ACCOUNT= HandBrake
GH_PROJECT= HandBrake
CONTRIB_FILES= fdk-aac-0.1.4.tar.gz \
libav-12.tar.gz \
libbluray-0.9.3.tar.bz2 \
libdvdnav-5.0.1.tar.bz2 \
libdvdread-5.0.0-6-gcb1ae87.tar.gz \
libvpx-1.5.0.tar.bz2 \
x265_2.1-1.tar.gz
MASTER_SITES+= http://download.handbrake.fr/contrib/:contrib
DISTFILES+= ${CONTRIB_FILES:S/$/:contrib/} DISTFILES+= ${CONTRIB_FILES:S/$/:contrib/}
.if !defined(PACKAGE_BUILDING) .if !defined(PACKAGE_BUILDING)
# DVDCSS version hardcoded in contrib/libdvdread/libdvdread-5.0.0-6-gcb1ae87/src/dvd_input.c (dlopen'ed) # DVDCSS version hardcoded in contrib/libdvdread/libdvdread-5.0.0-6-gcb1ae87/src/dvd_input.c (dlopen'ed)
LIB_DEPENDS+= libdvdcss.so:multimedia/libdvdcss LIB_DEPENDS+= libdvdcss.so:multimedia/libdvdcss
.endif .endif
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
USE_GCC= yes
USES= autoreconf:build compiler:features gmake iconv \ USES= autoreconf:build compiler:features gmake iconv \
libtool:build localbase:ldflags pkgconfig python:2.7,build libtool:build localbase:ldflags pkgconfig python:2.7,build
MAKE_ENV= V=1 ACLOCAL=${LOCALBASE}/bin/aclocal MAKE_ENV= V=1 ACLOCAL=${LOCALBASE}/bin/aclocal
USE_GITHUB= yes
GH_ACCOUNT= HandBrake
GH_PROJECT= HandBrake
USE_GCC= yes
CONFIGURE_ARGS= --force --enable-x265 CONFIGURE_ARGS= --force --enable-x265
CONFIGURE_TARGET= build CONFIGURE_TARGET= build
BUILD_WRKSRC= ${WRKSRC}/build BUILD_WRKSRC= ${WRKSRC}/build
INSTALL_WRKSRC= ${WRKSRC}/build INSTALL_WRKSRC= ${WRKSRC}/build
MAKEFILE= GNUmakefile MAKEFILE= GNUmakefile
ALL_TARGET= # ALL_TARGET= #
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
Show All 14 Lines
FDK_AAC_DESC= Enable non-free Fraunhofer FDK AAC codec FDK_AAC_DESC= Enable non-free Fraunhofer FDK AAC codec
X11_DESC= Build GTK+3 based GUI program X11_DESC= Build GTK+3 based GUI program
FDK_AAC_CONFIGURE_ENABLE= fdk-aac FDK_AAC_CONFIGURE_ENABLE= fdk-aac
FDK_AAC_VARS= LICENSE+=FDK_AAC LICENSE_COMB=multi FDK_AAC_VARS= LICENSE+=FDK_AAC LICENSE_COMB=multi
LICENSE_NAME_FDK_AAC= Software License for The Fraunhofer FDK AAC Codec Library for Android LICENSE_NAME_FDK_AAC= Software License for The Fraunhofer FDK AAC Codec Library for Android
LICENSE_FILE_FDK_AAC= ${WRKDIR}/${DISTFILES:Mfdk*:R:R}/NOTICE LICENSE_FILE_FDK_AAC= ${WRKDIR}/${DISTFILES:Mfdk*:R:R}/NOTICE
LICENSE_PERMS_FDK_AAC= dist-mirror pkg-mirror auto-accept LICENSE_PERMS_FDK_AAC= dist-mirror pkg-mirror auto-accept
.include <bsd.port.options.mk>
# Recent GNU binutils are required to handle inline SSSE3 asm (in x264), and # Recent GNU binutils are required to handle inline SSSE3 asm (in x264), and
tcbernerUnsubmitted
Not Done
Inline Actions

This whole option block should be changed to use the options helpers

tcberner: This whole option block should be changed to use the [[https://www.freebsd.
# to support --exclude-libs option for ld(1) when building GUI program # to support --exclude-libs option for ld(1) when building GUI program
.if ${PORT_OPTIONS:MX11} X11_CONFIGURE_ENV= COMPILER_PATH=${LOCALBASE}/bin
CONFIGURE_ENV+= COMPILER_PATH=${LOCALBASE}/bin X11_MAKE_ENV= COMPILER_PATH=${LOCALBASE}/bin
MAKE_ENV+= COMPILER_PATH=${LOCALBASE}/bin X11_CONFIGURE_ON= --disable-gtk-update-checks
CONFIGURE_ARGS+= --disable-gtk-update-checks --disable-gst X11_CONFIGURE_OFF= --disable-gtk
naito.yuichiro_gmail.comUnsubmitted
Not Done
Inline Actions

Excuse me.
I'm Yuichiro NAITO, submitter of this patch.
Why did you add --disable-gst ?
It disables preview feature of HandBrake.
Are there any problem for this feature?

naito.yuichiro_gmail.com: Excuse me. I'm Yuichiro NAITO, submitter of this patch. Why did you add --disable-gst ? It…
tcbernerUnsubmitted
Not Done
Inline Actions

It seems to be already there in the current version in the ports tree:
CONFIGURE_ARGS+= --disable-gtk-update-checks --disable-gst

tcberner: It seems to be already there in the current version in the ports tree: `CONFIGURE_ARGS+=…
fernapeAuthorUnsubmitted
Not Done
Inline Actions

Hi,

I compiled on 11.1 with and without --disable-gst. In both cases, the preview of the main window show a frame of the video. Clicking on "show preview" plays that only frame for the length of the video (mp4). It also warns about some gstreamer missing plugins.

Can you confirm this behavior?

fernape: Hi, I compiled on 11.1 with and without --disable-gst. In both cases, the preview of the main…
naito.yuichiro_gmail.comUnsubmitted
Not Done
Inline Actions

No, I can't see any warnings on my HandBrake except of 'inhibited 0'.
'inhibited 0' is a debug message that upsteram missed deleting before 1.1.0 release.
Could you show me the message?
I believe preview requires gstreamer1-plugins-gdkpixbuf.
I want to check if another plugin is required or not.

naito.yuichiro_gmail.com: No, I can't see any warnings on my HandBrake except of 'inhibited 0'. 'inhibited 0' is a debug…
fernapeAuthorUnsubmitted
Not Done
Inline Actions

This is the first msg:
https://www.dropbox.com/s/nadocvs1cwoiof1/msg.png?dl=0

Then, a second one shows up:
https://www.dropbox.com/s/7jut7j2bw2c5n4c/msg2.png?dl=0

In this system I have the following gstreamer packages:

$ pkg info -x 'gstreamer.*'
gstreamer-0.10.36_6
gstreamer-plugins-0.10.36_8,3
gstreamer1-1.12.3
gstreamer1-plugins-1.12.3
gstreamer1-plugins-gdkpixbuf-1.12.3
gstreamer1-plugins-good-1.12.3

In the console I see only this message:
$ ./HandBrake
Xlib: extension "GLX" missing on display ":0.0".

fernape: This is the first msg: https://www.dropbox.com/s/nadocvs1cwoiof1/msg.png?dl=0 Then, a second…
naito.yuichiro_gmail.comUnsubmitted
Not Done
Inline Actions

Thank you so much.
I found gstreamer1-libav plugin is needed for preview.
Gstreamer1-libav plugin depends on ffmpeg package.
It seems redundant because HandBrake is a video encoder, too.
But I don't mind the redundancy.
GUI interface includes preview feature is important.
So please include libav plugin like as following line.

"X11_USE= gstreamer1=gdkpixbuf,libav"

If someone claims the redundancy,
I will make a port option to switch preview on/off.
It's a future work not now.

naito.yuichiro_gmail.com: Thank you so much. I found gstreamer1-libav plugin is needed for preview. Gstreamer1-libav…
fernapeAuthorUnsubmitted
Not Done
Inline Actions

It works for me now.

Thanks!

fernape: It works for me now. Thanks!
BUILD_DEPENDS+= ${LOCALBASE}/bin/ld:devel/binutils X11_BUILD_DEPENDS= ${LOCALBASE}/bin/ld:devel/binutils
LIB_DEPENDS+= libvpx.so:multimedia/libvpx \ X11_LIB_DEPENDS= libvpx.so:multimedia/libvpx \
libdbus-glib-1.so:devel/dbus-glib \
libnotify.so:devel/libnotify libnotify.so:devel/libnotify
USES+= gettext desktop-file-utils X11_USES= gettext desktop-file-utils
USE_GNOME+= gtk30 intltool cairo gdkpixbuf2 X11_USE= gstreamer1=gdkpixbuf,libav \
.else gnome=gtk30,intltool,cairo,gdkpixbuf2
CONFIGURE_ARGS+= --disable-gtk
.endif
# HandBrake tries to fetch its dependencies during build phase, which is not # HandBrake tries to fetch its dependencies during build phase, which is not
# considered good in FreeBSD. Instead, we will provided the downloaded files. # considered good in FreeBSD. Instead, we will provided the downloaded files.
post-extract: .SILENT post-extract: .SILENT
${MKDIR} ${WRKSRC}/download ${MKDIR} ${WRKSRC}/download
.for f in ${CONTRIB_FILES} .for f in ${CONTRIB_FILES}
${CP} ${DISTDIR}/${DIST_SUBDIR}/${f} ${WRKSRC}/download ${CP} ${DISTDIR}/${DIST_SUBDIR}/${f} ${WRKSRC}/download
.endfor .endfor
Show All 9 Lines