Page MenuHomeFreeBSD
Differential D9930 Diff 41196 lib/libvmmapi/vmmapi.h

Changeset View

Standalone View

View Options

lib/libvmmapi/vmmapi.h

Context not available.
int vm_suspended_cpus(struct vmctx *ctx, cpuset_t *cpus); int vm_suspended_cpus(struct vmctx *ctx, cpuset_t *cpus);
int vm_activate_cpu(struct vmctx *ctx, int vcpu); int vm_activate_cpu(struct vmctx *ctx, int vcpu);
/* CPU topology */
int vm_set_topology(struct vmctx *ctx, uint16_t sockets, uint16_t cores,
uint16_t threads, uint16_t maxcpus);
int vm_get_topology(struct vmctx *ctx, uint16_t *sockets, uint16_t *cores,
uint16_t *threads, uint16_t *maxcpus);
/* /*
grehanUnsubmitted
Done
Inline Actions

The type for these should be uin16_t - there is no need for it to be a 64-bit type.

grehan: The type for these should be uin16_t - there is no need for it to be a 64-bit type.
rgrimesAuthorUnsubmitted
Done
Inline Actions

When I started on this task you told me to be QEMU compatible, so I did that, I looked at QEMU both for syntax and data types:
This is from qemu/vl.c
Static void smp_parse(QemuOpts *opts)
{

if (opts) {
    unsigned cpus    = qemu_opt_get_number(opts, "cpus", 0);
    unsigned sockets = qemu_opt_get_number(opts, "sockets", 0);
    unsigned cores   = qemu_opt_get_number(opts, "cores", 0);
    unsigned threads = qemu_opt_get_number(opts, "threads", 0);

We usually express "unsigned" as uint64_t in the kernel, are
you sure you want me to change these all to uint16_t?.

rgrimes: When I started on this task you told me to be QEMU compatible, so I did that, I looked at QEMU…
grehanUnsubmitted
Done
Inline Actions

"unsigned" would correspond to uint32_t, but there is no point in even using something that size so I prefer uint16_t.

grehan: "unsigned" would correspond to uint32_t, but there is no point in even using something that…
rgrimesAuthorUnsubmitted
Done
Inline Actions

My mistake, I was thinking the sizeof(int) on amd64 would be 8 not 4. I'll change all the types to uint16_t.
It would of been more productive to have this request in the first review.

rgrimes: My mistake, I was thinking the sizeof(int) on amd64 would be 8 not 4. I'll change all the…
* FreeBSD specific APIs * FreeBSD specific APIs
*/ */
Context not available.