Page MenuHomeFreeBSD
Differential D14699 Diff 40368 net-p2p/transmission/Makefile

Changeset View

Standalone View

View Options

net-p2p/transmission/Makefile

# $FreeBSD$ # $FreeBSD$
PORTNAME= transmission PORTNAME= transmission
PORTVERSION= 2.93 DISTVERSION= 2.93
CATEGORIES= net-p2p CATEGORIES= net-p2p
PKGNAMESUFFIX= -${FLAVOR}
MAINTAINER= crees@FreeBSD.org MAINTAINER= crees@FreeBSD.org
COMMENT= Meta-port for Transmission BitTorrent client COMMENT= Transmission is a fast, easy, and free BitTorrent client
RUN_DEPENDS= transmission-cli:net-p2p/transmission-cli \ # Still need to figure out how to add LICENSE per FLAVOR
transmission-daemon:net-p2p/transmission-daemon \ # since some of the FLAVORS do have more permissive LICENSE.
transmission-gtk:net-p2p/transmission-gtk # Alternativelly, if possible, use LICENSE_GROUP then.
LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
CONFLICTS_INSTALL= ${PORTNAME}${PKGNAMESUFFIX}-2.[56]* # FLAVOR should come after LIB_DEPENDS but I couldn't find a
# workaround to the web FLAVOR which does not have LIB_DEPENDS.
FLAVORS= cli daemon gtk qt4 qt5 web
FLAVOR?= ${FLAVORS:[1]}
USES= metaport . if ${FLAVOR} != web
LIB_DEPENDS= libcurl.so:ftp/curl \
libdht.so:devel/jech-dht \
libb64.so:converters/libb64 \
libevent.so:devel/libevent \
libnatpmp.so:net/libnatpmp \
libutp.so:net/libutp \
libminiupnpc.so:net/miniupnpc
. endif
GTK_LIB_DEPENDS= libdbus-glib-1.so:devel/dbus-glib \
libnotify.so:devel/libnotify
QT4_LIB_DEPENDS= libfontconfig.so:x11-fonts/fontconfig \
libfreetype.so:print/freetype2
QT5_LIB_DEPENDS= libfontconfig.so:x11-fonts/fontconfig \
libfreetype.so:print/freetype2
GTK_RUN_DEPENDS= xdg-open:devel/xdg-utils
USES= cpe gmake iconv libtool localbase pkgconfig
USE_GITHUB= yes
. if ${FLAVOR} == daemon
USE_RC_SUBR= transmission
USERS= transmission
GROUPS= transmission
. endif
. if ${FLAVOR} == gtk
USES+= desktop-file-utils gettext pathfix
USE_GNOME= cairo gtk30 intlhack
INSTALLS_ICONS= yes
. endif
. if ${FLAVOR} == qt4
USES+= compiler:c++11-lib desktop-file-utils
USE_QT4= moc_build qmake_build rcc_build uic_build \
corelib dbus gui network xml
QT_NONSTANDARD= yes
. endif
. if ${FLAVOR} == qt5
USES+= compiler:c++11-lib desktop-file-utils
USE_QT5= buildtools_build qmake_build \
core dbus gui network widgets
QT_NONSTANDARD= yes
. endif
. if ${FLAVOR} == web
USES= cpe
PORTDATA= web
NO_BUILD= yes
. endif
. if ${FLAVOR} != web
LIBS+= ${ICONV_LIB}
CONFIGURE_ENV= ${ICONV_LIB:C@.+@ac_cv_func_iconv=yes@}
EXTRA_PATCHES= ${PATCHDIR}/disable-web
GNU_CONFIGURE= yes
. endif
CPE_VENDOR= transmissionb
EXTRACT_AFTER_ARGS= --no-same-owner --no-same-permissions --exclude third-party
# Setting CONFIGURE_ARGS only.
. if ${FLAVOR} != web
CONFIGURE_ARGS= --without-inotify \
--enable-external-b64 \
--enable-external-dht \
--enable-external-natpmp
. endif
. if ${FLAVOR} == cli
CONF_ARGS+= --enable-cli \
--disable-daemon \
--without-gtk \
--disable-mac \
--disable-nls
. endif
. if ${FLAVOR} == daemon
CONF_ARGS+= --disable-cli \
--enable-daemon \
--without-gtk \
--disable-mac \
--disable-nls
. endif
. if ${FLAVOR} == gtk
CONF_ARGS+= --disable-cli \
--disable-daemon \
--with-gtk \
--disable-mac \
--enable-nls
. endif
. if ${FLAVOR} == qt4
CONF_ARGS= --disable-cli \
--disable-daemon \
--without-gtk \
--disable-mac \
--disable-nls
. endif
. if ${FLAVOR} == qt5
CONF_ARGS+= --disable-cli \
--disable-daemon \
--without-gtk \
--disable-mac \
--disable-nls
. endif
# Setting OPTIONS
. if ${FLAVOR} != web
OPTIONS_DEFINE= DOCS LITE
OPTIONS_DEFAULT= OPENSSL
OPTIONS_SINGLE= SSL
OPTIONS_SINGLE_SSL= OPENSSL POLARSSL WOLFSSL
LITE_CONFIGURE_ENABLE= lightweight
OPENSSL_USES= ssl
OPENSSL_CONFIGURE_ENV= OPENSSL_CFLAGS="-I${OPENSSLINC}" \
OPENSSL_LIBS="-L${OPENSSLLIB} -lcrypto"
OPENSSL_CONFIGURE_ON= --with-crypto=openssl
POLARSSL_LIB_DEPENDS= libpolarssl.so:security/polarssl13
POLARSSL_CONFIGURE_ON= --with-crypto=polarssl
WOLFSSL_LIB_DEPENDS= libwolfssl.so:security/wolfssl
WOLFSSL_CONFIGURE_ON= --with-crypto=cyassl
WOLFSSL_BROKEN= Requires security/wolfssl built with --enable-arc4
. endif
DOCS= AUTHORS NEWS README
DOCSDIR= ${PREFIX}/share/doc/${PORTNAME}${PKGNAMESUFFIX}
# Still need to understand how patch work for FLAVORS. For some reason they
# fail to apply to every FLAVOR; however removing them already allow to the
# -web FLAVOR build.
. if ${FLAVOR} != web
general-patch:
@${FIND} ${WRKSRC} -name Makefile.in | ${XARGS} ${REINPLACE_CMD} -e \
's|noinst_PROGRAMS = |noinst_PROGRAMS = #|g'
. if ${FLAVOR} != gtk
@${REINPLACE_CMD} -e '/#define DISABLE_GETTEXT/s,/\* \(.*\) \*/,\1,' \
${WRKSRC}/libtransmission/utils.h
. endif
@${REINPLACE_CMD} -e \
's|rt_clock_gettime=yes|rt_clock_gettime=no|g ; \
s|" == "|" = "|g' \
${WRKSRC}/configure
@${REINPLACE_CMD} -e 's|doc \\| \\|g' \
${WRKSRC}/Makefile.in
. if ${FLAVOR} != cli
@${REINPLACE_CMD} -e 's|utils \\|\\|g' \
${WRKSRC}/Makefile.in
. endif
# Don't conflict with patches but force system libraries
@${REINPLACE_CMD} -e 's|third-party \\|\\|g' \
${WRKSRC}/Makefile.in
@${REINPLACE_CMD} \
-e 's|third-party/[^ ]*Makefile||g' \
${WRKSRC}/configure
post-patch: general-patch
general-install:
(cd ${WRKSRC} && ${COPYTREE_SHARE} \
"${DOCS}" ${STAGEDIR}${DOCSDIR})
post-install: general-install
. endif
# Install -web stuff
. if ${FLAVOR} == web
post-extract:
@${FIND} ${WRKSRC}/web -name Makefile.* -delete
@${FIND} ${WRKSRC}/web -name .git* -delete
do-install:
${MKDIR} ${STAGEDIR}${DATADIR}/web
(cd ${WRKSRC}/web && ${COPYTREE_SHARE} \* ${STAGEDIR}${DATADIR}/web)
. endif
.include <bsd.port.mk> .include <bsd.port.mk>
adridgUnsubmitted
Done
Inline Actions

The web flavor (assuming it's just the files in web/) is GPLv2-only, for instance. You could say GPLv2 here and be not-wrong.

adridg: The web flavor (assuming it's just the files in web/) is GPLv2-only, for instance. You could…
rigolettoAuthorUnsubmitted
Done
Inline Actions

I will let this LICENSE issue for when I manage to the last. :o)

Thanks

rigoletto: I will let this LICENSE issue for when I manage to the last. :o) Thanks
adridgUnsubmitted
Done
Inline Actions

If FLAVOR is needed to set LIB_DEPENDS, then so be it (otherwise you get the silly-but-it-follows-the-rules setup LIB_DEPENDS=<brank>, followed by adding to it depending on the flavor).

adridg: If FLAVOR is needed to set LIB_DEPENDS, then so be it (otherwise you get the silly-but-it…
rigolettoAuthorUnsubmitted
Done
Inline Actions

This just changed the message to:

WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "FLAVORS".

I will let the FLAVORS before LIB_DEPENDS for now to leave the port more "clean".

rigoletto: This just changed the message to: //WARN: Makefile: extra item placed in the *_DEPENDS section…
adridgUnsubmitted
Done
Inline Actions

Seems superfluous if you're using cmake

adridg: Seems superfluous if you're using cmake
adridgUnsubmitted
Done
Inline Actions

If flavors work like options, perhaps you can just list all of the cmake bools? Then they will be explicitly switched on (or off) as needed.

adridg: If flavors work like options, perhaps you can just list all of the cmake bools? Then they will…
adridgUnsubmitted
Done
Inline Actions

That comment could be more descriptive .. and you might want to avoid installing LICENSE and Makefile.am. Come to think of it, you might even want to set LICENSE_FILE differently for the web flavor.

adridg: That comment could be more descriptive .. and you might want to avoid installing LICENSE and…
rigolettoAuthorUnsubmitted
Done
Inline Actions

This comment is just to identification for now. ^^

rigoletto: This comment is just to identification for now. ^^
tcbernerUnsubmitted
Done
Inline Actions

^ you probably mean gtk_LIB_DEPENDS, and same for the others.

tcberner: ^ you probably mean `gtk_LIB_DEPENDS`, and same for the others.
tcbernerUnsubmitted
Done
Inline Actions

^ CMAKE_BOOL, not CLI_CMAKE_BOOL. Also, as this is no longer an option, you want CMAKE_ON= ENABLE_CLI

tcberner: ^ `CMAKE_BOOL`, not `CLI_CMAKE_BOOL`. Also, as this is no longer an option, you want…
tcbernerUnsubmitted
Done
Inline Actions

CMAKE_ON&OFF, without the old OPTION-prefix :)

tcberner: CMAKE_ON&OFF, without the old OPTION-prefix :)
tcbernerUnsubmitted
Done
Inline Actions

^ what's the issue with web?

tcberner: ^ what's the issue with `web`?
rigolettoAuthorUnsubmitted
Done
Inline Actions

The web does not have any LIB_DEPENDS, if I do not isolate the "general" LIB_DEPENDS with

. if ${FLAVOR} != web

they will be all built when building transmission-web instead of just packing the /web data. And the ${FLAVOR} seem to just work after setting FLAVORS:

EDIT: Error: Port is broken

rigoletto: The web does not have any LIB_DEPENDS, if I do not isolate the "general" LIB_DEPENDS with .
tcbernerUnsubmitted
Done
Inline Actions

^ probably move this outside of the this is all *ssl related block here

tcberner: ^ probably move this outside of the //this is all *ssl related// block here
tcbernerUnsubmitted
Done
Inline Actions

use more spaces after the dot for nested ifs, otherwise it's very hard to see the nesting
so

.  if ${FLAVOR$ != web
.    if ${FLAVOR} == gtk
[...]
.    endif
.  endif
tcberner: use more spaces after the dot for nested ifs, otherwise it's very hard to see the nesting so…
rigolettoAuthorUnsubmitted
Done
Inline Actions

Oh, I did that at first but had move the dot too. :-)

rigoletto: Oh, I did that at first but had move the dot too. :-)
tcbernerUnsubmitted
Done
Inline Actions

there is a script to do it: /usr/ports/Tools/scripts/indent_make_if.pl :)

tcberner: there is a script to do it: /usr/ports/Tools/scripts/indent_make_if.pl :)
tcbernerUnsubmitted
Done
Inline Actions

pkg-plist.cli seem to be the more common pattern

tcberner: pkg-plist.cli seem to be the more common pattern
rigolettoAuthorUnsubmitted
Done
Inline Actions

I've done that first but looking in the existent ports I had found more -{FLAVOR}. :-D

rigoletto: I've done that first but looking in the existent ports I had found more -{FLAVOR}. :-D