Changeset View
Changeset View
Standalone View
Standalone View
lua54/files/patch-src_Makefile
| Property | Old Value | New Value |
|---|---|---|
| fbsd:nokeywords | null | yes \ No newline at end of property |
| svn:eol-style | null | native \ No newline at end of property |
| svn:mime-type | null | text/plain \ No newline at end of property |
| --- src/Makefile.orig 2018-03-16 06:04:55 UTC | |||||
| +++ src/Makefile | |||||
| @@ -99,7 +99,7 @@ c89: | |||||
| freebsd: | |||||
| - $(MAKE) $(ALL) SYSCFLAGS="-DLUA_USE_LINUX -DLUA_USE_READLINE" SYSLIBS="-Wl,-E -lreadline" | |||||
| + $(MAKE) $(ALL) SYSCFLAGS="-DLUA_USE_LINUX -DLUA_USE_READLINE" SYSLIBS="-Wl,-E" | |||||
| generic: $(ALL) | |||||
andrew_tao173.riddles.org.uk: If you're going to remove -lreadline here, it seems more logical to also remove… | |||||
Not Done Inline ActionsLDFLAGS already had MYLDFLAGS included in it; don't add it again. andrew_tao173.riddles.org.uk: LDFLAGS already had MYLDFLAGS included in it; don't add it again. | |||||
Done Inline Actions-DLUA_USE_READLINE definitely needs to be removed from here now, the EDITNONE option of the port breaks if it's left in. (Sorry, forgot to mention that when I sent the makefile changes.) andrew_tao173.riddles.org.uk: -DLUA_USE_READLINE definitely needs to be removed from here now, the EDITNONE option of the… | |||||
If you're going to remove -lreadline here, it seems more logical to also remove -DLUA_USE_READLINE and pass that in via MYCFLAGS. This has the advantage that you can make it an option for the port (on by default).