Differential D12785 Diff 40025 lib/libc/tests/stdio/gets_s_test.c

Changeset View

Standalone View

lib/libc/tests/stdio/gets_s_test.c

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				/*-
				* Copyright (c) 2017 Cyril S. E. Schubert. All rights reserved.
				*
				* Redistribution and use in source and binary forms, with or without
				* modification, are permitted provided that the following conditions
				* are met:
				* 1. Redistributions of source code must retain the above copyright
				* notice, this list of conditions and the following disclaimer.
				* 2. Redistributions in binary form must reproduce the above copyright
				* notice, this list of conditions and the following disclaimer in the
				* documentation and/or other materials provided with the distribution.
				*
				* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
				* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
				* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
				* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
				* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
				* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
				* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
				* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
				* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
				* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
				* SUCH DAMAGE.
				*/

				#include <sys/cdefs.h>
				__FBSDID("$FreeBSD$");

				#include <assert.h>
				#include <stdint.h>
				#include <stdio.h>
				#include <stdlib.h>
				edUnsubmitted Done Inline Actions This include needs to be in a separate block above `<assert.h>`. ed: This include needs to be in a separate block above `<assert.h>`.
				cyAuthorUnsubmitted Not Done Inline Actions Sorry about this. I was in a bit of a hurry to put it out there prior to tinderbox and testing. cy: Sorry about this. I was in a bit of a hurry to put it out there prior to tinderbox and testing.
				#include <sys/types.h>
				edUnsubmitted Not Done Inline Actions The `<sys/...>` headers need to be above the others. ed: The `<sys/...>` headers need to be above the others.
				#include <unistd.h>
				edUnsubmitted Done Inline Actions Doesn't this need to be `<sys/wait.h>`? Do we even provide a header with that name? ed: Doesn't this need to be `<sys/wait.h>`? Do we even provide a header with that name?
				#include <sys/wait.h>

				#include <atf-c.h>

				static errno_t error_code;
				edUnsubmitted Done Inline Actions Could these have more descriptive names? Also no need to put `restrict` here. This keyword only makes sense on function arguments. ed: Could these have more descriptive names? Also no need to put `restrict` here. This keyword only…
				cyAuthorUnsubmitted Not Done Inline Actions That had crossed my mind. cy: That had crossed my mind.
				static const char * message;

				void
				h(const char * msg, void * ptr __unused, errno_t error)
				{
				error_code = error;
				message = msg;
				}

				/* null ptr */
				ATF_TC_WITHOUT_HEAD(null_ptr);
				ATF_TC_BODY(null_ptr, tc)
				{
				edUnsubmitted Done Inline Actions Wouldn't it be better to use `ATF_CHECK()` here? ed:* Wouldn't it be better to use `ATF_CHECK*()` here?
				ATF_CHECK_MSG(gets_s(NULL, 1) == NULL,
				"gets_s() failed to handle NULL pointer");
				}

				/* normal */
				ATF_TC_WITHOUT_HEAD(normal);
				ATF_TC_BODY(normal, tc)
				{
				pid_t kidpid;
				int fd[2];
				int nfd;

				// close(STDIN_FILENO);
				// close(STDOUT_FILENO);
				edUnsubmitted Done Inline Actions That `==` is not intended, right? Also: missing whitespace between `>=` and `0`. ed: That `==` is not intended, right? Also: missing whitespace between `>=` and `0`.
				cyAuthorUnsubmitted Not Done Inline Actions Oops. cy: Oops.
				pipe(fd);

				if ((kidpid = fork()) == 0) {
				char b[10];

				close(fd[1]);
				nfd = dup2(fd[0], 0);
				close(fd[0]);
				stdin = fdopen(nfd, "r");
				ATF_CHECK_MSG(gets_s(b, sizeof(b)) == 0, "gets_s() normal failed");
				fclose(stdin);
				} else {
				int stat;

				close(fd[0]);
				stdout = fdopen(fd[1], "w");
				puts("a sting");
				fclose(stdout);
				(void) waitpid(kidpid, &stat, WEXITED);
				}
				}

				/* n > rmax */
				ATF_TC_WITHOUT_HEAD(n_gt_rmax);
				ATF_TC_BODY(n_gt_rmax, tc)
				{
				char b;

				ATF_CHECK_MSG(gets_s(&b, RSIZE_MAX + 1) == NULL,
				"gets_s() n > RSIZE_MAX");
				}

				/* n == 0 */
				ATF_TC_WITHOUT_HEAD(n_eq_zero);
				ATF_TC_BODY(n_eq_zero, tc)
				{
				char b;

				ATF_CHECK_MSG(gets_s(&b, 0) == NULL, "gets_s() n is zero");
				}

				/* n > rmax, handler */
				ATF_TC_WITHOUT_HEAD(n_gt_rmax_handler);
				ATF_TC_BODY(n_gt_rmax_handler, tc)
				{
				char b;

				error_code = 0;
				message = NULL;
				set_constraint_handler_s(h);
				ATF_CHECK_MSG(gets_s(&b, RSIZE_MAX + 1) == NULL, "gets_s() n > RSIZE_MAX");
				ATF_CHECK_MSG(error_code > 0, "gets_s() error code is %d", error_code);
				ATF_CHECK_MSG(strcmp(message, "gets_s : n > RSIZE_MAX") == 0, "gets_s(): incorrect error message");
				}

				/* n == 0, handler */
				ATF_TC_WITHOUT_HEAD(n_eq_zero_handler);
				ATF_TC_BODY(n_eq_zero_handler, tc)
				{
				char b;

				error_code = 0;
				message = NULL;
				set_constraint_handler_s(h);
				ATF_CHECK(gets_s(&b, 0) == NULL);
				ATF_CHECK_MSG(error_code > 0, "gets_s() error code is %d", error_code);
				ATF_CHECK_MSG(strcmp(message, "gets_s : n == 0") == 0, "gets_s(): incorrect error message");
				}

				ATF_TP_ADD_TCS(tp)
				{
				ATF_TP_ADD_TC(tp, null_ptr);
				ATF_TP_ADD_TC(tp, normal);
				ATF_TP_ADD_TC(tp, n_gt_rmax);
				ATF_TP_ADD_TC(tp, n_eq_zero);
				ATF_TP_ADD_TC(tp, n_gt_rmax_handler);
				ATF_TP_ADD_TC(tp, n_eq_zero_handler);
				return (atf_no_error());
				}