Page MenuHomeFreeBSD
Differential D14212 Diff 38958 sys/x86/x86/local_apic.c

Changeset View

Standalone View

View Options

sys/x86/x86/local_apic.c

Show First 20 Lines • Show All 195 Lines • ▼ Show 20 Lines
static int lapic_timer_tsc_deadline; static int lapic_timer_tsc_deadline;
static u_long lapic_timer_divisor, count_freq; static u_long lapic_timer_divisor, count_freq;
static struct eventtimer lapic_et; static struct eventtimer lapic_et;
#ifdef SMP #ifdef SMP
static uint64_t lapic_ipi_wait_mult; static uint64_t lapic_ipi_wait_mult;
#endif #endif
unsigned int max_apic_id; unsigned int max_apic_id;
SYSCTL_NODE(_hw, OID_AUTO, apic, CTLFLAG_RD, 0, "APIC options"); SYSCTL_NODE(_hw, OID_AUTO, apic, CTLFLAG_RD, 0,
SYSCTL_INT(_hw_apic, OID_AUTO, x2apic_mode, CTLFLAG_RD, &x2apic_mode, 0, ""); "APIC options");
kibUnsubmitted
Not Done
Inline Actions

This is indicator of the selected mode, not an enable switch. After that, I do not see any other way to say it other than "x2APIC mode", and now the description becomes useless.

kib: This is indicator of the selected mode, not an enable switch. After that, I do not see any…
mhorne063_gmail.comAuthorUnsubmitted
Not Done
Inline Actions

I agree that the description becomes somewhat useless. However, I will keep it in simply for consistency and to reduce the possibility of confusion if a user were to think there was a greater explanation that was missing.

mhorne063_gmail.com: I agree that the description becomes somewhat useless. However, I will keep it in simply for…
SYSCTL_INT(_hw_apic, OID_AUTO, x2apic_mode, CTLFLAG_RD, &x2apic_mode, 0,
"x2APIC mode");
SYSCTL_INT(_hw_apic, OID_AUTO, eoi_suppression, CTLFLAG_RD, SYSCTL_INT(_hw_apic, OID_AUTO, eoi_suppression, CTLFLAG_RD,
&lapic_eoi_suppression, 0, ""); &lapic_eoi_suppression, 0,
"EOI suppression mode");
kibUnsubmitted
Done
Inline Actions

Same there.

Also, the previous string was formatted stylish, Bruce wants the description to start on a new line always.

kib: Same there. Also, the previous string was formatted stylish, Bruce wants the description to…
SYSCTL_INT(_hw_apic, OID_AUTO, timer_tsc_deadline, CTLFLAG_RD, SYSCTL_INT(_hw_apic, OID_AUTO, timer_tsc_deadline, CTLFLAG_RD,
&lapic_timer_tsc_deadline, 0, ""); &lapic_timer_tsc_deadline, 0,
"Timer TSC-Deadline mode");
kibUnsubmitted
Done
Inline Actions

And there.

kib: And there.
static uint32_t static uint32_t
lapic_read32(enum LAPIC_REGISTERS reg) lapic_read32(enum LAPIC_REGISTERS reg)
{ {
uint32_t res; uint32_t res;
if (x2apic_mode) { if (x2apic_mode) {
res = rdmsr32(MSR_APIC_000 + reg); res = rdmsr32(MSR_APIC_000 + reg);
▲ Show 20 Lines • Show All 1,935 Lines • Show Last 20 Lines