Changeset View
Standalone View
sysutils/google-compute-engine-oslogin/Makefile
- This file was added.
| # $FreeBSD$ | |||||
| PORTNAME= google-compute-engine-oslogin | |||||
| DISTVERSION= 1.1.2 | |||||
| CATEGORIES= sysutils | |||||
mat: Use `DISTVERSION` here. | |||||
| MAINTAINER= helen.koike@collabora.com | |||||
Done Inline ActionsNot needed. ultima: Not needed. | |||||
| COMMENT= OS Login Guest Environment for Google Compute Engine | |||||
| LICENSE= APACHE20 | |||||
| LICENSE_FILE= ${WRKSRC}/../LICENSE | |||||
| LIB_DEPENDS= libcurl.so:ftp/curl \ | |||||
| libjson-c.so:devel/json-c | |||||
| RUN_DEPENDS= gsed:textproc/gsed \ | |||||
| ${LOCALBASE}/lib/pam_mkhomedir.so:security/pam_mkhomedir | |||||
| USES= gmake | |||||
Not Done Inline ActionsUsually shared objects are LIB_DEPENDS. Are you sure this is a RUN_DEPEND? ultima: Usually shared objects are LIB_DEPENDS. Are you sure this is a RUN_DEPEND? | |||||
Not Done Inline ActionsPam modules are only loaded at runtime. mat: Pam modules are only loaded at runtime. | |||||
| USE_LDCONFIG= yes | |||||
| USE_GCC= any | |||||
| USE_GITHUB= yes | |||||
| GH_ACCOUNT= GoogleCloudPlatform | |||||
| GH_PROJECT= compute-image-packages | |||||
Done Inline ActionsThis should be after USES and before MAKE_ARGS ultima: This should be after USES and before MAKE_ARGS | |||||
Not Done Inline ActionsIf the version is 20171213, then the version should be that, not 1.1.2. mat: If the version is 20171213, then the version should be that, not 1.1.2. | |||||
Not Done Inline ActionsThe git tag is listed as 20171213, but in the source Makefile the version is defined as 1.1.2. Its kind of weird but I think this is actually correct. Do you think this should still be changed? ultima: The git tag is listed as 20171213, but in the source Makefile the version is defined as 1.1.2. | |||||
Not Done Inline ActionsI would say yes, but there is also a 1.1.2 tag that dates back from 2014, and there have been tags up to 1.3.3, at which point they changed to date tags. I do not think the 1.1.2 in the Makefile is the version of the software, only the version of the shared library. mat: I would say yes, but there is also a 1.1.2 tag that dates back from 2014, and there have been… | |||||
Not Done Inline ActionsIn the Debian package that the upstream project maintain, the version is 1.1.2 koike@deb9:~$ dpkg -l | grep google-compute ii google-compute-engine 2.7.2-2 all Google Compute Engine guest environment. ii google-compute-engine-oslogin 1.1.2-1+deb9 amd64 Google Compute Engine OS Login ii python-google-compute-engine 2.7.2-2 all Google Compute Engine python library for Python 2.x. ii python3-google-compute-engine 2.7.2-2 all Google Compute Engine python library for Python 3.x. This same upstream git repository maintains several packages. the google-compute-engine package has its version number and the google-compute-engine-oslogin has another version number. helen.koike_collabora.com: In the Debian package that the upstream project maintain, the version is 1.1.2
```
koike@deb9… | |||||
Not Done Inline ActionsI missed the versioning at the bottom. The devs probably decided its too annoying to use the major/minor/patch versioning based on the README.md at the bottom and changed to using date. Using date as the devs decided to switch to is the right call IMO. ultima: I missed the versioning at the bottom. The devs probably decided its too annoying to use the… | |||||
Not Done Inline ActionsPlease, see comment on the matter from the upstream maintainer here https://github.com/GoogleCloudPlatform/compute-image-packages/issues/533#issuecomment-357001546 helen.koike_collabora.com: Please, see comment on the matter from the upstream maintainer here https://github. | |||||
| GH_TAGNAME= 20171213 | |||||
| MAKE_ARGS= JSON_INCLUDE_PATH=${LOCALBASE}/include/json-c \ | |||||
| BIN_INSTALL_PATH=/bin \ | |||||
| PAM_INSTALL_PATH=/lib \ | |||||
| AUTHKEYS_INSTALL_PATH=/bin \ | |||||
| NSS_LIBRARY_SONAME=nss_oslogin.so.1 | |||||
| WRKSRC_SUBDIR= google_compute_engine_oslogin | |||||
| PLIST_SUB= DISTVERSION=${DISTVERSION} | |||||
Done Inline ActionsSHEBANG_FILES is listed but shebangfix is not in USES. Are you sure this is needed? ultima: SHEBANG_FILES is listed but shebangfix is not in USES. Are you sure this is needed? | |||||
| post-patch: | |||||
| @${REINPLACE_CMD} -e 's|/etc/sudoers.d|${PREFIX}/etc/sudoers.d|g ; \ | |||||
Done Inline ActionsThe append flag here is probably not necessary. This can be checked with "make -V PLIST_SUB". ultima: The append flag here is probably not necessary. This can be checked with "make -V PLIST_SUB". | |||||
| s|/usr/bin|${PREFIX}/bin|g' ${WRKSRC}/bin/google_oslogin_control | |||||
| post-install: | |||||
| ${LN} -sf libnss_${PORTNAME}-${DISTVERSION}.so ${STAGEDIR}${PREFIX}/lib/nss_oslogin.so.1 | |||||
Done Inline ActionsThis could be combined into a single command: @${REINPLACE_CMD} -e 's|/etc/sudoers.d|${PREFIX}/etc/sudoers.d|g ; \ s|/usr/bin|${PREFIX}/bin|g' ${WRKSRC}/bin/google_oslogin_controlultima: This could be combined into a single command:
@${REINPLACE_CMD} -e 's|/etc/sudoers. | |||||
| ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/google_authorized_keys \ | |||||
| ${STAGEDIR}${PREFIX}/lib/libnss_google-compute-engine-oslogin-${DISTVERSION}.so \ | |||||
| ${STAGEDIR}${PREFIX}/lib/pam_oslogin_admin.so \ | |||||
| ${STAGEDIR}${PREFIX}/lib/pam_oslogin_login.so | |||||
| .include <bsd.port.mk> | |||||
Done Inline ActionsThere seems to be two tabs at the start of the lines here, one is enough. mat: There seems to be two tabs at the start of the lines here, one is enough. | |||||
Not Done Inline ActionsThis could be combined into a single command. ultima: This could be combined into a single command. | |||||
Use DISTVERSION here.