Differential D13811 Diff 37797 sysutils/google-compute-engine-oslogin/pkg-plist

Changeset View

Standalone View

				bin/google_authorized_keys
				bin/google_oslogin_control
				lib/libnss_google-compute-engine-oslogin-%%PORTVERSION%%.so
				lib/nss_oslogin.so.1
				ultimaUnsubmitted Done Inline Actions This should have a PLIST_SUB entry for PORTVERSION, then use %%PORTVERSION%% so the plist doesn't need to be generated for each update. ultima: This should have a PLIST_SUB entry for PORTVERSION, then use %%PORTVERSION%% so the plist…
				matUnsubmitted Done Inline Actions s/should/could/ mat: s/should/could/
				ultimaUnsubmitted Done Inline Actions Yes, thanks I have a bad habit of being authoritative in my wording. This is not my intent. ultima: Yes, thanks I have a bad habit of being authoritative in my wording. This is not my intent.
				matUnsubmitted Done Inline Actions Words have meaning :-) And even in this review, there are places where "should" could have been used, for the MASTER_SITES "this is not needed and should be removed". This, here, is not something that must be changed, only one that you think could be done in another way. mat: Words have meaning :-) And even in this review, there are places where "should" could have been…
				lib/pam_oslogin_admin.so
				lib/pam_oslogin_login.so