Page MenuHomeFreeBSD
Differential D13219 Diff 35723 x11-themes/xfce-evolution/Makefile

Changeset View

Standalone View

View Options

x11-themes/xfce-evolution/Makefile

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= xfce-evolution
DISTVERSION= 3.1.6
CATEGORIES= x11-themes
MASTER_SITES= SF/${THEME:tW:tl:S/ /-/g}
tcbernerUnsubmitted
Done
Inline Actions
^ is this a joke? ^^
tcberner: ^ is this a joke? ^^
yuriAuthorUnsubmitted
Done
Inline Actions

No, it reuses the THEME variable.
Would you prefer to just type the text instead?

yuri: No, it reuses the THEME variable. Would you prefer to just type the text instead?
tcbernerUnsubmitted
Done
Inline Actions

well, the punchline is on line 3, isn't it?

tcberner: well, the punchline is on line 3, isn't it?
adamwUnsubmitted
Done
Inline Actions

I am definitely laughing!

Is the subdir likely to change? If not, it's probably safe to hardcode it.

adamw: I am definitely laughing! Is the subdir likely to change? If not, it's probably safe to…
MAINTAINER= fbsd@opal.com
matUnsubmitted
Done
Inline Actions
MASTER_SITES=        SF/${THEME:tW:tl:S/ /-/g}

Never use MASTER_SITE_SUBDIR.

mat: ``` MASTER_SITES= SF/${THEME:tW:tl:S/ /-/g} ``` Never use MASTER_SITE_SUBDIR.
yuriAuthorUnsubmitted
Done
Inline Actions

Updated.
Should MASTER_SITE_SUBDIR be renamed into _MASTER_SITE_SUBDIR then in Mk/?

yuri: Updated. Should MASTER_SITE_SUBDIR be renamed into _MASTER_SITE_SUBDIR then in Mk/?
COMMENT= Complete Xfce Evolution Gtk2, Gtk3, Qt4, Qt5, wxWidgets, Xfce themes
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/COPYRIGHT
RUN_DEPENDS= gtk-murrine-engine>0:x11-themes/gtk-murrine-engine \
qt5-style-plugins>0:x11-themes/qt5-style-plugins
USES= zip:infozip # infozip because unzip on 10 doesn't unpack symbolic links
tcbernerUnsubmitted
Done
Inline Actions

^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long paths :)

tcberner: ^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long…
yuriAuthorUnsubmitted
Done
Inline Actions

How to do this?

For example, RUN_DEPENDS=gtk-murrine-engine:x11-themes/gtk-murrine-engine doesn't work.

yuri: How to do this? For example, `RUN_DEPENDS=gtk-murrine-engine:x11-themes/gtk-murrine-engine`…
tcbernerUnsubmitted
Done
Inline Actions

|Porters Handbook

A minimal version of a dependency can be specified in any *_DEPENDS except LIB_DEPENDS using this syntax:

p5-Spiffy>=0.26:devel/p5-Spiffy

The first field contains a dependent package name, which must match the entry in the package database, a comparison sign, and a package version. The > dependency is satisfied if p5-Spiffy-0.26 or newer is installed on the machine.

I grant you it's nicer to depend on a file, but these paths just look too long and subject o change :D

tcberner: [[https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-version…
yuriAuthorUnsubmitted
Done
Inline Actions

This didn't occur to me fast enough. -)

yuri: This didn't occur to me fast enough. -)
USE_GNOME= gtk20:build
NO_BUILD= yes
NO_ARCH= yes
EXTRACT_AFTER_ARGS= -d ${DISTNAME}
THEME= Xfce Evolution
do-install:
@${MKDIR} ${STAGEDIR}${PREFIX}/share/themes
@cd ${WRKSRC} && \
for d in "${THEME} "*; do \
tgt=$$(${ECHO} $$d | ${SED} 's/ /-/g'); \
tcbernerUnsubmitted
Done
Inline Actions

^ I think you could come up with something nicer here
a) is it really important to get rid of the whitespaces?
b) you only want to replace the whitepsaces in "Xfce Theme <Foo>", so maybe iterate over the Foo's you want to install and do a ${COPYTREE_SHARE} "Xfce Theme ${FOO}" ${STAGEDIR}${PREFIX}/share/themes/Xfce-Theme-${FOO}"
or some valid variation thereof.

Which might look a bit cleaner.

tcberner: ^ I think you could come up with something nicer here a) is it really important to get rid of…
yuriAuthorUnsubmitted
Done
Inline Actions

I simplified it. -)

yuri: I simplified it. -)
(cd "$$d" && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/share/themes/$$tgt); \
done
@${REINPLACE_CMD} -i '' -e 's|^#!/bin/bash|#!/bin/sh|' ${STAGEDIR}${PREFIX}/share/themes/*/00.[0-4]0
tcbernerUnsubmitted
Done
Inline Actions

^out of curiousity. Have you checked whether they are really not requiring any bash features?

tcberner: ^out of curiousity. Have you checked whether they are really not requiring any bash features?
yuriAuthorUnsubmitted
Done
Inline Actions

-) Of course I did. They are all very simple and plain scripts.

yuri: -) Of course I did. They are all very simple and plain scripts.
tcbernerUnsubmitted
Done
Inline Actions

very good :)

tcberner: very good :)
.include <bsd.port.mk>
adamwUnsubmitted
Done
Inline Actions

Just FYI, if you wanted to, you could also use shebangfix here, which is very precise about how it modifies files.

USES=shebangfix
SHEBANG_REGEX= 00.[0-4]0
bash_CMD=/bin/sh
adamw: Just FYI, if you wanted to, you could also use shebangfix here, which is very precise about how…